From 003c5ac4101853f3814bbf5e3dc920b37a18deaa Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Fri, 11 Nov 2016 00:08:11 +0000 Subject: [PATCH] Use a blank temp document when selection is empty shallowCloneFromRange can a broken document if you pass a collapsed range. That should be fixed upstream but for now this fixes a major bug (and is faster). Bug: T150492 Change-Id: I9b539c588d91ef7f22e662c7cae0b3f89b21d33a --- modules/ve-mw/ui/actions/ve.ui.MWWikitextWindowAction.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ve-mw/ui/actions/ve.ui.MWWikitextWindowAction.js b/modules/ve-mw/ui/actions/ve.ui.MWWikitextWindowAction.js index 38aa1f4fa7..6764ddf0da 100644 --- a/modules/ve-mw/ui/actions/ve.ui.MWWikitextWindowAction.js +++ b/modules/ve-mw/ui/actions/ve.ui.MWWikitextWindowAction.js @@ -51,7 +51,7 @@ ve.ui.MWWikitextWindowAction.prototype.open = function ( name, data, action ) { originalFragment = fragment; originalDocument = originalFragment.getDocument(); coveringRange = originalFragment.getSelection().getCoveringRange(); - if ( coveringRange ) { + if ( coveringRange && !coveringRange.isCollapsed() ) { tempDocument = surface.getModel().getDocument().shallowCloneFromRange( coveringRange ); rangeInDocument = tempDocument.originalRange; } else {