Commit graph

2433 commits

Author SHA1 Message Date
Roan Kattouw 5f9f913fb6 ApiCoreThankIntegrationTest: Fix intermittent failures
Every time the setup function runs, it chooses a random page name with
random content. If it chooses a page name + content combination that was
used to set up a different test in the same run, the edit it makes will
be a null edit, the revid will be null, and the test will crash.

There are 100 possible page names and 100 possible page texts, so 10k
possibilities total, and the setup function appears to be called 10 times,
so the probability of a collision would have been
(10 choose 2)/10000 = 0.0045 = 0.45%, or one in every 222 times.

Bug: T151878
Change-Id: I800ee8512c2ad171ba793bea343f456653f9a16d
2018-03-19 18:03:27 -07:00
Translation updater bot 8f6eff3aea Localisation updates from https://translatewiki.net.
Change-Id: Ib7cc46a4fddc9eea606671a0496e2fa36b165044
2018-03-19 22:20:01 +01:00
Sam Wilson 30e582bd96 Add support for log-thanks to Special:Thanks
A new "Special:Thanks/Log/123" subpage format is added for
sending thanks for the given log entry. The 'Log' part of the
subpage is case-insensitive.

The form field labels are removed because the fields are hidden
and need no labels.

Bug: T186920
Change-Id: Ic2279d9a6dc170d1eeee519392d3a930a37bc2ec
2018-03-19 10:59:20 +08:00
Translation updater bot ac98427f82 Localisation updates from https://translatewiki.net.
Change-Id: Idb6206a1ed3c8b4f226348906f544ecce25ef905
2018-03-15 22:52:20 +01:00
jenkins-bot cf92013106 Merge "Revert "Add revision-thanking links to some log entries"" 2018-03-14 22:23:34 +00:00
Reedy 2735468029 Revert "Add revision-thanking links to some log entries"
This reverts commit 9f393ef9dd.

Change-Id: Ie76fef8dc25b1134f1f60da50a87b00115154041
2018-03-14 21:49:25 +00:00
Translation updater bot c3e7ac3387 Localisation updates from https://translatewiki.net.
Change-Id: Ib15a04fca3fcc3ebea2ac874bb6d901aa996bbef
2018-03-14 22:23:54 +01:00
Sam Wilson 9f393ef9dd Add revision-thanking links to some log entries
Many log entries are associated to (exactly one) revision,
and for these (only, and only where the log type is
whitelisted) we add a thank-link that behaves exactly
as the thank-link on diff and history pages.

Bug: T186763
Change-Id: I2af380d5cb06f19ef9eb5b232d95ad87379b5d9b
2018-03-13 09:33:15 +08:00
Translation updater bot 5bec0a1ae4 Localisation updates from https://translatewiki.net.
Change-Id: I77890f396c59722351e412d4ce77f641b1f41d07
2018-03-12 22:25:35 +01:00
Translation updater bot b4a8b1dbb1 Localisation updates from https://translatewiki.net.
Change-Id: Ie7efddc573df793e9fecf06c655da2b26a824953
2018-03-11 22:31:19 +01:00
Translation updater bot b4c6b01d69 Localisation updates from https://translatewiki.net.
Change-Id: Id08d3842529475c873fa5b962a77b5e7cf631e1d
2018-03-10 22:14:28 +01:00
libraryupgrader b73ff15abb build: Updating jakub-onderka/php-parallel-lint to 1.0.0
Change-Id: I32fcb4002e9190d6203caaedf0eace6c8f440ccc
2018-03-10 06:11:45 +00:00
Translation updater bot 7270f6fb34 Localisation updates from https://translatewiki.net.
Change-Id: I35b222d94608ea71b33755b8f34010fa4cdb6e38
2018-03-09 22:42:21 +01:00
jenkins-bot 199cd68d13 Merge "Reintroduce the API to thank for log entries" 2018-03-09 19:38:53 +00:00
Translation updater bot dd0945972a Localisation updates from https://translatewiki.net.
Change-Id: I74acffd98bfbc156750810950f154019a5b5b872
2018-03-07 22:48:02 +01:00
Translation updater bot 6d3a5cf5c8 Localisation updates from https://translatewiki.net.
Change-Id: I6a083aea743b9185ec6ff2401cb69150943efd39
2018-03-06 22:18:53 +01:00
Max Semenik ed087b044c Reintroduce the API to thank for log entries
Originally introduced in b84eedc74e, it was reverted for security concerns.
New changes:
* Instead of bundling the log summary with notification, load it on display
* If the log event has been suppressed after the thanks for it has been sent,
  silently delete the event to prevent the confusion of linking to something
  zapped.
* Keep the 'already sent' cache key compatible with old format
* Validate the log id in the API
* Change ApiCoreThank::getRevisionFromParams() to ApiCoreThank::getRevisionFromId()

Bug: T186855
Bug: T188791
Depends-On: Ic5e9db0def857d9dcecbd06bf081c8c83712c1ea
Change-Id: I03aea7d9f4dfa0fe49639c53968deabf89999d2d
2018-03-06 13:08:47 +08:00
Translation updater bot 4caa24b128 Localisation updates from https://translatewiki.net.
Change-Id: I96edbf06388f086125ff086f7af0e9a3dd7df332
2018-03-05 22:25:04 +01:00
Translation updater bot ce2fda530d Localisation updates from https://translatewiki.net.
Change-Id: I4f42c24895471f06e77fc5c6db73bcb6177e940f
2018-03-03 22:25:55 +01:00
jenkins-bot 5320dc3508 Merge "Revert "Add support to the Thanks API for thanking log entries"" 2018-03-02 23:11:37 +00:00
MaxSem 3b2397fea9 Revert "Add support to the Thanks API for thanking log entries"
This reverts commit b84eedc74e.

Bug: T188791
Change-Id: If55ed6cbb5da34c0034da3cc564c6a8ff82448d2
2018-03-02 22:59:20 +00:00
Translation updater bot 080271ea17 Localisation updates from https://translatewiki.net.
Change-Id: I1438a45ea982b51387d034a121bd20c26c72f54f
2018-03-02 22:31:32 +01:00
jenkins-bot b976d2850c Merge "Add support to the Thanks API for thanking log entries" 2018-03-02 06:14:28 +00:00
Sam Wilson b84eedc74e Add support to the Thanks API for thanking log entries
Add a 'log' API parameter (for the log ID to thank), and add
a whitelist config variable for specifying which log types are
thankable.

Bug: T186855
Change-Id: I58ae90c9729c0066f952e90fca2cf99b029d0d9b
2018-03-01 14:57:57 -08:00
Translation updater bot c8cbb94435 Localisation updates from https://translatewiki.net.
Change-Id: I9d0a1e147370217008c0f109909939e8ec142108
2018-03-01 22:42:06 +01:00
Translation updater bot f97436bbe3 Localisation updates from https://translatewiki.net.
Change-Id: I5cc25cd0e847444eb349da80b82904b9636dc152
2018-02-28 22:27:44 +01:00
Translation updater bot 27a49b181f Localisation updates from https://translatewiki.net.
Change-Id: I3256cff572e9b633dbb040f4f226a164143e0f02
2018-02-27 22:26:00 +01:00
Translation updater bot a0398e81bf Localisation updates from https://translatewiki.net.
Change-Id: I46c3678e0119fb42966a452b4bc11c6d57e43573
2018-02-26 22:20:53 +01:00
libraryupgrader e754b25c6a build: Updating mediawiki/mediawiki-codesniffer to 16.0.1
Change-Id: Ife7f2123e5e1adeabef0dd15123c8508df683280
2018-02-25 11:38:42 +00:00
jenkins-bot 9c708f1ac2 Merge "Add jquery.cookie dependency" 2018-02-24 00:07:51 +00:00
Translation updater bot 2f55e5951b Localisation updates from https://translatewiki.net.
Change-Id: If0b668ca55bd12db0b2871cc15eafbe5c23d7b8d
2018-02-23 23:01:54 +01:00
Sam Wilson 78831d2b68 Rename files and classes in preparation for adding log-thanks
Bug: T186855
Change-Id: I20f5d200c33e395aca9489b73d0ed9b1d0ad5b8c
2018-02-21 12:49:21 +08:00
Sam Wilson 84834d5b41 Add jquery.cookie dependency
Bug: T187851
Change-Id: I6158f557cbafcfbca7e6c7d3e0c5960250133e46
2018-02-21 11:50:22 +08:00
Translation updater bot 4f1238604b Localisation updates from https://translatewiki.net.
Change-Id: Ib29d255399cdff7e853e472ca3e58df2d13b2c5b
2018-02-20 22:29:07 +01:00
Stephane Bisson 3f139b3dd2 Send thank for the right link
Due to confusion between $thankLinks (plural)
and $thankLink (singular), clicking any thank link
was sending thank for the first thankable revision
on the page.

Introduced in I9097bd976f8da1632577a3f4438b9f1186baca88

Bug: T187757
Change-Id: I7993531206c46657908a66d73369928ccf5dc677
2018-02-20 14:16:18 +00:00
Translation updater bot 29aa780fed Localisation updates from https://translatewiki.net.
Change-Id: I2c254a603a23ae68620aed2d92e44290612dd433
2018-02-19 22:26:01 +01:00
Translation updater bot 7064cc6b1c Localisation updates from https://translatewiki.net.
Change-Id: I6f5c182e4a64cc3b236c2169f9f12fbf31a89571
2018-02-18 22:41:09 +01:00
libraryupgrader 95133ad2bb build: Updating mediawiki/minus-x to 0.3.1
Change-Id: Ie3ec8fad07c225a119a719117e8da17ec615eafb
2018-02-18 10:01:55 +00:00
libraryupgrader a97b396403 build: Updating mediawiki/mediawiki-codesniffer to 16.0.0
Change-Id: Ieda88fa361aecf655f3829c9bbb4e65b16bd9315
2018-02-15 14:32:47 +00:00
James D. Forrester 16909df870 build: Bump devDependencies to latest
eslint-config-wikimedia   0.4.0  →   0.5.0
 grunt                     1.0.1  →   1.0.2
 grunt-eslint             20.0.0  →  20.1.0

Change-Id: I9aeca17ab3bae099b678d37232846bb6abf8ce39
2018-02-14 11:11:22 -08:00
Translation updater bot 2ea1ca659c Localisation updates from https://translatewiki.net.
Change-Id: I1fda08f515da74feb8a8e61340f19436b8d86ce1
2018-02-13 22:25:50 +01:00
jenkins-bot d87fed7b8a Merge "Remove a coding-standard exclusion" 2018-02-12 17:19:41 +00:00
jenkins-bot e614e62948 Merge "Simplify ext.thanks.mobilediff.js" 2018-02-12 17:19:40 +00:00
jenkins-bot ab04467c4b Merge "Simplify by using jQuery" 2018-02-12 17:19:39 +00:00
Sam Wilson 499dc04960 Remove a coding-standard exclusion
Add some parameter comments etc.

Change-Id: Ifb663c69711036ea01cb2b90acaa81d22c74a3af
2018-02-12 09:26:19 +08:00
Translation updater bot 0492a4ec5a Localisation updates from https://translatewiki.net.
Change-Id: I72cb0fdd60d95b0e23cea49baaf45a675e29ce8b
2018-02-11 10:42:25 +01:00
Fomafix 90eef72c48 Simplify ext.thanks.mobilediff.js
* Explicit return null instead of no return.
* Document right @return type.
* Avoid else paths by using early return.

Change-Id: I24c434ebb57188346ad7cd722f08390ba6da2c34
2018-02-10 20:31:17 +01:00
Fomafix 99baf3eff9 Simplify by using jQuery
Change-Id: I31262cc68d0e0d2c6bbdabf496f81da9c1089a0f
2018-02-10 19:33:48 +01:00
Translation updater bot c3586cd4f0 Localisation updates from https://translatewiki.net.
Change-Id: Ie6e57902fec159469627cbd53b921fc478772f44
2018-02-06 22:35:43 +01:00
jenkins-bot c32345f4c2 Merge "Add alias for Serbian Latin" 2018-02-06 17:21:38 +00:00