Commit graph

2150 commits

Author SHA1 Message Date
Kunal Mehta 956a476005 Use log_search to track already sent thanks
We currently use client-side storage to keep track of what revisions and
posts have already been thanked for. This is problematic because client-
side storage is not permanent, making it easy to send duplicate thanks
if you have logged out and in, or switched computers.

This starts storing new thanks in the log_search table, which is
designed for efficient querying of metadata associated with a specific
log entry. With this, we can easily check to see if a user has already
sent thanks for a specific revision.

The UX is a bit weird right now, we only check log_search when actually
sending thanks again, in which case the user thinks they have sent
thanks again, but no duplicate thanks is actually sent.

Bug: T88820
Bug: T53303
Change-Id: Iaf8cbe0776081dc69e82883d8727ba1cfe20e3e1
2015-06-16 11:52:34 -07:00
Kunal Mehta 514e9d4c7f Call mw.Api() constructor properly
Change-Id: I56b3c6e17a509056a5ed5ceb5b4dcb376cdec0c3
2015-06-15 19:58:07 -07:00
Translation updater bot 679e5518ce Localisation updates from https://translatewiki.net.
Change-Id: I8f58ada0036365b24904af1eadf5d77531947273
2015-06-15 22:53:50 +02:00
Translation updater bot 2f3e7e9348 Localisation updates from https://translatewiki.net.
Change-Id: I7ece61683b650b267fe219d3b96c4677a49638a1
2015-06-14 21:16:44 +02:00
Translation updater bot 825060215e Localisation updates from https://translatewiki.net.
Change-Id: I10bf2baa94679ce35dd1f193925b84bcd1ec071c
2015-06-13 22:32:45 +02:00
Kunal Mehta 4b886a4ae5 build: Adding configuration for jsonlint
Change-Id: Ib8b38fa5afaa25057c61d9b7e266d4b37382bea7
2015-06-11 21:50:10 -07:00
Translation updater bot 927547b944 Localisation updates from https://translatewiki.net.
Change-Id: Ie798d840225b8e5a7d3856fc457e1cf513134a0a
2015-06-10 22:47:59 +02:00
Translation updater bot f263746e4d Localisation updates from https://translatewiki.net.
Change-Id: Id81625c52ba879a52ccd4a344b39caa229d27a2f
2015-06-09 22:51:30 +02:00
Translation updater bot f73fd96543 Localisation updates from https://translatewiki.net.
Change-Id: I21ba10777c4a03526a1f3626607a3c54c2216db8
2015-06-08 22:01:16 +02:00
Kunal Mehta 4caf5effe1 Use __DIR__ directly
Change-Id: I26ede931a50cd7549a51e8df3cc4598c72eec52b
2015-06-07 18:00:45 -07:00
Translation updater bot fe19473346 Localisation updates from https://translatewiki.net.
Change-Id: I9fff9547b1d1fcc1fe999c9e7a22642fb4866bb5
2015-06-07 22:32:51 +02:00
Translation updater bot e8e0983ffe Localisation updates from https://translatewiki.net.
Change-Id: Ifbab980846941302bbe50d0649e79d66c714aa2c
2015-06-06 22:23:13 +02:00
Kunal Mehta 2e8f71ae58 Add explicit dependency upon grunt-cli
Change-Id: Iaaa8e2fb7846678973547663e2e6903d831b4b96
2015-06-05 17:29:11 -07:00
Kunal Mehta c737bc60e0 build: Updating development dependencies
* grunt-contrib-csslint: 0.2.0 → 0.4.0
* grunt-contrib-jshint: 0.10.0 → 0.11.2
* grunt-banana-checker: 0.2.0 → 0.2.2
* jshint: ~2.5.0 → 2.8.0

Change-Id: I4b3eb1270ed0ef83f4ee3c5399b83a86ae141a26
2015-06-05 17:16:47 -07:00
Translation updater bot c5b666ddea Localisation updates from https://translatewiki.net.
Change-Id: Ica3ee719d99c0c094ee595898a49eb10579ff038
2015-06-05 21:14:12 +02:00
Translation updater bot 09600586b1 Localisation updates from https://translatewiki.net.
Change-Id: I2c03003546feab689a131016106d3c0702078f1e
2015-05-31 22:17:15 +02:00
Translation updater bot 8588669de8 Localisation updates from https://translatewiki.net.
Change-Id: I6d8e0975e91bc422c830380b2db2e1e6c5fdaef7
2015-05-30 23:10:33 +02:00
Translation updater bot 02f804d27e Localisation updates from https://translatewiki.net.
Change-Id: Ic533b838bc2fbb1c608e0af4b38d57dbb58e93e2
2015-05-29 22:43:40 +02:00
Translation updater bot 6e40742533 Localisation updates from https://translatewiki.net.
Change-Id: Id1f5e6260830c109170d9b714cc12ccbdc278973
2015-05-27 22:31:38 +02:00
Translation updater bot 1d06723c10 Localisation updates from https://translatewiki.net.
Change-Id: I896d6f85ce0901cc78f094ac0d17b5b400aeeb78
2015-05-26 22:27:50 +02:00
Translation updater bot 8706f93c83 Localisation updates from https://translatewiki.net.
Change-Id: Ibe114887450290590f0d9983a634637780c257f6
2015-05-25 22:38:49 +02:00
jenkins-bot 94b79beb70 Merge "Remove message reuse for "send thanks"" 2015-05-25 10:11:01 +00:00
Translation updater bot 835a60b64f Localisation updates from https://translatewiki.net.
Change-Id: I6c3194d31443f598b54098cde1cd7ccfdf9ae766
2015-05-24 23:08:11 +02:00
Douglas Gardner dae848638e Remove message reuse for "send thanks"
Split the special page heading and the submit button into separate
messages. Previously, they used the same message key.

c.f. [[translatewiki:Thread:Support/About_MediaWiki:Thanks/en]].

Change-Id: I3611a0d7716ef3b0fd9d8b981a0445800906e039
2015-05-24 12:10:33 +02:00
Translation updater bot b634773b4e Localisation updates from https://translatewiki.net.
Change-Id: I542278cf57ec03280684c45201bf05a50a38f261
2015-05-24 00:17:18 +02:00
Translation updater bot 07922cfbbb Localisation updates from https://translatewiki.net.
Change-Id: I433ec845d344d52a847a6e4edfa0622cc4ff50e7
2015-05-21 23:02:19 +02:00
Translation updater bot 5068659221 Localisation updates from https://translatewiki.net.
Change-Id: Ie9b49e48480a47ff6631906c0ff69cf6888288fd
2015-05-20 22:18:41 +02:00
Translation updater bot 0d8213e4d8 Localisation updates from https://translatewiki.net.
Change-Id: I2a4ecf653a47ae872f91f15f4202696b91128fe6
2015-05-18 22:22:58 +02:00
Translation updater bot c1119424d5 Localisation updates from https://translatewiki.net.
Change-Id: I0f9abbc3450fd2fb289d538b0a036d0bfa39a3f4
2015-05-17 22:14:14 +02:00
Translation updater bot b9e9dc4188 Localisation updates from https://translatewiki.net.
Change-Id: Ie0a304b70113b54773db10c6497ae15fe59bc2e7
2015-05-16 22:00:58 +02:00
Translation updater bot 727aad70fb Localisation updates from https://translatewiki.net.
Change-Id: I744daabd7b78e278f0f2d05770d8949a4746c6d6
2015-05-15 21:46:18 +02:00
Translation updater bot 9788868292 Localisation updates from https://translatewiki.net.
Change-Id: I5be60e0e666638fb7378c0d81c5efbc88003e8a3
2015-05-14 22:10:13 +02:00
Translation updater bot dcd759c784 Localisation updates from https://translatewiki.net.
Change-Id: I0e84fba9341d6fa5a3be63e70f3f4df01cf7769a
2015-05-13 22:40:30 +02:00
Translation updater bot 510bbf15f1 Localisation updates from https://translatewiki.net.
Change-Id: Ia72a556b5ce4316f902ae0f197e259c43a23ac21
2015-05-12 22:29:15 +02:00
Translation updater bot f16f63a1f1 Localisation updates from https://translatewiki.net.
Change-Id: I93a6cdeaee89666c7fd600bae0468cc1e45ffa2e
2015-05-11 21:52:26 +02:00
Translation updater bot cb05a949c9 Localisation updates from https://translatewiki.net.
Change-Id: If8555e5ef5f7d0e1da5b601edbe206d0972caea8
2015-05-09 21:53:27 +02:00
Translation updater bot 4a39897162 Localisation updates from https://translatewiki.net.
Change-Id: Ide008de6f36ca9da1e32d1f184ddb06a295dc088
2015-05-07 21:29:59 +02:00
Translation updater bot 55fa359ce1 Localisation updates from https://translatewiki.net.
Change-Id: I3ef1d2d7459fed54fe1f2e6935bc4b5a9ac3dce5
2015-05-06 22:02:41 +02:00
Translation updater bot 38d15253af Localisation updates from https://translatewiki.net.
Change-Id: I75e3b729495a923ebde3dfd02132c050d27ce76d
2015-05-05 22:44:32 +02:00
Matthew Flaschen b3a74b2953 Further document Thanks gender (both en and qqq), and fix bug
thanks-thank was using plain, but this did not get caught because
the en value did not have a no-op example GENDER.  I've added
these to all of them, for both $1 and $2.  This also tells translators
they're both available.

Bug: T96527
Change-Id: I5130bbd60fe3c1c8051729758c2f2f4bea2b2030
2015-05-05 00:35:20 -04:00
Moriel Schottlender 0a5664ce5e Check the thanked user's gender for Thanks messages
Retrieve gender data for the thanked user for i18n message parsing
with the correct {{GENDER...}} data.

Bug: T96527
Change-Id: I14c831be51482682f2b628a15c79341a4f372c16
2015-05-04 17:16:09 -07:00
Roan Kattouw 805fefd198 Actually pass jscs
Removed exemptions from .jscsrc and fixed the code so jscs still passes.

Kept the exemption for disallowDanglingUnderscores because
of the naming convention for private functions in this repo.

Change-Id: I860f73394a2b92a411fe682abbb2ab0b5e1325f9
2015-05-04 12:13:43 -07:00
Translation updater bot fcc202724e Localisation updates from https://translatewiki.net.
Change-Id: Id5aab290b537e243e95bbe33d6292b9bb4966c2e
2015-05-02 22:07:02 +02:00
Roan Kattouw 8b9bc3a44f Add Grunt infrastructure for CI
* Add package.json based on Flow's
* Add Gruntfile.js based on Flow's
* Add .csslintrc and .jscsrc with rules to silence errors for now
* Add .gitignore (!) to ignore node_modules/

Change-Id: I2db213da2f0ce77567f7968e73af9cdd6ed9da82
2015-05-01 20:50:15 -07:00
Translation updater bot c7889f2e91 Localisation updates from https://translatewiki.net.
Change-Id: I65dc97108d1afa5b41ddd670fdbc9657ffdbf459
2015-04-30 22:21:59 +02:00
Translation updater bot f1a937cffc Localisation updates from https://translatewiki.net.
Change-Id: Ia0992e50212f584f37cccd8d0ab3d0491d1a47ef
2015-04-29 22:38:01 +02:00
Translation updater bot 1e8c73ff8c Localisation updates from https://translatewiki.net.
Change-Id: If825f3db30c6bb4bb81066cf83938fe7b6343c55
2015-04-28 21:31:16 +02:00
Translation updater bot 20f79ef338 Localisation updates from https://translatewiki.net.
Change-Id: I0f23152c85a117b8095cd7a47b5ccae7ed376791
2015-04-27 22:17:29 +02:00
Translation updater bot f87049afe3 Localisation updates from https://translatewiki.net.
Change-Id: I992fcbf5fa169853e3a4a3eeea29959910c814a1
2015-04-26 22:34:36 +02:00
jenkins-bot 506c928f66 Merge "Remove dead message" 2015-04-25 20:35:52 +00:00