wikimedia/mediawiki-extensions-Thanks
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Thanks synced 2024-11-28 00:30:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: Bump phan to 0.10.2, remove taint-check

Browse source 
Declare a variable which is not set in all branches for static code
analyzer, but at runtime it is

Change-Id: I851bdbf9dc092d5213d74a03427b783f61e8946a
This commit is contained in:
Umherirrender 2020-05-31 17:05:43 +02:00
parent 081ad97a0c
commit e1cd44f28d
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
composer.json
View file

@ -1,7 +1,7 @@
{
"require-dev": {
"mediawiki/mediawiki-codesniffer": "31.0.0",
"mediawiki/mediawiki-phan-config": "0.9.1",
"mediawiki/mediawiki-phan-config": "0.10.2",
"mediawiki/minus-x": "1.0.0",
"php-parallel-lint/php-console-highlighter": "0.4.0",
"php-parallel-lint/php-parallel-lint": "1.0.0"
@ -19,8 +19,5 @@
"doc": [
"doxygen"
]
},
"extra": {
"phan-taint-check-plugin": "2.0.1"
}
}

1
includes/ApiCoreThank.php
View file

@ -37,6 +37,7 @@ class ApiCoreThank extends ApiThank {
throw new LogicException();
}
$recipientUsername = null;
// Determine thanks parameters.
if ( $type === 'log' ) {
$logEntry = $this->getLogEntryFromId( $id );