From e1cd44f28d5a482752a6e8307677ea9cb8f05587 Mon Sep 17 00:00:00 2001
From: Umherirrender <umherirrender_de.wp@web.de>
Date: Sun, 31 May 2020 17:05:43 +0200
Subject: [PATCH] build: Bump phan to 0.10.2, remove taint-check

Declare a variable which is not set in all branches for static code
analyzer, but at runtime it is

Change-Id: I851bdbf9dc092d5213d74a03427b783f61e8946a
---
 composer.json             | 5 +----
 includes/ApiCoreThank.php | 1 +
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/composer.json b/composer.json
index 05a61af4..df98fbf2 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
 	"require-dev": {
 		"mediawiki/mediawiki-codesniffer": "31.0.0",
-		"mediawiki/mediawiki-phan-config": "0.9.1",
+		"mediawiki/mediawiki-phan-config": "0.10.2",
 		"mediawiki/minus-x": "1.0.0",
 		"php-parallel-lint/php-console-highlighter": "0.4.0",
 		"php-parallel-lint/php-parallel-lint": "1.0.0"
@@ -19,8 +19,5 @@
 		"doc": [
 			"doxygen"
 		]
-	},
-	"extra": {
-		"phan-taint-check-plugin": "2.0.1"
 	}
 }
diff --git a/includes/ApiCoreThank.php b/includes/ApiCoreThank.php
index 59ff0171..b9a2828c 100644
--- a/includes/ApiCoreThank.php
+++ b/includes/ApiCoreThank.php
@@ -37,6 +37,7 @@ class ApiCoreThank extends ApiThank {
 			throw new LogicException();
 		}
 
+		$recipientUsername = null;
 		// Determine thanks parameters.
 		if ( $type === 'log' ) {
 			$logEntry = $this->getLogEntryFromId( $id );