… and replace them with more trivial `function …() {}`. I
believe this does not make any difference. But I feel this
makes the code a little more straightforward.
The motivation for this patch is because a few other patches
change some of these function declarations, leaving a (in my
opinion) confusing mixture of styles behind.
Change-Id: Ib8928c4176a963afcf1fee1c785dd7bdc86c9706
Reducing the width further leads to a strange behavior were it fails.
Locally this test is about 30% faster this way.
Change-Id: I5f950041ccf0f2f326ad6d9023d300e6a344f902
Directly measure the jQuery animation using its custom
pseudo-selector. Previously, we had been relying on a side-effect.
Change-Id: I0db8077e9ed86d5be025d089e0467654789bb13f
`aria-disabled` is a bit of a hack, but maybe more robust than
coupling to the OOUI internal class name.
Bug: T267205
Change-Id: I5c1f547f2d25d9acaa74d63da03cd215be82bd71
The numbering in the content of the test revisions was slightly changed
to fit the data-pos attribute numbering in the revision tags.
Note that this is not completely cleaning up the step_definitions
from the Ruby tests. This will be done in a follow up after all
tests are ported.
Bug: T267201
Change-Id: Ifa25b881c6aa1e94a934532606c944a33f5648dd
I don't understand how others are running the tests, but I need this
configuration in order to run. They also appear in the
mediawiki/core wdio.conf.js .
Bug: T180247
Change-Id: Ic75bac41e0bf3cda3b23a4489e02f1dde2300740
These test do not add much value. Expanding the interface is an
essential step done in all other tests. Therefore the only test
ported is manually collapsing the interface.
Note that this is not completely cleaning up the step_definitions
from the Ruby tests. This will be done in a follow up after all
tests are ported.
Bug: T267198
Change-Id: I7beabc1a91f22dc8b7094318bf90684a3deb63f7
Note that this is not completely cleaning up the step_definitions
from the Ruby tests. This will be done in a follow up after all
tests are ported.
Bug: T267198
Change-Id: I75baea2bd104666ba7f6a15ba79e10f7967cddb3
FIXME: Reusing HelpDialog as a module entrypoint creates a circular
reference. It's harmless because the dependencies are added at
different times, but also easy to refactor away.
Change-Id: I3608a78baddf2376cc9eb4524625f4911c130c06
Each RL module comes with the cost of its name + hash being sent over every
request and in the startup module increasing the time to load the page.
Bug: T229791
Change-Id: I3ae230a84112a70ab369ffbff70e173b8f07ec1a
The patch adds a first package of node selenium tests including
test for the user and tag filters.
The classes for user- and tag-rows were re-added to have better
access via selectors.
Change-Id: I8c53d9c923820e177d83ee900cee08e93cd3f65b
This is a direct follow up to the change done in I885f8e7. I found the
code very hard to read after the change, and tried to rearrange it a
little bit. This is what I came up with. What the code does is entirely
untouched.
This also rearranges the replaceWith calls so the replacements are done
from top to bottom.
This patch also avoids calling mw.config.set multiple times.
Change-Id: I1cbce8e8aa030d6ba5cd7d19ab26fa363e13474b
I have seen this failing:
https://integration.wikimedia.org/ci/job/mwext-mw-selenium-jessie/9255/console
The idea is to pre-set this cookie so the help dialog never shows up
in the first place. The tests do not need to look for the element, click
it, wait for the dialog to close. This should even speed up the browser
tests, I believe.
Also this adjustes waiting conditions in several places to address
timing issues with failing browser tests.
Since these tests should be replaced by Node.js on the long run I
added "sleep" in the cases although it's not recommended.
Change-Id: Ida381faa390aa62ebaadd3713864676be80abd51
This patch mainly reintroduces the option to click on bars and move
the pointers with it. To do this, 'ghost' pointers are introduced
to show what would happen when bars are clicked. The pointers moved
differ depending on where the user clicks on a bar. Pointers are
still not allowed to change positions, so in some cases booth pointers
move with one click. See the task description.
The patch also includes some renaming and also refactoring of the
click handling in general. Furthermore bar hover mechanics are handled
by the RevisionListView class now.
Moving both pointers is not possible when it would push one of them of
limits.
Bug: T172092, T173566
Change-Id: I32a8256f7667e03081324d54accdf03a17454faf
Pointers can always be identified as the pointer for the "older" and
"newer" revisions. Class nameing was cleaned up and changed accordingly.
Change-Id: Id17878e780b5a405b196fdc5ec7429eeaef5bd4c
