wikimedia/mediawiki-extensions-RevisionSlider
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2024-11-14 19:24:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use waitForModuleState from Util class

Browse source 
Change-Id: Ida52cf73686a1cc5af5ab955ef30daf15a2ec68a
This commit is contained in:
WMDE-Fisch 2019-10-23 17:50:21 +02:00
parent 970c34f041
commit 5c77b477e6
1 changed files with 1 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/selenium/pageobjects/diff.page.js
View file

@ -15,23 +15,8 @@ class DiffPage extends Page {
getRevision( num ) { return browser.element( '.mw-revslider-revision[data-pos="' + num + '"]' ); }
resourceLoaderModuleStatus( moduleName, moduleStatus, errMsg ) {
// Word of caution: browser.waitUntil returns a Timer class NOT a Promise.
// Webdriver IO will run waitUntil synchronously so not returning it will
// block JavaScript execution while returning it will not.
// http://webdriver.io/api/utility/waitUntil.html
// https://github.com/webdriverio/webdriverio/blob/master/lib/utils/Timer.js
browser.waitUntil( () => {
const result = browser.execute( ( module ) => {
return typeof mw !== 'undefined' &&
mw.loader.getState( module.name ) === module.status;
}, { status: moduleStatus, name: moduleName } );
return result.value;
}, 10000, errMsg );
}
ready() {
this.resourceLoaderModuleStatus( 'ext.RevisionSlider.lazyJs', 'ready', 'RevisionSlider did not load' );
Util.waitForModuleState( 'ext.RevisionSlider.lazyJs' );
}
prepareFilterTests() {