Commit graph

1539 commits

Author SHA1 Message Date
WMDE-Fisch b1225f400a Remove aria-hidden on RevisionSlider
I removed this aria-hidden, because the RevisionSlider as a whole
can be accessed with the focusable button that expands the UI.

Elements that are focusable should not be aria-hidden.
screenreaders in general will allow interaction with these or even
might show unpredictable behavior.

Screenreader and keyboard support for the feature is not good but
this aria-hidden is useless and wrong at the moment.

Bug: T339254
Change-Id: I8b8e3938cba701c821d4fd2ee3c2f90bf7610623
2023-07-10 08:42:01 +02:00
WMDE-Fisch d4693da19f selenium: run tests concurrently
Bug: T337862
Change-Id: Iff2b05070772955f048010010b1bac38881c54ec
2023-06-23 15:01:41 +02:00
Adam Wight b900446572 Migrate JS to ES6
Reintroduces IIFE closures in test files because variables were
declared in the global namespace, and "const" now causes hard errors.

Bug: T339323
Change-Id: I69e9d7a29591137f185f3e5ab02dea590ec4dff6
2023-06-23 08:01:31 +02:00
jenkins-bot 9219f80a65 Merge "Dramatically simplify a forEach loop" 2023-06-15 15:57:47 +00:00
thiemowmde fdc1b1212a Dramatically simplify a forEach loop
I'm not sure why it was done like this. It looks like we can skip
both the extra conditional as well as the extra function scope.

Change-Id: I9aebd17bece0b9a573fc1f9697e79b759741751e
2023-06-15 12:16:59 +02:00
thiemowmde 3ca3013522 Add overflow-x: clip to minimize impact of resize issues
This is certainly not an actual fix for anything. But it makes any
resize issue look much less broken and much more bearable. I think it
is helpful to have this extra safety in place even after we properly
fixed the issue.

Bug: T336729
Change-Id: I724ede9cda120f18c4b7ee3ebf7bb41c0541819e
2023-06-15 12:15:56 +02:00
Volker E 7f6f5d7824 build: Update SVGO to v3.0.2
svgo         2.8.0  →   3.0.2

Amending to new `cleanupIds` plugin name.

Bug: T339162
Change-Id: I1eedb094b0afce2167c1de7296c81c30813838e0
2023-06-14 12:38:31 -07:00
Translation updater bot c53e613656 Localisation updates from https://translatewiki.net.
Change-Id: I25a30b7cc9ba8b0125c17531de9a066c6add61ef
2023-06-14 13:07:52 +02:00
thiemowmde bbf3b67bad Use "0" instead of "false" for default user options
This is best-practice, as far as I can see. It doesn't make a
difference in terms of what is stored in the database. false,
the number 0 and the string "0" will all be stored as "0" in the
database. More precisely: These values will not be stored because
they are all considered equal to the default value by
UserOptionsManager::isValueEqual().

It makes a difference in terms of what is send to the browser. The
keyword "false" is 5 bytes while "0" is only one.

Bug: T300371
Change-Id: Ia9eb03ebdc2155df1785fa5d40bceaab56268bf9
2023-06-12 10:01:46 +02:00
Translation updater bot 2d4dde3e67 Localisation updates from https://translatewiki.net.
Change-Id: Ibbcc7cd4e075cea3e2faab734059e3c3beb7c91d
2023-06-09 09:14:45 +02:00
jenkins-bot 7f430a4d1f Merge "Don't set preferences for temporary accounts" 2023-06-05 06:21:59 +00:00
libraryupgrader aacd7dba34 build: Updating npm dependencies
* grunt-banana-checker: 0.10.0 → 0.11.0
* stylelint-config-wikimedia: 0.14.0 → 0.15.0

Change-Id: I4ddab3580ba726a373f36cc96cd2ced448e96f39
2023-06-02 01:47:11 +00:00
thiemowmde 4e5faf6e95 Don't set preferences for temporary accounts
Not extensively tested. Just fixing the most obvious places.

Bug: T335971
Change-Id: I31c4c2be6ae6b8122b446ee3b49411108f3e39d3
2023-06-01 15:44:38 +00:00
WMDE-Fisch 7b385ee3ef Skip user setting for unnamed users
Bug: T326908
Change-Id: I6421ad020db98d258c45d1f50d211d38b5c6f3a9
2023-05-24 06:13:56 +00:00
WMDE-Fisch 8fe657e90e Fix test for scrolling over revisions
Due to some change in the test setup, possibly related to the new
Vector skin, the slider now has more space and the need to scroll
triggers at a later point.

Change-Id: I5411d5a31714761434135e65d916f57f1e437003
2023-05-22 13:13:06 +03:00
Translation updater bot dc132af392 Localisation updates from https://translatewiki.net.
Change-Id: I5f337bc9c432e0303771e61c23d2081b438eb606
2023-05-22 08:46:34 +02:00
libraryupgrader 50fe9c445b build: Updating eslint-config-wikimedia to 0.25.0
Change-Id: Ib27405f6bab96e7edefae53e8e48dc6bd470443d
2023-05-05 10:49:05 +00:00
libraryupgrader 9dd40a599c build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.12.0 → 0.12.1

npm:
* grunt-eslint: 24.0.0 → 24.0.1

Change-Id: Ib973eda921fe671098e9ed4e98094d8b5da7091b
2023-04-29 09:51:30 +00:00
Raimond Spekking 319804d979 Merge "Localisation updates from https://translatewiki.net." 2023-04-24 07:47:28 +00:00
Translation updater bot c326fa9abd Localisation updates from https://translatewiki.net.
Change-Id: Ib26271a4faaad849f91d1709ef77e9f63f67af6c
2023-04-24 09:17:09 +02:00
Fomafix 6c0d10ddbe Use .empty().append( $jQueryObject ) instead of .html( $jQueryObject )
According to https://api.jquery.com/html/ a jQuery object is not
supported in .html() although is works.

The .empty() is needed to avoid multiple sliders on resize.

Change-Id: I0ce4748e95529dbe27f82d6fd0aa2433bfda4375
2023-04-22 19:16:31 +00:00
jenkins-bot 2781a23fe6 Merge "Make use of named MainConfigNames::… constants" 2023-04-21 15:40:49 +00:00
thiemowmde 59af8caa8f Make use of named MainConfigNames::… constants
Change-Id: Idbed910d3ab8e06bf0b0a0b4aea9a8954102f02c
2023-04-21 10:01:41 +00:00
Fomafix 65d1dfefbf Use document.body instead of 'body' as jQuery selector
Change-Id: I2e74d31b61f5f46d1bbb1a0283a7468af9c4e856
2023-04-21 08:52:25 +00:00
jenkins-bot e5950e7b41 Merge "Use mw.msg( ... ) instead of mw.message( ... ).text()" 2023-04-21 08:43:21 +00:00
Translation updater bot fd09f34958 Localisation updates from https://translatewiki.net.
Change-Id: I5607c9f2ad437126de860e245d5c64132fbc4e43
2023-04-21 09:00:41 +02:00
Fomafix c86df62861 Use mw.msg( ... ) instead of mw.message( ... ).text()
Change-Id: If954018fdfa5a3609bf48e92de9013b05c485f93
2023-04-21 06:36:08 +00:00
Sam Wilson e70d7b7ed6 Update to use the new HookContainer/HookRunner system
Implement hook handlers and inject services.

Bug: T335085
Change-Id: Ibe68029561098d90a0ee0b9fa70b1c4866996426
2023-04-20 11:28:28 +08:00
Translation updater bot 4b845be9ea Localisation updates from https://translatewiki.net.
Change-Id: If7eb6dfad3d742223cfde7ac57c24cb2ffd30508
2023-04-17 09:15:27 +02:00
Raimond Spekking 94adfc80c6 Merge "Localisation updates from https://translatewiki.net." 2023-04-10 12:45:55 +00:00
Translation updater bot 1ce8078ea3 Localisation updates from https://translatewiki.net.
Change-Id: I2ab0102b02b10354f30c110a5de3f673bf884202
2023-04-10 09:46:35 +02:00
Translation updater bot 8e73d04721 Localisation updates from https://translatewiki.net.
Change-Id: I03a73583fa1e6b0e9188f722baa251b835e13a99
2023-04-10 09:22:55 +02:00
jenkins-bot 438bd35dc0 Merge "selenium: Refactor WebdriverIO tests from sync to async mode" 2023-04-03 07:50:07 +00:00
Translation updater bot a15c6ed84f Localisation updates from https://translatewiki.net.
Change-Id: I0d39dff2024840e8fa7b25a15f2441c26bef4ef0
2023-04-03 09:19:00 +02:00
Vaughn Walters 8a53d056be selenium: Refactor WebdriverIO tests from sync to async mode
WebdriverIO has dropped support of sync mode, hence changed to async.

Update npm packages: @wdio/*, wdio-mediawiki
because async mode needs at least @wdio v7.9.

Remove npm packages: @wdio/dot-reporter and @wdio/sync.

Bug: T300798
Change-Id: I053ea6b5fbfdcff279f4eb10cf2429155690bd72
2023-03-31 14:10:46 -05:00
Umherirrender e00aa9f599 stylelint: Enable selector-pseudo-element-colon-notation
Via stylelint --fix

Change-Id: Ic1625ae755233e172cc6db734dc21ed2c5b377d8
2023-03-30 00:42:20 +02:00
libraryupgrader 88f6eccd11 build: Updating npm dependencies
* eslint-config-wikimedia: 0.22.1 → 0.24.0
* grunt: 1.5.3 → 1.6.1
* stylelint-config-wikimedia: 0.13.0 → 0.14.0
  The following rules are failing and were disabled:
  * selector-pseudo-element-colon-notation

Change-Id: Ic78a5aa7fca2d917054eb26b5c8d46c008870484
2023-03-22 21:18:23 +00:00
Umherirrender e62fbf5581 build: Remove unneeded inline stylelint-disable-next-line
The error is suppressed in the .stylelintrc.json file and
does not need inline suppression

Change-Id: I476534fdcd521a2884a6be3b7c8ac5c9d1826ef1
2023-03-21 22:53:26 +01:00
libraryupgrader 1cc4c488d7 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 39.0.0 → 41.0.0

npm:
* http-cache-semantics: 4.1.0 → 4.1.1
  * https://github.com/advisories/GHSA-rc47-6667-2j5j
* qs: 6.5.2 → 6.5.3
  * https://github.com/advisories/GHSA-hrpp-h998-j3pp
* ua-parser-js: 0.7.28 → 0.7.34
  * https://github.com/advisories/GHSA-fhg7-m89q-25r3

Change-Id: I80707cef042fe2b57e18d3cbe3c94ee5ef75b62b
2023-03-12 09:18:16 +00:00
Translation updater bot 1d019d477c Localisation updates from https://translatewiki.net.
Change-Id: I31347b0cb8b9d150eb904e0eab0c42a5fd61adab
2023-02-28 08:29:34 +01:00
Translation updater bot d0413a0cc9 Localisation updates from https://translatewiki.net.
Change-Id: I88abf74205cd3650e2e027306ac7a3e7a1c08059
2023-02-27 08:28:07 +01:00
Translation updater bot 82ee5b5101 Localisation updates from https://translatewiki.net.
Change-Id: Ied590896ddd16f2f077bfba01d0d24d6b1088b0b
2023-02-21 08:21:44 +01:00
Translation updater bot d82b36223f Localisation updates from https://translatewiki.net.
Change-Id: Idea7e6d3af4ba3f14df57936dd256014db3a0625
2023-02-13 08:31:00 +01:00
Translation updater bot 482315997f Localisation updates from https://translatewiki.net.
Change-Id: I9b22522185b639222b2028895ecc243121961f35
2023-02-06 08:46:06 +01:00
Translation updater bot 181c1b5b83 Localisation updates from https://translatewiki.net.
Change-Id: Idcb8f9029612ed81e091eecd30f6f383bad0f6de
2023-02-03 08:48:21 +01:00
Vaughn Walters 8461d956d4 selenium: Remove webdriverio npm package from the Revision Slider extension
The `webdriverio` package does not need to be an explicit dependency.
It is a dependency of `@wdio/cli`.

Bug: T325059
Change-Id: Id772e7e1438fb7ac7ff3c5e90dcff5a94783d13d
2023-01-13 11:09:50 -06:00
Translation updater bot eb18914fb4 Localisation updates from https://translatewiki.net.
Change-Id: Ib939b3e0016d51d81818cd9c4d32c4c8812748ea
2023-01-09 09:28:47 +01:00
Translation updater bot d9d0800705 Localisation updates from https://translatewiki.net.
Change-Id: Ida29b9bf61c7e6d6d8f08ac58cef38b38430d9f4
2023-01-02 08:44:15 +01:00
Translation updater bot d1be664aa6 Localisation updates from https://translatewiki.net.
Change-Id: Id88c7e945f0e25ff003cb40ce9507d973ca5f5f6
2022-12-23 09:07:57 +01:00
Translation updater bot 32f650fbf9 Localisation updates from https://translatewiki.net.
Change-Id: I2ee7829786c693ab42ade79b44787f094ddcd9b4
2022-12-21 09:17:43 +01:00