Commit graph

1572 commits

Author SHA1 Message Date
WMDE-Fisch cf5d602a53 Update eslint and fix issues
Change-Id: I0e3ad763398430608c30bb22741a57c81b2b7062
2017-07-14 12:28:45 +02:00
WMDE-Fisch ab874bdd57 Improve doc, naming and pointer updates
Several improvments including documentation, naming and refactoring:
- bundeling of methods setting, redrawing and loading new diffs
- renamed and improved documentation around some methods in that area
- fixed some leftovers from past refactoring not using new methods

Change-Id: Idf1afcd6ce9210951d28655128a47150f6b7a2aa
2017-07-14 10:19:33 +00:00
WMDE-Fisch 553e48e65a Move scrollType detection to utils
Change-Id: I465e0b74a7d7a6682b22bdd6e7aafb794bce9b24
2017-07-14 10:19:28 +00:00
WMDE-Fisch ada6498b81 Move data pos attr to PointerView
Change-Id: I46c3dceaddae84b279625caec3349aa10d931048
2017-07-14 12:18:51 +02:00
WMDE-Fisch 60f29e11cc Let pointers block each other at the ends of the slider
Bug: T168265
Change-Id: I072e0ddd5f6ab19f5676a0910ffa2e10c258a4a1
2017-07-11 12:37:01 +02:00
WMDE-Fisch 4a9ee131d3 Refactor pointer class names
Pointers can always be identified as the pointer for the "older" and
"newer" revisions. Class nameing was cleaned up and changed accordingly.

Change-Id: Id17878e780b5a405b196fdc5ec7429eeaef5bd4c
2017-07-11 10:17:24 +02:00
WMDE-Fisch 90d90a2f3c Refactor pointer position access
Pointers do not change roles anymore. Older and Newer pointer will
always stay the same. Removed and refactored some logic in that
regard.

Change-Id: I60cf58fb9d0728a9644ed29cac335ebbe7f3de11
2017-07-11 00:42:36 +02:00
WMDE-Fisch 94f9daef82 Minor optimisation and clean up
- reused jquery element
- removed unused method
- fixed doc type
- merged some css

Change-Id: Iadd9d7cb464691b39b7c251b401f687b3d5008b3
2017-07-10 22:41:43 +00:00
Translation updater bot 1ff3058e82 Localisation updates from https://translatewiki.net.
Change-Id: I148e8be0280b2afa246a3cded245192e1cf961ee
2017-07-06 22:57:38 +02:00
jenkins-bot 449dfdb051 Merge "Do not hook RevisonSlider into MobileDiff page" 2017-07-06 14:31:44 +00:00
jenkins-bot ac5e6de6f4 Merge "Add jQuery reference to modules using it" 2017-07-06 14:31:29 +00:00
Translation updater bot eb2e91913f Localisation updates from https://translatewiki.net.
Change-Id: I1ab54674c832184453a3e2273b5cb6d3acc02398
2017-07-05 22:39:55 +02:00
WMDE-Fisch edfd885543 Remove last SliderViewTwo parts
Bug: T165747
Change-Id: I9ac410613361e567bd825f096eb12bbb3edc5cde
2017-07-05 10:22:33 +02:00
WMDE-Fisch d299926ff9 Merge/Remove revisionWrapperClickHandler code
Change-Id: I1060f94d81dcfcf4457cea27e71a5d92c22a2186
2017-07-04 12:16:57 +00:00
WMDE-Fisch 05925e3ab0 Merge remaining pointer methods
Change-Id: I89562e445481b9785cf18e02ea02040105632af7
2017-07-04 12:16:49 +00:00
WMDE-Fisch c6f24f2100 Merge container and pointer building and dependencies
Change-Id: I52ac8b42e39b3a37c0bac6b7fff5a676d7c2ecfe
2017-07-04 14:02:58 +02:00
WMDE-Fisch fc5c13f359 Merge draggableDragAction and dependencies
Also temporarily deactivate browser tests for bar clicking.

Change-Id: I347533ef445cb3c37e420beebcc79919e56a1223
2017-07-04 10:56:40 +00:00
WMDE-Fisch 11caf4c828 Do not hook RevisonSlider into MobileDiff page
The RevisionSlider is not ready for the MobileDiff right now, so
do not include him on the MobileDiff page, even when the hook is
called.

Bug: T169535
Change-Id: I190a8681adad4e8605ae5c8bd69399459f364238
2017-07-03 16:56:43 +02:00
Kunal Mehta 37267aba11 build: Updating mediawiki/mediawiki-codesniffer to 0.10.0
Change-Id: I1e2b92697a8ab82c5c196dfb499917163de58c3e
2017-07-01 01:41:54 -07:00
WMDE-Fisch 890737a621 Simplyfied lint file selection
Change-Id: I25f624db06d4c7f2cd4260c37cc7c1d11162b795
2017-06-29 15:35:49 +02:00
WMDE-Fisch 64bf845aef Add jQuery reference to modules using it
Change-Id: Icf5ff3459978b7c7a5fa8e24b42981e789bcc492
2017-06-29 10:14:27 +02:00
Mukunda Modell 8bea89dbdd Set onDiffViewHeader argument defaults = null
See also I1221357746f5d4ba1430bcf0bfe773202484eebc

Change-Id: I0b96a9557ed1fc0e9a74e14bc25753ecddd97d1d
2017-06-29 00:07:37 -05:00
Translation updater bot ca9a2134b2 Localisation updates from https://translatewiki.net.
Change-Id: I77da992371f61752734e76d6cd1cdb96e029fcdc
2017-06-28 23:06:24 +02:00
jenkins-bot ef2604f00f Merge "Improve support for screenreaders" 2017-06-27 11:23:27 +00:00
WMDE-Fisch 557ab23aa9 Fixes to address MW PHPCS 0.9
Change-Id: Ia911d9aa0516d6619bd62f104a527b1dc1b62228
2017-06-26 11:58:50 +00:00
Translation updater bot f4baf5e6dc Localisation updates from https://translatewiki.net.
Change-Id: I7be7978e3db2c99dbb442fdea60716ccd6bfbc8d
2017-06-25 23:13:42 +02:00
Translation updater bot fccb50badd Localisation updates from https://translatewiki.net.
Change-Id: I791e28f231beefaccb1f42b942d663cc7286c8c3
2017-06-24 22:52:12 +02:00
Translation updater bot 72aa8fff95 Localisation updates from https://translatewiki.net.
Change-Id: I9ff1e6dc46dfd5613ed2fc79cf0b0fa6f3439a9f
2017-06-23 22:47:46 +02:00
Andrew-WMDE 80ab1408ac Remove BetaFeature Code
Bug: T167276
Change-Id: Iad2e34e2f906777c7ba0e22e245dc55891f211ae
2017-06-23 14:45:48 +02:00
jenkins-bot f5e74e2179 Merge "Use tabs to indent xml" 2017-06-22 21:15:26 +00:00
Translation updater bot 53bced8353 Localisation updates from https://translatewiki.net.
Change-Id: I9bd125b2e071efc6c710515bff03f7b2ef1a3fc6
2017-06-22 23:02:52 +02:00
Umherirrender 15369ee73b Use tabs to indent xml
Also exclude node_modules from build process, use correct notation for
utf-8

Change-Id: I6808eaf1bc2a2f551ae29552a37750bd533620e7
2017-06-22 22:52:07 +02:00
WMDE-Fisch c78cf805cd Add fallback background color for linear gradient
Change-Id: I61ff34e29f12fdbb46c30c08428ad5e9bfe1517f
2017-06-22 13:54:10 +02:00
Translation updater bot 7e219bc173 Localisation updates from https://translatewiki.net.
Change-Id: Id1acd40e25cf6a17963d60c78eb382ccdd18c724
2017-06-21 22:54:49 +02:00
WMDE-Fisch 6ffe96bc4c Fix errors leading to wrong slider scroll postions
The detection touched in this patch addresses slightly different
kinds of RTL handling in browsers. The detection how things are
handled seems to be broken in the mentioned Chrome V8 versions.

The workaround takes care of that issue. With Chrome V8 6.0 this
should be fixed and the workaround can be removed.

P.S.: Credits to Leszek for the idea what's actually going on.

Bug: T168299
Change-Id: I068c2fb6ba60189004c0ec6661fcd346af16126c
2017-06-21 15:21:08 +02:00
jenkins-bot 61db89cc39 Merge "Merge SliderViewTwo CSS into main CSS" 2017-06-21 12:13:14 +00:00
WMDE-Fisch 12e34322bc Merge SliderViewTwo CSS into main CSS
Bug: T165747
Change-Id: I1949591063bb8d2df7ddf3bc0c33247ece1bd522
2017-06-21 10:13:32 +02:00
Translation updater bot 73701c0911 Localisation updates from https://translatewiki.net.
Change-Id: I74cadcd75814cc82f3b3a997964c794da0e5e420
2017-06-20 22:59:11 +02:00
Kunal Mehta 9895763673 build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
The following sniffs are failing and were disabled:
* MediaWiki.FunctionComment.Missing.Public

Change-Id: I46aa05cd51d5195b5ebf00e45d83d0d3e7bbc5f4
2017-06-20 09:07:47 +00:00
Translation updater bot 0552cad37f Localisation updates from https://translatewiki.net.
Change-Id: Ib9c1356ff055b07ed58a8e207f84111d0fdd3c64
2017-06-19 23:04:06 +02:00
Translation updater bot 6219d26207 Localisation updates from https://translatewiki.net.
Change-Id: I6016953dbe9b149fde99c239fb24792d9ae57d14
2017-06-18 22:48:15 +02:00
Translation updater bot 53f72a98c1 Localisation updates from https://translatewiki.net.
Change-Id: I46c3e016ce17c684c2cec19bef968f9b2e611d50
2017-06-17 22:41:37 +02:00
Translation updater bot c448d0880a Localisation updates from https://translatewiki.net.
Change-Id: Ia242ae303213e51094e584455d976486d68f964b
2017-06-16 22:52:59 +02:00
Translation updater bot 6d77444957 Localisation updates from https://translatewiki.net.
Change-Id: I665a19d9a51c646678096ed7f55893933ddcd6c8
2017-06-15 23:14:34 +02:00
Translation updater bot 929530da53 Localisation updates from https://translatewiki.net.
Change-Id: Icd27fdd5b461f716fb357835942711ba08ba858d
2017-06-13 22:43:22 +02:00
Translation updater bot 7af1f28891 Localisation updates from https://translatewiki.net.
Change-Id: Iccedf081c1904a00f79aede75a323a0a50f53019
2017-06-12 22:45:27 +02:00
WMDE-Fisch 5f8bf83849 Improve support for screenreaders
This patch improves screenreader support by applying some basic
rules and improving the OOjs UI usage. Things done here:

- make use of 'aria-label' attribute to label interactive buttons
- use connect method on help button to allow keyboard interaction
- give hint on help button that it opens a dialog
- communicate state of autoexpand button
- add attributes to make screenreaders understand the accordion
mechanism if the slider widget

See:
https://www.w3.org/TR/wai-aria-practices/#button
https://www.w3.org/TR/wai-aria-practices/#accordion

Bug: T165489
Change-Id: I7a174e5971a751ec54d4d5115d5441f0a577c103
2017-06-12 09:14:22 +00:00
Translation updater bot 40bb26c238 Localisation updates from https://translatewiki.net.
Change-Id: I0ed04cd940e9fd4811b67594db3330c3022fcff0
2017-06-11 22:39:02 +02:00
Translation updater bot 0ab3a9cfa4 Localisation updates from https://translatewiki.net.
Change-Id: I3abc72b56770d4b43851b9c4aa4cdf46f0d9de65
2017-06-11 00:29:40 +02:00
Translation updater bot 1ccdc5f2d2 Localisation updates from https://translatewiki.net.
Change-Id: I9176fff792719eec451068251253b3388d1407b0
2017-06-09 22:56:05 +02:00