Commit graph

163 commits

Author SHA1 Message Date
Baha a3d9b22a66 Fix loading related articles on small screens
Related articles are loaded when the user scrolls past
half the document height, which used to be calculated on
page load. This height, however, changes after all sections
are collapsed on small screens, thus never loading the
related articles for the page. Calculating the document height
just before showing related articles allows us to correctly
decide whether it's time to load the needed modules.

Bug: T121263
Change-Id: I1266894ab763cfb571b14f067086445fb6be1887
2015-12-14 15:34:17 +05:00
jdlrobson ed338bbed5 Disable RelatedArticles when editor enabled
We only want to show it in view mode.
When a reader hits edit, wgAction is view so we add a CSS rule to
hide the widget when that transition occurs.

This means related widget does not show up post edit (you'll need to
refresh but this seems like an acceptable workaround until we can
understand this issue some more)

Bug: T120443
Bug: T120735
Change-Id: If1356906d5f55167c9d1abbed88f433f36b7f390
2015-12-09 16:47:52 -08:00
jenkins-bot 4af4c384dc Merge "RelatedArticles load after half window scroll" into dev 2015-12-08 23:27:24 +00:00
Sumit Asthana 9623c1cc42 RelatedArticles load after half window scroll
Only triggers RelatedArticles module load and query after user has scrolled
through half the document height.

Bug: T116838
Change-Id: If290988fb7cc187cad37dd4a8a2c4f38abed9bb9
2015-12-08 20:51:16 +05:30
Paladox 8a73239abf Update packages
Update grunt-jscs to 2.4.0

Update grunt-jsonlint to 1.0.6

Change-Id: I34b1f23469a35e64345ee42a183dd74679e50b81
2015-12-07 21:00:56 +00:00
jenkins-bot 011566984b Merge "Add browser tests for ReadMore" into dev 2015-12-07 20:28:30 +00:00
Baha d843523fcf Breaking: Release version 2.0.0
Bug: T119749
Change-Id: I5e159bbe116771b4efef96baa2e85b2dcf783a6f
2015-12-07 21:00:19 +05:00
Translation updater bot 7442b601ef Merge "Localisation updates from https://translatewiki.net." into dev 2015-12-05 22:18:00 +00:00
Translation updater bot b8a7f34c03 Localisation updates from https://translatewiki.net.
Change-Id: I936bb66294ad8d9e7c02833c92852e7afd871029
2015-12-05 23:13:22 +01:00
Baha 9932fee563 Add browser tests for ReadMore
Change-Id: Ia1f628b4f2e1af7d33dc6779a139c2800be82964
2015-12-04 15:43:45 +05:00
Translation updater bot bff09a4180 Merge "Localisation updates from https://translatewiki.net." into dev 2015-12-03 22:18:48 +00:00
Translation updater bot c5c612864e Localisation updates from https://translatewiki.net.
Change-Id: I5c86672c9215997601cc350810d7777c592d463f
2015-12-03 23:16:32 +01:00
jenkins-bot 21db191b34 Merge "Configure footer and sidebar placements" into dev 2015-12-02 22:42:52 +00:00
jenkins-bot 1ffd313910 Merge "[Hygiene] Reorganise hooks to reflect placements" into dev 2015-12-02 22:42:50 +00:00
Translation updater bot 7e1f5a1e98 Merge "Localisation updates from https://translatewiki.net." into dev 2015-12-02 21:02:06 +00:00
Translation updater bot 8ff5d88576 Localisation updates from https://translatewiki.net.
Change-Id: Ib264fc7c18ec31d9adad711c3790ec3f9ba9a8db
2015-12-02 21:58:53 +01:00
Sam Smith 040314c504 Configure footer and sidebar placements
Changes:
* Rename $wgRelatedArticlesShowReadMore to $wgRelatedArticlesShowInFooter
* Add $wgRelatedArticlesShowInSidebar, which is truthy by default, and
  short circuit the SkinBuildSidebar and SkinTemplateToolboxEnd hook
  handlers if it is falsy

Bug: T119926
Change-Id: Idf04bf3221ba44d7b898160764fbd6ba83561abb
2015-12-02 11:17:54 +00:00
Sam Smith 9157e303d2 [Hygiene] Reorganise hooks to reflect placements
There are two positions where the list of related articles is rendered:
the sidebar, and the the footer. Move the hook handlers related to
rendering the former to RelatedArticles\SidebarHooks and those related
to rendering the latter to RelatedArticles\FooterHooks.

Change-Id: Idde57905d828e63309bfdc360a3a09e64e291304
2015-12-02 11:10:04 +00:00
jenkins-bot 9794dd499b Merge "Correctly show related articles on desktop" into dev 2015-12-02 02:08:08 +00:00
Baha 18990e6631 Correctly show related articles on desktop
When $wgRelatedArticlesShowReadMore was false, while deciding
whether to show related articles on the sidebar,
we used to incorrectly consider whether BetaFeatures was
enabled for the user. BetaFeatures should only be used
for enabling ReadMore and not for showing related articles
on the sidebar.

We also used to show the beta features option for ReadMore
even when the ReadMore feature was disabled. Now we only
show that option if ReadMore is enabled.

Also rename isAbleToShowRelatedPages to isInSidebar to make
the function less confusing.

Bug: T119926
Change-Id: Ia5e44d94bb20660af711772cab7e3a59f98c931f
2015-12-02 06:08:19 +05:00
Translation updater bot d8ccc34997 Merge "Localisation updates from https://translatewiki.net." into dev 2015-12-01 20:38:03 +00:00
Translation updater bot 0c476af23a Localisation updates from https://translatewiki.net.
Change-Id: Ic935d02165a01d2137492f93871946a5a86c209d
2015-12-01 21:35:55 +01:00
jenkins-bot 2cfe468387 Merge "Fix RelatedPagesGateway unit test failures" into dev 2015-12-01 18:43:31 +00:00
Translation updater bot c43bef2096 Merge "Localisation updates from https://translatewiki.net." into dev 2015-11-30 20:38:49 +00:00
Translation updater bot 26651286e4 Localisation updates from https://translatewiki.net.
Change-Id: Ib1a6952da8f1f9d64b5571743323f15d1fcde504
2015-11-30 21:36:10 +01:00
Translation updater bot 4094f0c364 Merge "Localisation updates from https://translatewiki.net." into dev 2015-11-28 20:51:33 +00:00
Translation updater bot 72516ec68b Localisation updates from https://translatewiki.net.
Change-Id: I06663f0696fc7db15cc04f0e1cf2783b9d20ff1b
2015-11-28 21:47:36 +01:00
Translation updater bot f8938ad89e Merge "Localisation updates from https://translatewiki.net." into dev 2015-11-27 21:49:55 +00:00
Translation updater bot 14f2c69da2 Localisation updates from https://translatewiki.net.
Change-Id: I9bec6fb991688e42ea8f4bbebe740db4a2d697b2
2015-11-27 22:47:23 +01:00
Baha 3e943d79a1 Release version 1.2.0
Bug: T119749
Change-Id: I0038b4400ddc507639a22df7cb85e699cad4a877
2015-11-27 08:32:06 +05:00
Translation updater bot b0126156a5 Merge "Localisation updates from https://translatewiki.net." into dev 2015-11-26 21:07:45 +00:00
Translation updater bot fd3cfb10cf Localisation updates from https://translatewiki.net.
Change-Id: Id3a2a90e518661d113306869d597f82b4a6e3b21
2015-11-26 22:03:26 +01:00
jenkins-bot f61ee0ef6c Merge "Make RelatedArticles available as a beta feature" into dev 2015-11-25 20:14:12 +00:00
Baha 95ea0b0ef7 Make RelatedArticles available as a beta feature
Hide the related articles from the sidebar if ReadMore is enabled.
Otherwise leave as is because it's used in WikiVoyage.

Bug: T117444
Change-Id: I3879ae1e53de301b0d3f5f2c066f8e8de7c1c223
2015-11-25 20:43:51 +05:00
Sam Smith fbc696177a Fix RelatedPagesGateway unit test failures
I33936a3 didn't introduce a regression but highlighted an issue with the
fixture in the RelatedPagesGateway unit test: the fixture is in the
legacy JSON format despite the API request URL including
formatversion=2.

Change-Id: Id372d022625d88eea685267ea6b6484cf6b28cbc
2015-11-25 14:34:11 +00:00
Translation updater bot c327ff1859 Merge "Localisation updates from https://translatewiki.net." into dev 2015-11-24 22:13:52 +00:00
Translation updater bot e647e27dfe Localisation updates from https://translatewiki.net.
Change-Id: Ibb80cf3de5edee487fe2472fdb426096b796f014
2015-11-24 23:10:42 +01:00
Translation updater bot 14418d8fcb Merge "Localisation updates from https://translatewiki.net." into dev 2015-11-23 21:37:45 +00:00
Translation updater bot 78f46741dc Localisation updates from https://translatewiki.net.
Change-Id: Ibcc3b0d7aa86cc59c28e3b9998cf5caf204db4cd
2015-11-23 22:34:46 +01:00
Baha 5522727f51 Add simple README
Bug: T118855
Change-Id: I0cf8bd2215996a514c14e32b6bb8797f898ff6e0
2015-11-23 23:10:02 +05:00
Translation updater bot a4516f2039 Merge "Localisation updates from https://translatewiki.net." into dev 2015-11-22 19:49:50 +00:00
Translation updater bot 942922b80b Localisation updates from https://translatewiki.net.
Change-Id: I2bbb8666d13e242041a4af0d2db288d925175d43
2015-11-22 20:46:05 +01:00
Translation updater bot ba69f625ab Merge "Localisation updates from https://translatewiki.net." into dev 2015-11-20 22:01:30 +00:00
Translation updater bot 8ddf27486d Localisation updates from https://translatewiki.net.
Change-Id: I2a6253e0ff04d69b93516af2e3ba8f1cb1cf7de2
2015-11-20 22:57:35 +01:00
Translation updater bot 388f36aef3 Merge "Localisation updates from https://translatewiki.net." into dev 2015-11-19 20:43:11 +00:00
Translation updater bot 614c319b99 Localisation updates from https://translatewiki.net.
Change-Id: I47ff0a8aa50be16b0630e0289329d214ace40b7d
2015-11-19 21:39:50 +01:00
jenkins-bot fcdff4b4fe Merge "Make RelatedArticles soft-depend on Cards" into dev 2015-11-19 13:48:30 +00:00
Translation updater bot 3ac8ccaf97 Merge "Localisation updates from https://translatewiki.net." into dev 2015-11-18 21:02:18 +00:00
Translation updater bot 3b75c89652 Localisation updates from https://translatewiki.net.
Change-Id: Icf963340913d2e2bf1d60cba68b6fe30f52bf3b1
2015-11-18 21:59:37 +01:00
Baha 8cf9b60ab5 Make RelatedArticles soft-depend on Cards
RelatedArticles tries to load the 'ext.cards' module and if
it succeeds it continues with showing the related articles
on the page.

Dependency: I6661527175eb889cec4193b18fa18207f332b4fc
Bug: T117108
Change-Id: I33936a3e9cd5d1f0296e48fd1c2bba77fff4e466
2015-11-18 22:22:10 +05:00