Commit graph

374 commits

Author SHA1 Message Date
Volker E 6add5a1eac Align 'noimage' to WikimediaUI color palette
Aligning 'noimage' to overhauled color palette, background-color
equaling footer color and icon color going to closest,
minimally higher contrast color `#72777d`.

Bug: T172850
Change-Id: I949db4983910ef6609124adbfcd3c0d31a7f7eb4
2017-08-25 06:12:14 -07:00
Translation updater bot e096350f1f Localisation updates from https://translatewiki.net.
Change-Id: I27c8193f1ee4cefab560263a44d080f3c1a43679
2017-08-25 09:51:41 +02:00
Umherirrender c9dd743732 Remove dot at end from extension description
Consistency tweak for extension active on translatewiki.net
Description on Special:Version does not end with a dot

Change-Id: I84ed451ae081017289a6ccb839c637e673ceafa6
2017-08-24 20:53:40 +02:00
Željko Filipin 9d2a46fbda For Selenium tests, click the link to switch to mobile view
Clicking `Mobile view` link works on both MediaWiki-Vagrant and beta cluster. Appending `&mobileaction=toggle_view_mobile` to URL works only on  MediaWiki-Vagrant.

Bug: T171847
Change-Id: Iff47a5e3b25ee3af15a4843ca7efe550c334c3b7
2017-08-22 13:22:26 +02:00
jenkins-bot 704099acbf Merge "Use json extension for .stylelintrc" 2017-08-19 21:43:27 +00:00
Umherirrender 569e207855 Use json extension for .stylelintrc
Bug: T173516
Change-Id: Idadde6e4d4c1a16d54ecdeaa1cde20930420722c
2017-08-19 10:26:03 +02:00
Translation updater bot 86b38a01dc Localisation updates from https://translatewiki.net.
Change-Id: Iddf3fd1706578afd82380b30b2ccc0f9e3d94e39
2017-08-19 09:15:00 +02:00
Translation updater bot ae867a1d2e Localisation updates from https://translatewiki.net.
Change-Id: Ic3f0fcdd13af691d68b3f5770a7c35f2070a2f74
2017-08-17 09:07:28 +02:00
jdlrobson daa7281381 QA: Move LocalSettings to folder with other browser tests
Depends-On: Ib069004f8dcb76550fe96a6544f2846d4a7af1b9
Bug: T164024
Change-Id: Iaae9709b7407738850cdfc47c7ff56cc6eb2b1ca
2017-08-14 15:33:36 +02:00
Translation updater bot 5f4aa8d5c4 Localisation updates from https://translatewiki.net.
Change-Id: Icd4af588dc75b7637e4f68c43cf5fba3a4e93091
2017-08-14 09:30:06 +02:00
jenkins-bot 9410145179 Merge "Merge footer hooks with Hooks" 2017-08-11 13:21:18 +00:00
Kunal Mehta c5dcdea9dc build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
Change-Id: I431c63629769d7cb941288cc67aa77fe9b78001c
2017-08-11 00:25:34 -04:00
jdlrobson ab788e7f41 Merge footer hooks with Hooks
per Baha's suggestion we have no need for two Hooks files now
so let's merge them

Bug: T165991
Change-Id: I12c62aef837f50589297477f46bdf0f0d6b5536a
2017-08-10 15:10:30 -05:00
jenkins-bot 70787d2d70 Merge "Breaking change: Remove Sidebar code from RelatedArticles" 2017-08-10 18:26:08 +00:00
jdlrobson 94ecc2d917 Breaking change: Remove Sidebar code from RelatedArticles
RelatedArticles will now only render related articles in the footer of
skins.

Bump version to 3.0.0

Bug: T165991
Change-Id: Ia4e28c0ed76b3aff37c0aea8eb713923312ba23c
2017-08-10 12:44:58 -05:00
Volker E 581a247d70 Replace abandoned colors with current WikimediaUI ones
Replacing abandoned `@colorGray8` (`#888`) & `@colorGray9` (`#999`)
with slightly increased contrast, WCAG 2.0 level AA conformant,
`@colorGray7` from WikimediaUI color palette.

Bug: T172850
Change-Id: I750261b83cc79c32e9ccdb2d69bb5e396b20ed35
2017-08-09 17:49:35 -04:00
jdlrobson b7f7d9c351 Having 2 folders for browser tests is confusing.
This patch removes all unnecessary artifacts from the old Ruby tests.
LocalSettings is needed for CI purposes and can be removed once CI
has updated.

Bug: T164024
Change-Id: Ifec8bf2b3cd7d4db105c254248cdfcdf773472ef
2017-08-02 07:42:08 -07:00
Umherirrender 9a83d49ea0 Fix typo in word parser
Change-Id: I01f950621fda1388e1f8fcc79f217d1f639ac357
2017-07-28 17:44:09 +02:00
jenkins-bot 1da8158426 Merge "build: Updating mediawiki/mediawiki-codesniffer to 0.10.1" 2017-07-26 22:10:23 +00:00
Umherirrender 548392824d build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
Change-Id: Ie05b9ddc3e351abf4b2b199529b714766055d161
2017-07-26 22:59:51 +02:00
Translation updater bot 4a9d05cedb Localisation updates from https://translatewiki.net.
Change-Id: I531c01465a83025baa323e8ac021da3b13294a81
2017-07-26 22:48:29 +02:00
Željko Filipin bdef261479 Remove all remaining Ruby code
Ruby was used only for Selenium tests, but they are now written in Node.js.

Bug: T164024
Change-Id: I27b589e4a263214e13e3bc0f1b934bc280901abb
2017-07-26 14:33:36 +02:00
jenkins-bot 51b9e835c6 Merge "Replace Ruby Related pages browser tests with node js version" 2017-07-26 12:19:14 +00:00
Željko Filipin a40cfcb134 Replace Ruby Related pages browser tests with node js version
Additional changes:
* Remove all Ruby artifacts
* Update eslint to allow es6 in tests

Bug: T164024
Change-Id: If6c8d32df042b831d52440963606a47c8ce7b552
2017-07-26 11:41:07 +00:00
Jdlrobson b9269e8284 Merge "Restore default MediaWiki codesniffer configuration" 2017-07-25 18:40:40 +00:00
Željko Filipin 4ffb75d6c8 ESLint should ignore vendor folder
On my machine `npm test` fails with a lot of ESLint errors for files in vendor folder. I guess mediawiki-vagrant creates the folder.

Change-Id: I5466ad8c490b39bef9a31f5442fecd2d11895b80
Depends-On: Ib7f0bd15dd0a9255e1e5140907e800478b658b92
2017-07-25 13:43:23 +00:00
Piotr Miazga 88c7a705e2 Restore default MediaWiki codesniffer configuration
Changes:
 - re-enabled all sniffs
 - fixed code to meet MW code standards

Bug: T170589
Depends-On: Ib7f0bd15dd0a9255e1e5140907e800478b658b92
Change-Id: Idb08a3e105226877804a84b120c70e5defa7398c
2017-07-25 02:46:46 +00:00
Translation updater bot 612d11b200 Localisation updates from https://translatewiki.net.
Change-Id: I585e1e3a56de028018adebb42d001966ee260cd5
2017-07-19 22:50:19 +02:00
jdlrobson f748c5907e Add limit via ResourceLoaderGetConfigVars
Using MakeGlobalVariablesScript hook will add config variables to
the HTML meaning cached HTML will not be able to access it leaving
it as undefined. This will mess up any existing caching.

Additional changes:
Because I'm paranoid, make sure that value is never undefined.

Bug: T170648
Change-Id: Icb8e34104c57b1e69b7e035ef89d5b4c3371132f
2017-07-14 16:42:53 -07:00
jdlrobson 9b75e0b372 Hygiene: Remove unnecessary variable
Improves readability...

Change-Id: Ib0e9cbc083e6c0a384c81815b470063698e0595f
2017-07-14 16:15:35 -07:00
Translation updater bot bcfa59fc81 Localisation updates from https://translatewiki.net.
Change-Id: I0e258a640aa19acb64aa2514d18d1c19be21b0a7
2017-07-14 22:48:20 +02:00
jenkins-bot 38ac4650e0 Merge "Make number of RelatedArticles configurable" 2017-07-06 21:09:06 +00:00
jdlrobson 9126c7d0ef Make number of RelatedArticles configurable
Wikivoyage pages have more than 3 related articles as they make use
of the {{#related:}}  magic word.

After speaking with Nirzar we should allow this project to show more than 3.
This change allows this while keeping the existing behaviour on other wikis and
will pave the way for removing a bunch of code from this extension.

Additional changes:
* Cleanup skinStyles definitions
* Limit cards to 30% maximum width and give margin top to account for
situations where the number of cards are multiple of 3
** In Minerva hardcode the max-width to pixels.
* Margins are switched from hardcoded 10px to percentage based. Yes
this changes the right margin slightly but is more maintable and visually
the same.

Bug: T164765
Change-Id: I41119de3228c2df799f740d4bd00082101c21b97
2017-07-06 11:17:47 -07:00
Translation updater bot 990c33a3dd Localisation updates from https://translatewiki.net.
Change-Id: I72f8e7726444f01692e96d419425477e8bf7de26
2017-07-05 22:39:24 +02:00
Kunal Mehta 8519e02eb7 build: Updating mediawiki/mediawiki-codesniffer to 0.10.0
Change-Id: I35cd178e3825a83f1df9d6dd09b21a543cd8b9cd
2017-07-01 01:41:23 -07:00
jenkins-bot 750f3d73fd Merge "Hygiene: SamplingRate -> BucketSize" 2017-06-22 18:40:08 +00:00
jenkins-bot 970d3547fb Merge "i13n: Don't sample by pageview" 2017-06-20 21:59:31 +00:00
Kunal Mehta 87b7254eaf build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.FunctionComment.Missing.Public

Change-Id: I591fd0cd60147b9f5ddd3d1b9e74f79a0bb3f595
2017-06-20 00:20:19 -07:00
Sam Smith f4c82d3a33 Hygiene: SamplingRate -> BucketSize
In order to avoid further confusion, clarify that we're bucketing users
for experiments.

Bug: T167236
Depends-On: I752cdf068ca25bffb38229380785e7da1a208049
Change-Id: I6508ab8fa3d436ae295eb047e170fdc5417d25fc
2017-06-20 05:26:29 +01:00
Sam Smith 153573dbe5 i13n: Don't sample by pageview
Currently, the mw.eventLog.Schema class samples per pageview. However,
we expect that if a user is bucketed for a session, then all
EventLogging events logged during that session are in the sample.

Unlike Popups in I4f653bba, the RelatedArticles instrumentation does
rely on another mw.eventLog.Schema behavior: distinguishing between
static and dynamic data. This and the use of mw.eventLog.Schema could be
removed in a follow-on change.

Bug: T167236
Change-Id: I9583cb98264efd7dc46b45bbce5323036a100536
2017-06-19 12:20:42 +01:00
jdlrobson 4598d9b567 Remove CardsGateway (unused)
Bug: T167647
Change-Id: I7e2a7777a5f28991d77deab520a55d3bd242104b
2017-06-14 13:10:01 -07:00
Translation updater bot 406cce83b1 Localisation updates from https://translatewiki.net.
Change-Id: I1c2ec1fbd8d04f1c7408158872455c8880af6ca3
2017-06-12 22:44:59 +02:00
jenkins-bot 83d06e997d Merge "Migrate Cards code to RelatedArticles" 2017-06-08 16:54:10 +00:00
jdlrobson 6dee0147f4 Migrate Cards code to RelatedArticles
* Move across all files
* Rename ext-card- prefix to ext-related-articles- prefix
** Since all code using these prefixes is JS
  we do not have to worry about cached HTML

Bug: T137021
Change-Id: I784fd132c36329fa0dcc49fe2804460061940347
2017-06-07 08:35:53 -07:00
Amir Sarabadani 9182831c11 Add CODE_OF_CONDUCT.md
Bug: T165540
Change-Id: Iaa276e0f65c5dd237b851226df1b691007219dbe
2017-06-07 15:41:22 +04:30
jenkins-bot a27fa2bc9b Merge "Session id should not change on every page view" 2017-06-07 08:04:16 +00:00
jdlrobson eb5a86908a Session id should not change on every page view
Bug: T167236
Change-Id: I7a04c5c3f959ce0e7dc50e2bc2fd64d139b78cdb
2017-06-06 16:53:12 -07:00
Translation updater bot d333bd3612 Localisation updates from https://translatewiki.net.
Change-Id: I61403556f4139b0eedf2704518686b934019a5f3
2017-06-01 23:12:44 +02:00
Translation updater bot 4933f5143e Localisation updates from https://translatewiki.net.
Change-Id: Ia4884d1cd66be6fa5d9678215805e125e1816db4
2017-05-11 23:27:46 +02:00
Translation updater bot 1d3659048a Localisation updates from https://translatewiki.net.
Change-Id: I7d558ce043de25d81ecefb49eb1730d1be2266c7
2017-05-06 22:57:59 +02:00