mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-12-21 11:32:53 +00:00
90acf2a778
I tested this with all 16 possible combinations: * The pointer can show up in all 4 corners. * The popup can contain a thumbnail or not. The code for the pointer is very different then, because the SVG masks are only relevant in this scenario. * The thumbnail can be tall or not. * I even tested tall popups without a thumbnail. This is a combination that is impossible in production scenarios. I found 3 issues. This patch fixes 2 of them: * The pointer is misplaced in the bottom-right corner when the popup does not have a thumbnail (as reported in T215194). * The pointer is misplaced in the upper-right corner when the popup shows a thumbnail. * The pointer in the upper-right corner is gray instead of white when the popup is tall, but does not show a thumbnail. As this is not relevant in production, I did not fixed it. It seems both misplacements are because of the same reason: For some reason, calculations are done based on the assumption the popup would be 300px wide, but it is 320px wide. Note I did not just added 20 everywhere, but manually alligned the pointer triangles so they are placed exactly the same distance from the corner as in the three other corners. Note I did not tested this (yet) in RTL scenarios. Bug: T215194 Change-Id: If0ca63d4d4b6e8083c7de1517fe32f49671a40e6 |
||
|---|---|---|
| .. | ||
| templates | ||
| index.less | ||
| mixins.less | ||
| pointer-mask.svg | ||
| renderer.js | ||
| settingsDialog.js | ||
| settingsDialogRenderer.js | ||
| settingsDialogRenderer.less | ||
| thumbnail.js | ||
| variables.less | ||
