90acf2a778
I tested this with all 16 possible combinations: * The pointer can show up in all 4 corners. * The popup can contain a thumbnail or not. The code for the pointer is very different then, because the SVG masks are only relevant in this scenario. * The thumbnail can be tall or not. * I even tested tall popups without a thumbnail. This is a combination that is impossible in production scenarios. I found 3 issues. This patch fixes 2 of them: * The pointer is misplaced in the bottom-right corner when the popup does not have a thumbnail (as reported in T215194). * The pointer is misplaced in the upper-right corner when the popup shows a thumbnail. * The pointer in the upper-right corner is gray instead of white when the popup is tall, but does not show a thumbnail. As this is not relevant in production, I did not fixed it. It seems both misplacements are because of the same reason: For some reason, calculations are done based on the assumption the popup would be 300px wide, but it is 320px wide. Note I did not just added 20 everywhere, but manually alligned the pointer triangles so they are placed exactly the same distance from the corner as in the three other corners. Note I did not tested this (yet) in RTL scenarios. Bug: T215194 Change-Id: If0ca63d4d4b6e8083c7de1517fe32f49671a40e6 |
||
|---|---|---|
| .storybook | ||
| docs | ||
| i18n | ||
| includes | ||
| resources | ||
| src | ||
| tests | ||
| .babelrc | ||
| .browserslistrc | ||
| .eslintrc.es5.json | ||
| .eslintrc.json | ||
| .gitattributes | ||
| .gitignore | ||
| .gitreview | ||
| .istanbul.yml | ||
| .nvmrc | ||
| .nycrc.json | ||
| .phpcs.xml | ||
| .stylelintrc.json | ||
| .svgo.json | ||
| CODE_OF_CONDUCT.md | ||
| composer.json | ||
| COPYING | ||
| extension.json | ||
| Gruntfile.js | ||
| jsdoc.json | ||
| package.json | ||
| popups.svg | ||
| README.md | ||
| webpack.config.js | ||
mediawiki/extensions/Popups
See https://www.mediawiki.org/wiki/Extension:Popups for more information about what it does.
Development
Popups uses an asset bundler so when developing for the extension you'll need to run a script to assemble the frontend assets.
You can find the frontend source files in src/, the compiled sources in
resources/dist/, and other frontend assets managed by resource loader in
resources/*.
After an npm install:
- On one terminal, kickstart the bundler process:
npm startWill run the bundler in watch mode, re-assembling the files on file change. Additionally, this builds debug-friendly assets and enables Redux DevTools debugging.npm run buildWill compile the assets just once, ready for deployment. You must run this step before sending the patch or CI will fail (so that sources and built assets are in sync).
- On another terminal, run tests and linting tools:
npm testTo run the linting tools and the tests.- You can find the QUnit tests that depend on running MediaWiki under
tests/qunit/ - You can find the isolated QUnit tests under
tests/node-qunit/, which you can run withnpm run test:unit
- You can find the QUnit tests that depend on running MediaWiki under
- We recommend you install a file watcher like
nodemonto watch sources and auto run linting and tests.npm install -g nodemon- Example running linting and node unit tests:
nodemon -w src/ --exec "grunt lint:all && npm run test:unit"
- Get code coverage report with
npm run coverage- Reports printed in the
coverage/folder
- Reports printed in the
Developers are likely to work with local MediaWiki instances that do not have content to test with. To reduce this pain, you can create a single page with a list of links that point to an existing and external wiki by using the following config flag:
$wgPopupsGateway = 'restbaseHTML';
$wgPopupsRestGatewayEndpoint = 'https://en.wikipedia.org/api/rest_v1/page/summary/';
Popups works with a local copy of the Mobile Content Service too:
$wgPopupsGateway = 'restbaseHTML';
$wgPopupsRestGatewayEndpoint = 'http://localhost:6927/en.wikipedia.org/v1/page/summary/';
Debugging
- Popups are dismissed ("abandoned") when the cursor leaves the popup
container. As such, it can be difficult to debug a popup of interest
without it popping in and out of the DOM. A useful workaround in
DevTools is to context click a link, select inspect, move the cursor
some place comfortable, and then from the console enter
$($0).trigger('mouseenter'). - As described in #Development,
npm startenables Redux DevTools functionality. In production builds, this same functionality can be enabled by setting adebug=truequery. E.g.,https://en.wikipedia.org/wiki/Popup?debug=true.
Storybook.js Component Library
The root of the repository contains a .storybook directory. This folder contains a separate NPM project using the Storybook.js UI framework. This framework provides an environment that showcases all possible permutations of popups, without the state-management constraints of having only one popup per page.
This framework requires Node v8 (because of the spread ... operator) and is therefore
separated from the main package.json until CI upgrades from Node v6. NVM can be used to
manage multiple Node versions to run the Storybook app (cd .storybook && nvm use).
See the .storybook/README.md for details.
Terminology
- Footnote - What the Cite extension shows at the bottom of the page.
- Hovercard - Deprecated term for popup.
- Link preview - A similar user feature in the Android native app.
- Navpop / nav pop - A popup-like UI from the NavigationPopups gadget.
- Popup - Generic term for a dialog that appears to float above a link that is being hovered over by a cursor.
- Page preview - A specific type of popup that shows a page summary.
- Preview - A synonym for popup.
- Reference - A specific type of popup that previews the Cite extension's
footnotes. Since footnotes are typically used for references, and the tag's
name is
<ref>, the terms are used synonymously.