Go to file
Thiemo Kreuz 67ceeaeeed Inline code setting target="_blank" in renderReferencePreview()
As discussed in Iaadcce9. This does have a few benefits:
* Less code in the already pretty big render.js file.
* The code setting the target attribute is much closer to where it
  belongs: in the file that specifies how the content of a reference
  popup should look and behave.
* The class name "mwe-popups-extract" is not mentioned in two different
  files, but in the same.

Note this changes the signature of this src/ui/templates/… file to not
return an HTML string any more, but a jQuery object. The other templates
still return strings. I believe this is fine, and not that much of a
difference anyway. The signatures don't need to be identical. And the
jQuery object still represents the exact same HTML as before.

If it helps we could change all templates/… signatures accordingly.
Could be done in this or a separate patch.

Bug: T213908
Bug: T214970
Change-Id: I05ed4b886f79c5ae748f53ab9fed965dfd217620
2019-02-01 12:46:29 +01:00
.storybook Lower node version 2019-01-08 15:03:35 -08:00
docs Hygiene: rename NPM test:node to test:unit 2019-01-24 08:29:27 -07:00
i18n Localisation updates from https://translatewiki.net. 2019-01-31 22:26:17 +01:00
includes Fix a series of minor documentation issues in PHP code 2019-02-01 09:42:14 +01:00
resources Inline code setting target="_blank" in renderReferencePreview() 2019-02-01 12:46:29 +01:00
src Inline code setting target="_blank" in renderReferencePreview() 2019-02-01 12:46:29 +01:00
tests Merge "Simplify mediaWiki.msg mock in renderer test" 2019-02-01 11:34:39 +00:00
.babelrc Switch from babel-preset-env to @babel/preset-env 2018-12-11 13:09:45 +05:30
.eslintrc.es5.json Upgrade redux / redux-thunk 2018-12-13 15:04:03 -07:00
.eslintrc.json build: Update eslint-config-wikimedia to 0.10.0 2019-01-31 11:05:33 +01:00
.gitattributes Hide package lock file from git diff 2018-03-14 19:06:51 +00:00
.gitignore Storybook.js for Popups 2019-01-08 14:19:00 +01:00
.gitreview Merge remote-tracking branch 'gerrit/mpga' 2017-02-14 11:20:17 -08:00
.istanbul.yml Hygiene: Tidy up QUnit references 2017-05-04 15:53:44 +01:00
.nvmrc Hygiene: add NVM config 2018-09-05 19:16:36 +00:00
.nycrc.json Switch from babel-preset-env to @babel/preset-env 2018-12-11 13:09:45 +05:30
.phpcs.xml build: Update sniff list in .phpcs.xml 2018-12-08 15:34:57 +01:00
.stylelintrc.json build: Update linters 2018-02-04 22:09:45 +00:00
.svgo.json build: Bring SVGO optimization to build step 2018-08-01 10:51:43 -05:00
CODE_OF_CONDUCT.md build: Updating mediawiki/phan-taint-check-plugin to 1.3.0 2018-08-19 15:37:11 +00:00
composer.json build: Updating mediawiki/mediawiki-codesniffer to 23.0.0 2018-11-16 07:41:01 +00:00
COPYING Add COPYING file 2014-02-06 15:38:46 +05:30
extension.json Add default OOUI reference icon to all reference popups 2019-01-29 17:06:40 +01:00
Gruntfile.js Hygiene: enable ESLint caching 2018-10-17 16:45:35 -06:00
jsdoc.json Hygiene: make JSDoc configs consistent 2018-07-23 14:45:14 -05:00
package.json build: Update eslint-config-wikimedia to 0.10.0 2019-01-31 11:05:33 +01:00
popups.svg Remove BetaFeature code 2018-04-26 15:51:48 -07:00
README.md Hygiene: rename NPM test:node to test:unit 2019-01-24 08:29:27 -07:00
webpack.config.js Hygiene: report when Webpack builds complete 2019-01-17 17:21:23 +00:00

Popups

mediawiki/extensions/Popups

See https://www.mediawiki.org/wiki/Extension:Popups for more information about what it does.

Development

Popups uses an asset bundler so when developing for the extension you'll need to run a script to assemble the frontend assets.

You can find the frontend source files in src/, the compiled sources in resources/dist/, and other frontend assets managed by resource loader in resources/*.

After an npm install:

  • On one terminal, kickstart the bundler process:
    • npm start Will run the bundler in watch mode, re-assembling the files on file change. Additionally, this builds debug-friendly assets and enables Redux DevTools debugging.
    • npm run build Will compile the assets just once, ready for deployment. You must run this step before sending the patch or CI will fail (so that sources and built assets are in sync).
  • On another terminal, run tests and linting tools:
    • npm test To run the linting tools and the tests.
      • You can find the QUnit tests that depend on running MediaWiki under tests/qunit/
      • You can find the isolated QUnit tests under tests/node-qunit/, which you can run with npm run test:unit
    • We recommend you install a file watcher like nodemon to watch sources and auto run linting and tests.
      • npm install -g nodemon
      • Example running linting and node unit tests:
        • nodemon -w src/ --exec "grunt lint:all && npm run test:unit"
    • Get code coverage report with npm run coverage
      • Reports printed in the coverage/ folder

Developers are likely to work with local MediaWiki instances that do not have content to test with. To reduce this pain, you can create a single page with a list of links that point to an existing and external wiki by using the following config flag:

$wgPopupsGateway = 'restbaseHTML';
$wgPopupsRestGatewayEndpoint = 'https://en.wikipedia.org/api/rest_v1/page/summary/';

Popups works with a local copy of the Mobile Content Service too:

$wgPopupsGateway = 'restbaseHTML';
$wgPopupsRestGatewayEndpoint = 'http://localhost:6927/en.wikipedia.org/v1/page/summary/';

Debugging

  • Popups are dismissed ("abandoned") when the cursor leaves the popup container. As such, it can be difficult to debug a popup of interest without it popping in and out of the DOM. A useful workaround in DevTools is to context click a link, select inspect, move the cursor some place comfortable, and then from the console enter $($0).trigger('mouseenter').
  • As described in #Development, npm start enables Redux DevTools functionality. In production builds, this same functionality can be enabled by setting a debug=true query. E.g., https://en.wikipedia.org/wiki/Popup?debug=true.

Storybook.js Component Library

The root of the repository contains a .storybook directory. This folder contains a separate NPM project using the Storybook.js UI framework. This framework provides an environment that showcases all possible permutations of popups, without the state-management constraints of having only one popup per page.

This framework requires Node v8 (because of the spread ... operator) and is therefore separated from the main package.json until CI upgrades from Node v6. NVM can be used to manage multiple Node versions to run the Storybook app (cd .storybook && nvm use). See the .storybook/README.md for details.

Terminology

  • Footnote - What the Cite extension shows at the bottom of the page.
  • Hovercard - Deprecated term for popup.
  • Link preview - A similar user feature in the Android native app.
  • Navpop / nav pop - A popup-like UI from the NavigationPopups gadget.
  • Popup - Generic term for a dialog that appears to float above a link that is being hovered over by a cursor.
  • Page preview - A specific type of popup that shows a page summary.
  • Preview - A synonym for popup.
  • Reference - A specific type of popup that previews the Cite extension's footnotes. Since footnotes are typically used for references, and the tag's name is <ref>, the terms are used synonymously.