mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-12-02 19:26:24 +00:00
fe32c48268
This was motivated by two things: 1. Notice the bad class name in UserPreferencesChangeHandlerTest. This was possible because the default mock builder does not check if a class exists, *and* there was no type hint in place. createMock() *does* check if a class exists. 2. We are free to use createMock() from PHPUnit 5+ now. It's not only shorter but more strict and reliable. Change-Id: I301a171d587026eab0a62575ab2fdbfd7733c661
59 lines
2.1 KiB
PHP
59 lines
2.1 KiB
PHP
<?php
|
|
/*
|
|
* This file is part of the MediaWiki extension Popups.
|
|
*
|
|
* Popups is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Popups is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Popups. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* @file
|
|
* @ingroup extensions
|
|
*/
|
|
use Popups\PopupsContext;
|
|
use Popups\UserPreferencesChangeHandler;
|
|
|
|
/**
|
|
* @group Popups
|
|
* @coversDefaultClass \Popups\UserPreferencesChangeHandler
|
|
*/
|
|
class UserPreferencesChangeHandlerTest extends MediaWikiTestCase {
|
|
|
|
/**
|
|
* @covers ::doPreferencesFormPreSave
|
|
* @covers ::__construct
|
|
* @dataProvider provideDataForEventHandling
|
|
*/
|
|
public function testEventHandling( $oldOption, $newOption, $expectedMethodCallsCount ) {
|
|
$contextMock = $this->createMock( PopupsContext::class );
|
|
$contextMock->expects( $expectedMethodCallsCount )
|
|
->method( 'logUserDisabledPagePreviewsEvent' );
|
|
|
|
$user = $this->getMutableTestUser()->getUser();
|
|
$user->setOption( PopupsContext::PREVIEWS_OPTIN_PREFERENCE_NAME, $newOption );
|
|
$oldOptions = [
|
|
PopupsContext::PREVIEWS_OPTIN_PREFERENCE_NAME => $oldOption
|
|
];
|
|
$listener = new UserPreferencesChangeHandler( $contextMock );
|
|
$listener->doPreferencesFormPreSave( $user, $oldOptions );
|
|
}
|
|
|
|
public function provideDataForEventHandling() {
|
|
return [
|
|
[ PopupsContext::PREVIEWS_DISABLED, PopupsContext::PREVIEWS_DISABLED, $this->never() ],
|
|
[ PopupsContext::PREVIEWS_ENABLED, PopupsContext::PREVIEWS_ENABLED, $this->never() ],
|
|
[ PopupsContext::PREVIEWS_DISABLED, PopupsContext::PREVIEWS_ENABLED, $this->never() ],
|
|
[ PopupsContext::PREVIEWS_ENABLED, PopupsContext::PREVIEWS_DISABLED, $this->once() ]
|
|
];
|
|
}
|
|
|
|
}
|