Go to file
Translation updater bot 09f36bfc25 Localisation updates from https://translatewiki.net.
Change-Id: I178fd57b3d8f06def5757eada73212b741fdf9f8
2019-11-07 09:44:51 +01:00
.phan Add phan 2019-04-25 20:54:33 +02:00
.storybook Remove obsolete mediaWiki and jQuery aliases 2019-10-22 09:30:46 +02:00
docs Hygiene: rename NPM test:node to test:unit 2019-01-24 08:29:27 -07:00
i18n Localisation updates from https://translatewiki.net. 2019-11-07 09:44:51 +01:00
includes Make use of User::getBoolOption() where appropriate 2019-10-22 09:58:47 +02:00
resources Record pageviews where Reference Previews is enabled 2019-10-24 23:34:56 +02:00
src Merge "Use standard size and fix alignment of generic reference icon" 2019-10-30 08:41:42 +00:00
tests Use 6.1.0 of @wikimedia/mw-node-qunit 2019-10-22 10:42:49 -07:00
.babelrc Move browserslist targets to new file and change targets 2019-02-11 17:37:03 -07:00
.browserslistrc Move browserslist targets to new file and change targets 2019-02-11 17:37:03 -07:00
.eslintrc.es5.json Remove obsolete mediaWiki and jQuery aliases 2019-10-22 09:30:46 +02:00
.eslintrc.json Remove obsolete mediaWiki and jQuery aliases 2019-10-22 09:30:46 +02:00
.gitattributes Hide package lock file from git diff 2018-03-14 19:06:51 +00:00
.gitignore Storybook.js for Popups 2019-01-08 14:19:00 +01:00
.gitreview Merge remote-tracking branch 'gerrit/mpga' 2017-02-14 11:20:17 -08:00
.istanbul.yml Hygiene: Tidy up QUnit references 2017-05-04 15:53:44 +01:00
.nvmrc Upgrade from node 6 to node 10, now that CI is running that 2019-06-03 14:51:51 -07:00
.nycrc.json Switch from babel-preset-env to @babel/preset-env 2018-12-11 13:09:45 +05:30
.phpcs.xml build: Remove unneeded Squiz.WhiteSpace.FunctionSpacing 2019-10-25 20:32:36 +02:00
.stylelintrc.json build: Update linters 2018-02-04 22:09:45 +00:00
.svgo.json build: Bring SVGO optimization to build step 2018-08-01 10:51:43 -05:00
CODE_OF_CONDUCT.md build: Updating mediawiki/phan-taint-check-plugin to 1.3.0 2018-08-19 15:37:11 +00:00
composer.json build: Updating mediawiki/mediawiki-phan-config to 0.8.0 2019-11-04 18:48:36 +01:00
COPYING Add COPYING file 2014-02-06 15:38:46 +05:30
extension.json Record pageviews where Reference Previews is enabled 2019-10-24 23:34:56 +02:00
Gruntfile.js Build: Update linters 2019-09-17 12:47:25 +01:00
jsdoc.json Hygiene: make JSDoc configs consistent 2018-07-23 14:45:14 -05:00
package-lock.json Use 6.1.0 of @wikimedia/mw-node-qunit 2019-10-22 10:42:49 -07:00
package.json Use 6.1.0 of @wikimedia/mw-node-qunit 2019-10-22 10:42:49 -07:00
popups.svg Remove BetaFeature code 2018-04-26 15:51:48 -07:00
README.md Doc: Refer to Node versions without "v" prefix 2019-06-10 17:30:26 +01:00
webpack.config.js Split user preferences for Page and Reference previews 2019-10-17 11:21:21 +02:00

Popups

mediawiki/extensions/Popups

See https://www.mediawiki.org/wiki/Extension:Popups for more information about what it does.

Development

Popups uses an asset bundler so when developing for the extension you'll need to run a script to assemble the frontend assets.

You can find the frontend source files in src/, the compiled sources in resources/dist/, and other frontend assets managed by resource loader in resources/*.

After an npm install:

  • On one terminal, kickstart the bundler process:
    • npm start Will run the bundler in watch mode, re-assembling the files on file change. Additionally, this builds debug-friendly assets and enables Redux DevTools debugging.
    • npm run build Will compile the assets just once, ready for deployment. You must run this step before sending the patch or CI will fail (so that sources and built assets are in sync).
  • On another terminal, run tests and linting tools:
    • npm test To run the linting tools and the tests.
      • You can find the QUnit tests that depend on running MediaWiki under tests/qunit/
      • You can find the isolated QUnit tests under tests/node-qunit/, which you can run with npm run test:unit
    • We recommend you install a file watcher like nodemon to watch sources and auto run linting and tests.
      • npm install -g nodemon
      • Example running linting and node unit tests:
        • nodemon -w src/ --exec "grunt lint:all && npm run test:unit"
    • Get code coverage report with npm run coverage
      • Reports printed in the coverage/ folder

Developers are likely to work with local MediaWiki instances that do not have content to test with. To reduce this pain, you can create a single page with a list of links that point to an existing and external wiki by using the following config flag:

$wgPopupsGateway = 'restbaseHTML';
$wgPopupsRestGatewayEndpoint = 'https://en.wikipedia.org/api/rest_v1/page/summary/';

Popups works with a local copy of the Mobile Content Service too:

$wgPopupsGateway = 'restbaseHTML';
$wgPopupsRestGatewayEndpoint = 'http://localhost:6927/en.wikipedia.org/v1/page/summary/';

Debugging

  • Popups are dismissed ("abandoned") when the cursor leaves the popup container. As such, it can be difficult to debug a popup of interest without it popping in and out of the DOM. A useful workaround in DevTools is to context click a link, select inspect, move the cursor some place comfortable, and then from the console enter $($0).trigger('mouseenter').
  • As described in #Development, npm start enables Redux DevTools functionality. In production builds, this same functionality can be enabled by setting a debug=true query. E.g., https://en.wikipedia.org/wiki/Popup?debug=true.

Storybook.js Component Library

The root of the repository contains a .storybook directory. This folder contains a separate NPM project using the Storybook.js UI framework. This framework provides an environment that showcases all possible permutations of popups, without the state-management constraints of having only one popup per page.

This framework requires Node 8 (because of the spread ... operator) and is therefore separated from the main package.json until CI upgrades from Node 6. NVM can be used to manage multiple Node versions to run the Storybook app (cd .storybook && nvm use). See the .storybook/README.md for details.

Terminology

  • Footnote - What the Cite extension shows at the bottom of the page.
  • Hovercard - Deprecated term for popup.
  • Link preview - A similar user feature in the Android native app.
  • Navpop / nav pop - A popup-like UI from the NavigationPopups gadget.
  • Popup - Generic term for a dialog that appears to float above a link that is being hovered over by a cursor.
  • Page preview - A specific type of popup that shows a page summary.
  • Preview - A synonym for popup.
  • Reference - A specific type of popup that previews the Cite extension's footnotes. Since footnotes are typically used for references, and the tag's name is <ref>, the terms are used synonymously.