I just found these while fixing tests in Cite. The lines were
added with the ReferencePreviews tests back in the days. Need to
be removed here.
See I2638611ba67b785338f7e98a1c4b08a5e829812d
Change-Id: I650317de4a1d8ec916c52c6c619b3a623a2f217b
Most of page previews is private, and developers should rely
on text editors to explore the codebase.
For public documentation we only surface what is a stable API
for page previews.
Change-Id: I8536de1de3038de43e5108f7d877df2ba3a2175b
Remove the ext.popups.images module, replacing it with
references to the SVG image.
- The footer image is the same in dark and light mode so use
background image
- Use mask image for sad face to make it work correctly in dark mode.
- Rely on CSS Janus for the ltr to rtl swap out
Change-Id: Idf041730549b834126d9631ac95611526ae5daa3
Changes drop-shadow color for Page Previews from
`rgba( 0, 0, 0, 0.05 )` to `@background-color-neutral`.
This is a slight visual change that maintains the tone of the
gray border, but removes it's opacity.
Bug: T365428
Change-Id: I065324e35eb28027d98e88d35b99b1d5266690d5
Commit a75ddc41 and 33f9e9d3 effectively changed the default user
option value of popups-reference-previews for users created before
2017/08/16 without any justification.
Please see the task description for full analysis.
This partially reverts commit a75ddc41.
Bug: T366419
Change-Id: I68d6114384af6d259dbc4541522d52ae9a289e49
The keys belong to the Cite extension where they are used already.
Bug: T363156
Depends-On: I788c16c5bddc0df7f00dbbc39625b9adaa5bf184
Change-Id: I1205af0539d6b2693f0e96d70393e7ecb005b7ba
Implement conditional defaults for user preferences in the Popups
component.
This patch aims to simplify the preference management system by
leveraging conditional logic directly within the component rather
than relying on multiple hooks
Changes:
- Updated `extension.json` to reflect the removal of outdated hooks.
- Updated `extension.json` to reflect the conditional user defaults.
- Removed unused user option `popupsreferencepreviews` from
`extension.json`
- Modified `PopupsHooks` to streamline the preferences management,
and depend on conditional user defaults, and removing `onUserGetDefaultOptions` and `onLocalUserCreated` hooks.
- Removed unneeded test cases in `PopupsHooksTest`.
Bug: T364347
Change-Id: Iae454e4b4704a0289ca0a2b0794730562fda0dd1
Currently, the gradient is fading into #000 when what we want is #101418
(represented by @background-color-base). Correct this and remove the
hardcoded rgba values as we don't need them and this gives us one less
place to update if the value changes in the future
Visual change (bug fix)
Bug: T360877
Change-Id: If330dd251dffb07f371c0c9222c6ef5f52120e25
It currently doesn't trigger because the links lack a
title attribute, but if one were to be added the tool
would trigger as, although timestamp links are just hash
fragment links, we also include the canonical path
before the hash.
Change-Id: I156b1401f5173ba1727861adf1efa136b96d330f
Previous changes in Codex have eliminated all differences between the
"legacy" build of the design tokens and the standard one.
This patch removes all references to the legacy build in preparation for the
upcoming removal of the legacy assets from Codex upstream.
Bug: T360806
Change-Id: Ib381fc6ea77d5cde21e064df3900acf005f31c9e
