Prtksxna
e6adbef707
Merge "rename variable, and parentheses not brackets"
2014-06-25 00:50:51 +00:00
Prtksxna
8a680a2433
Merge "Raise popup show/hide delay to 500ms/300ms, respectively"
2014-06-25 00:46:15 +00:00
S Page
4c86e94e49
rename variable, and parentheses not brackets
...
removeBracketsFromText doesn't count it tracks nesting level, and
brackets are [] not (). Minor detail.
Change-Id: I8f42b1ccae5233d7b6062bb311eced6ef3085d4a
2014-06-24 01:23:05 -07:00
jenkins-bot
49c0c2f669
Merge "render.article: Remove brackets using code instead of RegExp"
2014-06-24 08:12:55 +00:00
jenkins-bot
2cb63c5226
Merge "render.article.getProcessesHtml: Add tests"
2014-06-24 08:02:28 +00:00
Prtksxna
b65954645f
Merge "Check for empty response"
2014-06-23 01:51:15 +00:00
Derk-Jan Hartman
e3de26ebfe
Re-use result instead of querying the DOM for selector multiple times
...
It's a complicated query, we should not repeat it when not necessary.
Change-Id: I71d47de088afa7dab0a6eaed214c61db699fcd0c
2014-06-23 06:47:38 +05:30
Bartosz Dziewoński
3041d358ed
Raise popup show/hide delay to 500ms/300ms, respectively
...
Per discussion on the bug, the current values of 150ms/100ms cause a
lot of unintended actions.
Bug: 64234
Change-Id: I6fe2d89ad97630ec5c7f47d3e3b9b71d7cfc5d3f
2014-06-20 16:48:00 +02:00
Fomafix
58be4ea1de
Check for empty response
...
In combination with other gadgets the error
TypeError: re.query is undefined
can occur because the request contains titles:'' and the response is [].
Change-Id: I46d02e7c48a55cd9af20fd7ef729b4d26f69a8c0
2014-06-18 20:57:19 +00:00
Prateek Saxena
f44b1701a2
render.article: Remove brackets using code instead of RegExp
...
Casees:
1) Hello (and welcome)
2) Hello )and welcome(
3) (Hello (and) welcome)
The current RegExp only takes care of (1). The new code should
take care of all the cases.
Bug: 65138
Change-Id: I39f38beed0cf612067d6fc61b18295d1d38fcc22
2014-06-11 12:51:31 +05:30
Prateek Saxena
40222517ca
render.article.getProcessesHtml: Add tests
...
Change-Id: I2e000fd884df9113f1810ec1ca2aa1562a88790b
2014-06-11 12:47:52 +05:30
Prateek Saxena
0192822522
disablenavpop: Correct type check for disablePopups global
...
Change-Id: I33f62c74fe231c74cf54937aa43ac35ae15a0b37
2014-06-10 16:50:24 +05:30
jenkins-bot
8682faa2f6
Merge "renderer.article: Escape RegExp syntax from the article's title"
2014-06-08 12:46:16 +00:00
jenkins-bot
f0d58e0f7d
Merge "animation: Use the animation mixin in core and pass fill-mode as an argument"
2014-06-06 11:10:24 +00:00
Prateek Saxena
a6ad92e9fd
Disable NavigationPopups (Gadget) if Popups (Extension) is enabled
...
Bug: 62952
Change-Id: If3757199c280bb0ad54878111dcf926b88778b64
2014-06-06 13:04:34 +05:30
Prateek Saxena
2b59d8530d
renderer.article: Escape RegExp syntax from the article's title
...
Bug: 66203
Change-Id: Id9b523643e8540a717919fa5bb65a6d980722c0f
2014-06-06 09:56:13 +05:30
Prateek Saxena
4a15462ea0
animation: Use the animation mixin in core and pass fill-mode as an argument
...
Bug: 65923
Change-Id: I4222d811d56a84fe046dfe4a96eda636e76967a5
2014-06-03 11:56:00 +05:30
Prateek Saxena
d1ddb95067
Flip the animation direction if the Hovercard is flipped
...
Change-Id: I890d49c517a52e57e0b22bcf1949b347d531d6b7
2014-05-30 16:25:14 +05:30
Prateek Saxena
a52242087f
animation: Add fade animations from other directions
...
1. fade-in-down
2. fade-out-up
Change-Id: I108b6bb6bbb8ac49401e9dc0d6599e57c42abf62
2014-05-30 05:18:05 +05:30
Translation updater bot
8fa9d90ae9
Localisation updates from https://translatewiki.net .
...
Change-Id: I00ccbd351f4485ea3400204482067c6bca26d64d
2014-05-29 19:38:16 +00:00
jenkins-bot
08c7bbf11b
Merge "animation: Correctly name the animation classes"
2014-05-29 19:04:54 +00:00
jenkins-bot
1877fda630
Merge "Use only px in the stylesheet"
2014-05-29 18:46:27 +00:00
Prateek Saxena
dd309071d2
animation: Correctly name the animation classes
...
fade-in to fade-in-up
fade-out to fade-out-down
Change-Id: I6e8877a509fdb3e3f570e16d59438bff61e2615a
2014-05-29 00:35:25 +00:00
Prateek Saxena
9cc318c3eb
renderer: Ignore # links
...
Bug: 65425
Change-Id: Ic610ee485da668b9a141234f56477faf7bcaa447
2014-05-27 19:24:28 +05:30
jenkins-bot
5e11a35d95
Merge "Popups: The promise of the popups was not forwarding failures"
2014-05-22 13:47:14 +00:00
Derk-Jan Hartman
fab07e5c6f
Popups: The promise of the popups was not forwarding failures
...
Change-Id: Icc1d5a175ccf9ef000dd198f999994917912de3f
2014-05-22 19:14:38 +05:30
Derk-Jan Hartman
cc4d67c67c
Popups: Fix popups for extiw links
...
These links were not ignored due to a typo. This also threw an error,
because these links produced query.interwiki and not in query.pages.
Change-Id: I3b5c5b900209323e3e72b41e3b02e90f1f53b4eb
2014-05-20 00:30:29 +02:00
Prateek Saxena
418394bc8e
Use only px in the stylesheet
...
Instead of the current incomprehensible mixture of em's and px's.
This will help resolve other positioning bugs with relative ease.
Change-Id: I9d7659736489c461ab8c0f4aa660a3ce2846bd5d
2014-05-19 15:46:58 +05:30
Thiemo Mättig
b656841f8f
Don't underline hovercard text when user preference is 'Always'
...
The setting is called 'underline' and defaults to 'Skin or
browser default' (= 2). If set to 'Always' (= 1), which is what
I personally like and do, ;-) all text in hovercards is
underlined (and the underlines disappear if you hover the
hovercard, which is a bit tricky but possible).
This simple fix removes the dependency from the default style
(which only shows underlines on hover). I think this is the most
straightforward solution.
Change-Id: Ide54ffd1949a50184d8d2a680bf1a0d35e24d563
2014-05-12 16:18:20 +02:00
Prateek Saxena
046a34b9a0
render.article: Make the title of the text bold in the extract
...
Bug: 65098
Change-Id: Ibd7c821d538acd2045e0ffb9a8b2274d61d99484
2014-05-11 00:00:26 +05:30
Prateek Saxena
e4d18a1c0e
render.article: Fix regexp for removing brackets
...
Change-Id: I4fbff8a5d34cf48a44aae4a12e6d2a23c362b4cf
2014-05-10 19:35:31 +05:30
jenkins-bot
770d29949c
Merge "render.article: Remove text inside brackets along with the brackets"
2014-05-10 13:50:17 +00:00
Prateek Saxena
b587fcda20
render.article: Remove text inside brackets along with the brackets
...
Change-Id: I544bf0daf935b9ddb5bb64c4eae1fd96baef2c44
2014-05-10 17:46:04 +05:30
Prateek Saxena
c4f46dd7d4
Increase font size
...
Increase the extract font-size. Also increase
the max-height of .mwe-popups-extract so that
the text does not get cut.
Bug: 63508
Change-Id: Icde0ca8af44e68cab71816f4c89fe9a68f66b472
2014-05-10 11:42:48 +05:30
Prateek Saxena
5a7393407c
render.article: Fix image placement on non-SVG browsers
...
Bug: 64598
Change-Id: I9e3434330a0c51e625921f6255119ff96deccbc6
2014-05-09 13:53:19 +00:00
Prateek Saxena
e7376cd517
render.article: Flip popups on X and Y axis so that they don't render outside the viewport
...
Bug: 62971
Change-Id: I893e239889874be83cfbf202095f617ee6091d6f
2014-05-09 13:52:16 +00:00
Prateek Saxena
1045bda2b5
render.article: Break down the createThumbnail method
...
Bug: 61267
Change-Id: Id17bc6d19f044d6a4837eebb6b1a264ee104ea84
2014-05-09 13:51:32 +00:00
Translation updater bot
f6eac1286a
Localisation updates from https://translatewiki.net .
...
Change-Id: Ic6398b8811869374925e21fd4bc90ca38b0cf28c
2014-05-07 20:01:10 +00:00
jenkins-bot
fade5cb53a
Merge "Restructuring code"
2014-05-05 20:31:38 +00:00
Translation updater bot
d9b52c5318
Localisation updates from https://translatewiki.net .
...
Change-Id: If4468945c2036563c1725ae9f1c1a709148516d0
2014-05-04 20:08:41 +00:00
Translation updater bot
f7f2019055
Localisation updates from https://translatewiki.net .
...
Change-Id: Id24ee8802bd4a355e664a5ed4279fa19bbd3b589
2014-05-01 20:20:27 +00:00
Prateek Saxena
e6f8834841
Restructuring code
...
Bug: 61267
Change-Id: Ie4252c691abb7e6b2637d88b1adea5ce8871497c
2014-04-30 16:48:05 +05:30
Prateek Saxena
0c607321f8
Stop Popups from being generated if extract is empty
...
Bug: 62994
Change-Id: I9c43c572d0290020c7d73fdc061de077bb025299
2014-04-28 13:49:28 +05:30
jenkins-bot
16d7dad834
Merge "Replace animationend with setTimeout"
2014-04-28 08:07:16 +00:00
Prateek Saxena
cb41c8e6ff
Replace animationend with setTimeout
...
Bug: 63253
Change-Id: Id4b998ad88bf27da8114f8194464bea8a11a0504
2014-04-28 13:27:39 +05:30
Translation updater bot
08011a0639
Localisation updates from https://translatewiki.net .
...
Change-Id: I8162365f3a1b4d7dffaa52c6baae29ba7bffc5af
2014-04-24 19:36:54 +00:00
Bartosz Dziewoński
783ae1ead7
Use mw.hook to rebind events after page content is reloaded
...
Also moved things that don't need to be in document-ready handler
outside of it.
Bug: 63169
Change-Id: Ie681ff6722b9909d38fc06359da7614e0fc1798e
2014-04-22 18:53:15 +02:00
Bartosz Dziewoński
49a253cfd7
Extract some magic timeout values
...
Change-Id: Ic4c5a677ca05c4669aa44f0ce03356c19b63f3e7
2014-04-22 16:43:06 +00:00
Bartosz Dziewoński
7dd62d1581
Do not call decodeURI() on non-URIs
...
The title here is not percent-encoded or anything, it's just text.
Calling decodeURI() can cause errors to be thrown if it doesn't happen
to be a valid URI.
Bug: 64236
Change-Id: Iee7c1db0c01cba405f0a2a03b0de58e9edb9a171
2014-04-22 16:42:58 +00:00
Bartosz Dziewoński
26328b3fa0
Always wait at least 150ms before displaying the popup
...
Previously we would wait 150ms if the data was cached,
or 50ms + [API request time] if it was not.
Using some promise magic to achieve this without decreasing
performance. The behavior of sendRequest() was changed a bit.
Bug: 64235
Change-Id: Ibe6e1a5f4ac02f538dac686476ac95ba506a1a86
2014-04-22 16:26:10 +00:00
