Commit graph

2823 commits

Author SHA1 Message Date
Jon Robson 875f7ffcad Use native JavaScript for creating the footer link
The footer link shows when a page preview has been disabled
by an anonymous user via the settings cog.

Change-Id: I236a620322716f42443fc3d90a0405352132a99f
2023-05-15 14:19:41 -07:00
Jon Robson 3bd4275023 Fix test case with type with space in it
Types should not have spaces in them. In the current example this
results in a page preview element with an additional class "<"\'>"
I'm not sure what this is protecting against since we can trust types
to always be in a sensible class friendly form. It would be better
to throw an error in the mw.popups.register function than allow this.

Change-Id: If08c5162c1ca0fc3db4944092231061e22113263
2023-05-15 14:18:39 -07:00
Jon Robson 76973662d1 Fixes: Uncaught TypeError: n.closest is not a function
Previously we did a try/catch when closest didn't exist. Now that's
gone we're flagging this issue.

Follow up to Ia45c03d1fd6949bf83ebed6d40075e453e42cdd7

Bug: T336650
Change-Id: I7a4f453ae1a4a8222863a8342a27d615883d339a
2023-05-15 07:27:22 -07:00
Translation updater bot de881b7e6e Localisation updates from https://translatewiki.net.
Change-Id: Icb38c173922d97885351246571a93b7381576caf
2023-05-15 08:33:35 +02:00
Jon Robson 428c32d027 Switch to native Promises and fetch
For fetch and AbortController we provide native polyfills (see
resources/src/skip-web2017-polyfills.js) so safe to use this here.
This will be empty for modern browsers.

Change-Id: Ic0f55eb0a0276be3587a4b866834bddff1124ad2
2023-05-12 21:34:42 +00:00
Jon Robson 8f03303dc4 Restrict page previews to browsers that support multiple not selectors
Change-Id: Ia45c03d1fd6949bf83ebed6d40075e453e42cdd7
2023-05-12 13:43:18 -07:00
Jon Robson d4376bf203 Load Modules support initialization
Rather than obscurely loading instrumentation code as a side
effect of loading UI code, run it explicitly inside the index.js
initalization code. Instrumentation is moved to its own file
and Popups modules now support an init function.

Change-Id: I9d2643ec8fb4e1dedc7ab9534b2965272f12335f
2023-05-11 23:22:51 +00:00
Translation updater bot 12e823ddbf Localisation updates from https://translatewiki.net.
Change-Id: I9cad95eb5b9c3ab409a250cbc92628bcd19313dc
2023-05-10 08:41:40 +02:00
jenkins-bot 6b8cff5e66 Merge "Fixes flakey test: it should resolve after waiting" 2023-05-10 00:33:09 +00:00
Jon Robson 7ff66a50b0 Fixes flakey test: it should resolve after waiting
Change-Id: I6d63fa2d316af296401eaa3dabee10375e73108b
2023-05-09 10:43:56 -07:00
Volker E c9052a599a storybook: Remove unused reference to 'mediawiki.ui/variables'
Follow-up to If35605e8336c8619c6230bc892b360edbfd16f62

Change-Id: I0a229b86ea7a6b4e804dfe474485d627a2a1ed35
2023-05-06 05:18:05 -07:00
Translation updater bot ec4858119f Localisation updates from https://translatewiki.net.
Change-Id: Id37c76c95dee04c4b136d5d7a3e611725735577d
2023-05-05 10:40:36 +02:00
jenkins-bot 2d4f399689 Merge "ES6: Prefer Object.assign and Promise to jQuery" 2023-05-02 21:37:54 +00:00
Translation updater bot 837ee35ee4 Localisation updates from https://translatewiki.net.
Change-Id: I7412461e6860cfb318ef538f642a52c25f048296
2023-05-01 09:58:28 +02:00
libraryupgrader 12081b5a7b build: Updating mediawiki/mediawiki-phan-config to 0.12.1
Change-Id: Ibe51650df33fc6c57ac7e1174372325b21d3cabd
2023-04-29 09:08:54 +00:00
libraryupgrader 97855ef2f4 build: Updating npm dependencies
* @wikimedia/codex: 0.8.0 → 0.9.1
* @wikimedia/codex-icons: 0.8.0 → 0.9.1
* less: 3.8.1 → 3.13.1

Change-Id: Idb363fba64495430bbc97e044d2047dec450e7cf
2023-04-27 00:25:44 +00:00
Translation updater bot 470fce8cf5 Localisation updates from https://translatewiki.net.
Change-Id: I125aa75fb50f7e4b93ebca10e944a7ad331a77a8
2023-04-24 09:16:58 +02:00
Jon Robson f9b9feaff5 ES6: Prefer Object.assign and Promise to jQuery
Additional change:
* Lint dist folder as ES6 code now ES6 is everywhere

Change-Id: Ie77046f5c6fbdafa4679dbaf97f7bf6f16292b9c
2023-04-19 17:02:14 -07:00
jenkins-bot e13363fa2d Merge "styles: Replace 'mediawiki.ui/variables' call with skin variables" 2023-04-16 10:48:19 +00:00
Jon Robson 2969d67256 Use native JavaScript for event handling
Change-Id: I786d906217ac42f54d498df05b6a172371db7808
2023-04-14 15:39:22 -07:00
gerritbot 5775a5a37f styles: Replace 'mediawiki.ui/variables' call with skin variables
Replacing 'mediawiki.ui/variables.less' @import with
new skin-aware 'mediawiki.skin.variables.less' standard.
Also
- replacing several static values with new Codex design token featuring
  skin variables of `background-color`, `color`, `border-` and
  `opacity` category
- renaming three Less variables to variable naming standard

Please note, that this patch is not replacing all values with
possible Codex tokens. It's just applying them on selected
categories for consistency for now to keep the patch easier reviewable.
Further replacements will be done in follow-up patches.

Bump MediaWiki core required version to >= v1.41.0.

Bug: T332541
Co-Authored-by: Volker E. <volker.e@wikimedia.org>
Change-Id: If35605e8336c8619c6230bc892b360edbfd16f62
2023-04-13 05:31:50 -07:00
Umherirrender 3573232c21 build: Updating npm dependencies
* eslint-config-wikimedia: 0.22.1 → 0.24.0
* @wikimedia/mw-node-qunit: 6.3.3 → 7.0.0

Change-Id: I348eb70bfc6c1d6c922c8290152926183712dee1
2023-04-03 23:14:47 +02:00
Jon Robson ec50f3f6ff Fix storybook integration
Broken by If2b4073115d9082829e4917c87c167d18f5431d9
Change import to directly hit the Codex library
This should also allow web team to respond to Codex upgrades
at their own pace (via package.json)

Render functions must now be registered in storybook for
them to display. Follow up to
Iefe98c1f0422dbf034e385b1a41a859d030a2cf4

Change-Id: Iac9dede15f4de3a4d584f1e505e379764af6dcbf
2023-03-30 15:36:05 -07:00
Umherirrender 5f18164beb build: Updating npm dependencies
* stylelint-config-wikimedia: 0.13.0 → 0.14.0

Run stylelint fix to fix the new stylelint rule

Change-Id: I98f17b481d4ba56a8cd87fcafb1fc2efdaa8abe7
2023-03-28 20:18:47 +00:00
Jon Robson d12c4fe1d8 Don't sync non-existent value
eventlogging reducer was removed in
I640ab367cd235ab8da7dd70dbef7ae9076712e84 so this is syncing
a non-existent value.

Change-Id: I58386bf9a0219f6344c08f757af3aaafbae92751
2023-03-22 19:15:53 +00:00
Jon Robson 24925ec459 Fix storybook integration
Broken by Ie456dfbd703a0e7a0ad783909ca3ef5e86450d9c

Change-Id: I4b6a4817764210cbc4f9ce37be0f117dbc3b656b
2023-03-22 11:39:39 -07:00
Translation updater bot 500e0cd9d1 Localisation updates from https://translatewiki.net.
Change-Id: I549f3820d669da1f7180fa839c044cf7dea0efc6
2023-03-20 09:02:17 +01:00
libraryupgrader 7ccf2f0f3a build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 39.0.0 → 41.0.0
* mediawiki/mediawiki-phan-config: 0.11.1 → 0.12.0

npm:
* eslint: 8.9.0 → 8.31.0
* grunt-banana-checker: 0.9.0 → 0.10.0
* @wdio/mocha-framework: 7.4.6 → 7.30.2
* svg-inline-loader: 0.8.0 → 0.8.2
* decode-uri-component: 0.2.0 → 0.2.2
  * https://github.com/advisories/GHSA-w573-4hg7-7wgq
* deep-object-diff: 1.1.7 → 1.1.9
  * https://github.com/advisories/GHSA-653v-rqx9-j85p
* http-cache-semantics: 4.1.0 → 4.1.1
  * https://github.com/advisories/GHSA-rc47-6667-2j5j
* terser: 4.8.0 → 4.8.1
  * https://github.com/advisories/GHSA-4wf5-vphf-c2xc
  * https://github.com/advisories/GHSA-4wf5-vphf-c2xc
* ua-parser-js: 0.7.31 → 0.7.34
  * https://github.com/advisories/GHSA-fhg7-m89q-25r3

Change-Id: I11c9ba8212c9103e92baa5ebc09f9214b04851ff
2023-03-12 08:46:52 +00:00
Translation updater bot e166673332 Localisation updates from https://translatewiki.net.
Change-Id: Iecb25deb3d4958bd794fc646d80979a0bb962117
2023-03-06 08:34:02 +01:00
Translation updater bot 8356581aef Localisation updates from https://translatewiki.net.
Change-Id: I0ef71b1bcabc2ff9ea4502c3c5d0a847222a923d
2023-03-03 08:48:55 +01:00
Translation updater bot 59ac5636b9 Localisation updates from https://translatewiki.net.
Change-Id: I49cf606f4153541aa0136d22bb6caabb910b4e69
2023-02-28 08:29:28 +01:00
Translation updater bot a01979de92 Localisation updates from https://translatewiki.net.
Change-Id: I081a1a94622b1ad66c23441034680dbbe31d6e8c
2023-02-22 09:01:17 +01:00
Translation updater bot 6ce288409b Localisation updates from https://translatewiki.net.
Change-Id: I86030bc94926e21d443083ffb702c1bb656f8fe4
2023-02-21 08:21:37 +01:00
Jon Robson 11da8483f0 Remove targets definitions and limit page previews to ES6 browsers
I noticed that page previews is currently not working for ES5 users
as ext.maths.popups is an ES6 module which causes the
mw.loader call inside ext.popups/index.js to reject meaning the
feature never gets activated. This was broken in
Iefe98c1f0422dbf034e385b1a41a859d030a2cf4.

I talked to Olga about whether we should restore ES6
support for page previews, and given the recent trend away
from IE11, we decided it made sense to drop page previews
support for ES6 users.

Bug: T328497
Bug: T329901
Change-Id: Icbd683b12c47491eba4de6b5a14afce4465553b9
2023-02-16 13:43:27 -08:00
Translation updater bot 93efdf9b25 Localisation updates from https://translatewiki.net.
Change-Id: I87717f443ec8df622428de4244774641b591f4f2
2023-02-13 08:30:51 +01:00
Translation updater bot fdc90f5e81 Localisation updates from https://translatewiki.net.
Change-Id: I7dda561ed907abbe615718620a10a6d796ce8bc6
2023-02-08 08:40:26 +01:00
Translation updater bot a55c514a10 Localisation updates from https://translatewiki.net.
Change-Id: I88485a14bb22fb4b8af91986c2210fb5ae449dc9
2023-02-06 08:45:54 +01:00
Wandji69 dbcccbae8e styles: Replace deprecated Less mixin calls with unprefixed CSS property
Replacing `.transition()` calls.

Bug: T308351
Change-Id: I6d558f38de81910d701a2e18aeb736a100e5a8ab
2023-02-03 20:39:49 +00:00
jenkins-bot 808f34361b Merge "Expand tests to include hash fragment behaviour" 2023-02-01 11:41:54 +00:00
Jon Robson 119483bdd8 Expand tests to include hash fragment behaviour
Bug: T198652
Change-Id: Ic43883d7092499386df35e6fe049863cbffbe635
2023-01-30 19:25:22 +00:00
Translation updater bot 4171ff0fbf Localisation updates from https://translatewiki.net.
Change-Id: Ie3e32b629b524b01ce922df08c0de66a3e72b53e
2023-01-30 08:30:42 +01:00
Translation updater bot 81b490a5b2 Localisation updates from https://translatewiki.net.
Change-Id: Ib0b48c58fed455448362013ff1a80bb704a93634
2023-01-26 08:52:29 +01:00
jenkins-bot 60abdd1ab6 Merge "Performance: Remove unnecessary requestIdleCallback delay" 2023-01-25 09:50:40 +00:00
jenkins-bot 2a24ffe6ac Merge "Tests: correction to unit test" 2023-01-24 10:57:41 +00:00
Translation updater bot a295898858 Localisation updates from https://translatewiki.net.
Change-Id: I0c35d865144aabe83d79ef0ba71ecbcaecec2d1f
2023-01-24 08:49:32 +01:00
Jon Robson fb0ac8e270 Tests: correction to unit test
Follow up to
Iefe98c1f0422dbf034e385b1a41a859d030a2cf4

Change-Id: Ib3beda14aa3e94def5833082148b7395bc378d74
2023-01-23 10:22:07 -08:00
Translation updater bot 46827f70c6 Localisation updates from https://translatewiki.net.
Change-Id: Ib938b26440f85b59c8acf0864230f2908d4b5451
2023-01-23 08:23:49 +01:00
jenkins-bot 058122e80f Merge "Don't show page previews on hash fragments" 2023-01-18 21:59:53 +00:00
Translation updater bot ca520e8ee0 Localisation updates from https://translatewiki.net.
Change-Id: I19b499cfa35fe9d47d1d02272d693c10cde354c1
2023-01-16 08:29:15 +01:00
Vaughn Walters a7dba1c602 selenium: Remove webdriverio npm package from the Popups extension
The `webdriverio` package does not need to be an explicit dependency.
It is a dependency of `@wdio/cli`.

Bug: T325059
Change-Id: I9d72d936e763dde9bc6d21708bf03fd39ee32ba0
2023-01-13 11:38:43 -06:00