Stephen Niedzielski
4dd9df12eb
Doc: update some of the popups / preview terminology
...
Bug: T165036
Change-Id: Id75543d4d886e4cca8278baaf4f4a21c8e4389b7
2018-03-23 11:18:26 +01:00
Stephen Niedzielski
007cc5ab7c
Hygiene: favor string templates over concatenation
...
Update the ESLint config to favor ES6 strings where variables or string
concatenation is used and fix *all* offenders automatically via:
eslint \
--cache \
--max-warnings 0 \
--report-unused-disable-directives \
--fix \
src tests
Change-Id: I1a9345162348e5ded21d541e7a2ce251ea72ab5a
2018-03-21 08:05:55 -05:00
Stephen Niedzielski
57762e0417
Hygiene: favor const
...
Bug: T165036
Change-Id: I17d374eaac6627ca6a8ba178862b2a9cff2538c0
2018-03-21 10:44:24 +00:00
Stephen Niedzielski
0bee0906d4
Hygiene: replace var with let and const
...
eslint \
--cache \
--max-warnings 0 \
--report-unused-disable-directives \
--fix \
src tests
Change-Id: I051275126ae7fa9affd16c2504017c0584f2d9c7
2018-03-20 14:14:02 -05:00
Stephen Niedzielski
ece4670710
Hygiene: use arrow for anonymous functions
...
In some places, the arrow function seems more natural. This patch
approximates the following with manual amendments:
find \
-not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \
-iname \*.js|
xargs -rd\\n sed -ri 's%function\s*(\([^)]*\))%\1 =>%g'
Files to focus on were identified with:
rg -slg\!/resources/dist/ -g\!/i18n/ -g\!/doc/ 'this|self|arguments|bind|call|apply|new'|
xargs -rd\\n git difftool -y
Bug: T165036
Change-Id: Ic66b6000b8fc000f9bfde39749f9cfa69924a13c
2018-03-20 09:27:08 -05:00
jdlrobson
695a7b6b58
QA: Cleanup unnecessary test changes
...
Various tweaks were made in Ibe212721807d3698dc45ef46b2dbde15ca9d2f70
to get the browser tests to pass. Many of them were unnecessary.
Change-Id: I47ac37512da38a33f4b3b919cc412b79231b0324
2018-03-16 09:53:04 -07:00
jdlrobson
deaaf0961b
Remove popups from critical rendering path
...
Instead load it via mw.loader.using
We retain the module name ext.popups as this will be present
in cached HTML, however now it will load the bulk of the code
inside ext.popups.main
Bug: T176211
Change-Id: Ibe212721807d3698dc45ef46b2dbde15ca9d2f70
2018-03-13 08:44:31 -07:00
Željko Filipin
541a42dd17
Update README file for Selenium tests
...
Bug: T187862
Change-Id: Ib62a6059e8048712617870d07746bee1ab92e371
2018-02-27 14:04:39 +01:00
WMDE-Fisch
4adf63b024
When running Selenium tests, use wd/hub
...
Now it works on Mac, Windows and Linux.
Change-Id: I6ac70e02bc634bb559426baa29dd22f710e554a1
2018-01-18 15:01:01 +01:00
Željko Filipin
b174a6f298
Clean up ESLint configuration
...
parserOptions is redundant sice env is already set to es6.
Bug: T177262
Change-Id: If478a0aaeb7fef184be965645fbd2cb276b630c8
2017-12-22 16:12:54 +01:00
Željko Filipin
c175cffe9b
Fix location of LocalSettings.php
...
It used to be in tests/browser, now it's in tests/selenium.
Bug: T177262
Change-Id: I102c77834f4c63da06fcc6140a28de9dba231ae6
2017-12-19 13:35:46 +01:00
jdlrobson
cf774be88b
Port Popups browser tests to selenium
...
Bug: T177262
Change-Id: Ie77cf7bc79f454904983ed5cf65dc9fe2b1ececc
2017-11-01 13:31:36 -07:00
