wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-15 03:34:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

QA: Cleanup unnecessary test changes

Browse source 
Various tweaks were made in Ibe212721807d3698dc45ef46b2dbde15ca9d2f70
to get the browser tests to pass. Many of them were unnecessary.

Change-Id: I47ac37512da38a33f4b3b919cc412b79231b0324
This commit is contained in:
jdlrobson 2018-03-15 12:24:34 -07:00
parent 6cca20703d
commit 695a7b6b58
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
tests/selenium/pageobjects/popups.page.js
View file

@ -26,6 +26,11 @@ class PopupsPage extends Page {
}
resourceLoaderModuleStatus( moduleName, moduleStatus, errMsg ) {
// Word of caution:
// browser.waitUntil [http://webdriver.io/api/utility/waitUntil.html] returns a Timer class
// (https://github.com/webdriverio/webdriverio/blob/master/lib/utils/Timer.js) NOT a Promise.
// Webdriver IO will run waitUntil synchronously so not returning it will block JavaScript
// execution while returning it will not.
browser.waitUntil( function () {
return browser.execute( function ( module ) {
return mw && mw.loader && mw.loader.getState( module.name ) === module.status;
@ -33,23 +38,22 @@ class PopupsPage extends Page {
}, 10000, errMsg );
}
isReady() {
return this.resourceLoaderModuleStatus( POPUPS_MODULE_NAME, 'ready', 'Page previews did not load' );
ready() {
this.resourceLoaderModuleStatus( POPUPS_MODULE_NAME, 'ready', 'Page previews did not load' );
}
abandonLink() {
browser.moveToObject( '#content h1.firstHeading' );
browser.moveToObject( '#content h1' );
}
dwellLink() {
const PAUSE = 1000;
this.isReady();
this.ready();
browser.pause( PAUSE );
this.abandonLink()
browser.pause( PAUSE );
browser.moveToObject( '#content ul a' );
browser.pause( PAUSE );
browser.waitForExist( POPUPS_SELECTOR, 5000 );
browser.waitForExist( POPUPS_SELECTOR );
}
doNotSeePreview() {