wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-27 17:00:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove/update some ESLint exclusions

Browse source 
Change-Id: Icd4c2d968e2b445a54709368de056373a7814919
This commit is contained in:
Thiemo Kreuz 2021-05-07 10:07:52 +02:00
parent d09d5765e3
commit 8a08a88f66
5 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
resources/dist/index.js.map.json vendored
View file

Binary file not shown.

2
src/index.js
View file

@ -226,7 +226,7 @@ function registerChangeListeners(
mw.user, mw.user,
userSettings, userSettings,
mw.config, mw.config,
// TODO: Is this incompatibility with Firefox 4 intentional? // Probably a false positive. MediaWiki 1.36 dropped Firefox 4 support anyway.
// eslint-disable-next-line compat/compat // eslint-disable-next-line compat/compat
window.location.href window.location.href
); );

2
src/title.js
View file

@ -9,7 +9,7 @@
* @return {boolean} * @return {boolean}
*/ */
function isOwnPageAnchorLink( el ) { function isOwnPageAnchorLink( el ) {
// TODO: Is this incompatibility with Firefox 4 intentional? // Probably a false positive. MediaWiki 1.36 dropped Firefox 4 support anyway.
/* eslint-disable compat/compat */ /* eslint-disable compat/compat */
return el.hash && return el.hash &&
// Note: The protocol is ignored for the sake of simplicity. // Note: The protocol is ignored for the sake of simplicity.

11
src/ui/renderer.js
View file

@ -517,7 +517,16 @@ export function layoutPreview(
); );
} }
// eslint-disable-next-line mediawiki/class-doc // The following classes are used here:
// * flipped-x
// * flipped-x-y
// * flipped-y
// * mwe-popups-fade-in-down
// * mwe-popups-fade-in-up
// * mwe-popups-image-pointer
// * mwe-popups-is-not-tall
// * mwe-popups-is-tall
// * mwe-popups-no-image-pointer
popup.addClass( classes.join( ' ' ) ); popup.addClass( classes.join( ' ' ) );
popup.css( { popup.css( {

4
src/ui/thumbnail.js
View file

@ -161,7 +161,9 @@ export function createThumbnailSVG(
const $thumbnailSVGImage = $( document.createElementNS( nsSvg, 'image' ) ); const $thumbnailSVGImage = $( document.createElementNS( nsSvg, 'image' ) );
$thumbnailSVGImage[ 0 ].setAttributeNS( nsXlink, 'href', url ); $thumbnailSVGImage[ 0 ].setAttributeNS( nsXlink, 'href', url );
// eslint-disable-next-line mediawiki/class-doc // The following classes are used here:
// * mwe-popups-is-not-tall
// * mwe-popups-is-tall
$thumbnailSVGImage $thumbnailSVGImage
.addClass( className ) .addClass( className )
.attr( { .attr( {