From 8a08a88f664f9af5095726ff5cf2183bdba97022 Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Fri, 7 May 2021 10:07:52 +0200 Subject: [PATCH] Remove/update some ESLint exclusions Change-Id: Icd4c2d968e2b445a54709368de056373a7814919 --- resources/dist/index.js.map.json | Bin 209479 -> 209802 bytes src/index.js | 2 +- src/title.js | 2 +- src/ui/renderer.js | 11 ++++++++++- src/ui/thumbnail.js | 4 +++- 5 files changed, 15 insertions(+), 4 deletions(-) diff --git a/resources/dist/index.js.map.json b/resources/dist/index.js.map.json index f52c8d8647af61c1563217f785b6be89f4a4c37d..575bf5d67bca526be776b6b831744304f348c510 100644 GIT binary patch delta 479 zcmX^9gs1B{&xXf^jGmL96dq?R+q|Y|vIt}HW`}lfW=6x!Jzc+8n95T&cl7HqGMaAQ zKEd^~cR*2oQesk0r9z@YT4GLdszO12ab`(oS*o6bZ)!?rVt8hDrh=iKv6(_jQGP)| zYKnqeW>IQdeuaXGLUCz9L4Hw*LSkNJd19sB^lgtA4Y#MYFs3U`FW<_@H~qm{M#bs= zD;YVb&thldmX67bDbd$g&{D`PPt`5RFDNZ2*3B%|ElJGD+5U4WqgfhUm%K$Hc3CMYZ5uWQ%hX(?PDt%qvMPf-9Kb&(0)f59cDQ fhd30QR9?PrCbDVUqj{L#JfmjFZg2R^bleUA8#S%L delta 221 zcmeBr&U5?;&xXf^jINWP6dq?R+PtP{vIwL1W`}lfX2z_|Jzc+8n6#5Ocl7HqGUjdG zKEd^~Wr)9vzmGmIAm?qf)09BP%!~g&Q diff --git a/src/index.js b/src/index.js index 82ed7a1f3..bc3f1be75 100644 --- a/src/index.js +++ b/src/index.js @@ -226,7 +226,7 @@ function registerChangeListeners( mw.user, userSettings, mw.config, - // TODO: Is this incompatibility with Firefox 4 intentional? + // Probably a false positive. MediaWiki 1.36 dropped Firefox 4 support anyway. // eslint-disable-next-line compat/compat window.location.href ); diff --git a/src/title.js b/src/title.js index c9e96615e..67dcdcc01 100644 --- a/src/title.js +++ b/src/title.js @@ -9,7 +9,7 @@ * @return {boolean} */ function isOwnPageAnchorLink( el ) { - // TODO: Is this incompatibility with Firefox 4 intentional? + // Probably a false positive. MediaWiki 1.36 dropped Firefox 4 support anyway. /* eslint-disable compat/compat */ return el.hash && // Note: The protocol is ignored for the sake of simplicity. diff --git a/src/ui/renderer.js b/src/ui/renderer.js index beb63a041..3ae1cf30f 100644 --- a/src/ui/renderer.js +++ b/src/ui/renderer.js @@ -517,7 +517,16 @@ export function layoutPreview( ); } - // eslint-disable-next-line mediawiki/class-doc + // The following classes are used here: + // * flipped-x + // * flipped-x-y + // * flipped-y + // * mwe-popups-fade-in-down + // * mwe-popups-fade-in-up + // * mwe-popups-image-pointer + // * mwe-popups-is-not-tall + // * mwe-popups-is-tall + // * mwe-popups-no-image-pointer popup.addClass( classes.join( ' ' ) ); popup.css( { diff --git a/src/ui/thumbnail.js b/src/ui/thumbnail.js index b98760432..dc279534b 100644 --- a/src/ui/thumbnail.js +++ b/src/ui/thumbnail.js @@ -161,7 +161,9 @@ export function createThumbnailSVG( const $thumbnailSVGImage = $( document.createElementNS( nsSvg, 'image' ) ); $thumbnailSVGImage[ 0 ].setAttributeNS( nsXlink, 'href', url ); - // eslint-disable-next-line mediawiki/class-doc + // The following classes are used here: + // * mwe-popups-is-not-tall + // * mwe-popups-is-tall $thumbnailSVGImage .addClass( className ) .attr( {