mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-23 15:16:50 +00:00
Fiy a few small typos in the Popups documentation
Change-Id: I0f02a41977eef0e1bf8fe4fc924c32e17ef78dd7
This commit is contained in:
parent
22226f3367
commit
096c74fae8
|
@ -1,4 +1,4 @@
|
|||
![Popups](images/popups.svg)
|
||||
![Popups](./popups.svg)
|
||||
|
||||
# mediawiki/extensions/Popups
|
||||
|
||||
|
|
|
@ -19,7 +19,7 @@ experience slowdown when loading many files.
|
|||
|
||||
There are many tools that bundle JavaScript out there that can do this for us.
|
||||
|
||||
** Pros **
|
||||
**Pros**
|
||||
* mw.popups no longer needs to be exposed as a global object
|
||||
* Dependency management is no longer a manual process but automated by webpack
|
||||
* Would allow us to explore template pre-compiling
|
||||
|
|
|
@ -21,7 +21,7 @@ creators](http://redux.js.org/docs/api/bindActionCreators.html), i.e.
|
|||
```javascript
|
||||
mw.popups.changeListeners.foo = function ( boundActions ) {
|
||||
var $link = $( '<a>' )
|
||||
.attr( 'href': '#' )
|
||||
.attr( 'href', '#' )
|
||||
.click( boundActions.showSettings );
|
||||
|
||||
return function ( prevState, state ) {
|
||||
|
|
|
@ -17,7 +17,7 @@ Since the event data varies with the value of the `action` property, events are
|
|||
|
||||
When enqueuing and logging an event, data flows between the reducer and the change listener as follows:
|
||||
|
||||
1. The state is initialized to `null`..
|
||||
1. The state is initialized to `null`.
|
||||
2. An event is enqueued by the reducer as a result of an action.
|
||||
3. The change listener sees that the state tree has changed and logs the queued event via `mw.eventLog.Schema#log`.
|
||||
4. The change listener dispatches the `EVENT_LOGGED` action.
|
||||
|
|
Loading…
Reference in a new issue