diff --git a/README.md b/README.md index 4cfc04d2b..8e5b638c7 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -![Popups](images/popups.svg) +![Popups](./popups.svg) # mediawiki/extensions/Popups diff --git a/docs/adr/0004-use-webpack.md b/docs/adr/0004-use-webpack.md index e7e927c75..5b9e7086e 100644 --- a/docs/adr/0004-use-webpack.md +++ b/docs/adr/0004-use-webpack.md @@ -19,7 +19,7 @@ experience slowdown when loading many files. There are many tools that bundle JavaScript out there that can do this for us. -** Pros ** +**Pros** * mw.popups no longer needs to be exposed as a global object * Dependency management is no longer a manual process but automated by webpack * Would allow us to explore template pre-compiling diff --git a/docs/change_listener.md b/docs/change_listener.md index 50f3da6f2..215dc823c 100644 --- a/docs/change_listener.md +++ b/docs/change_listener.md @@ -21,7 +21,7 @@ creators](http://redux.js.org/docs/api/bindActionCreators.html), i.e. ```javascript mw.popups.changeListeners.foo = function ( boundActions ) { var $link = $( '' ) - .attr( 'href': '#' ) + .attr( 'href', '#' ) .click( boundActions.showSettings ); return function ( prevState, state ) { diff --git a/docs/instrumentation.md b/docs/instrumentation.md index 4e539bb19..bb18ceac2 100644 --- a/docs/instrumentation.md +++ b/docs/instrumentation.md @@ -17,7 +17,7 @@ Since the event data varies with the value of the `action` property, events are When enqueuing and logging an event, data flows between the reducer and the change listener as follows: -1. The state is initialized to `null`.. +1. The state is initialized to `null`. 2. An event is enqueued by the reducer as a result of an action. 3. The change listener sees that the state tree has changed and logs the queued event via `mw.eventLog.Schema#log`. 4. The change listener dispatches the `EVENT_LOGGED` action.