2018-12-11 17:23:05 +00:00
|
|
|
![Popups](./popups.svg)
|
2018-03-27 19:12:12 +00:00
|
|
|
|
2017-02-13 13:33:18 +00:00
|
|
|
# mediawiki/extensions/Popups
|
|
|
|
|
|
|
|
See https://www.mediawiki.org/wiki/Extension:Popups for more information about
|
|
|
|
what it does.
|
|
|
|
|
|
|
|
## Development
|
|
|
|
|
|
|
|
Popups uses an asset bundler so when developing for the extension you'll need
|
2017-02-13 14:02:18 +00:00
|
|
|
to run a script to assemble the frontend assets.
|
|
|
|
|
|
|
|
You can find the frontend source files in `src/`, the compiled sources in
|
|
|
|
`resources/dist/`, and other frontend assets managed by resource loader in
|
|
|
|
`resources/*`.
|
|
|
|
|
|
|
|
After an `npm install`:
|
2017-02-13 13:33:18 +00:00
|
|
|
|
2017-02-01 11:09:42 +00:00
|
|
|
* On one terminal, kickstart the bundler process:
|
2018-03-14 16:39:54 +00:00
|
|
|
* `npm start` Will run the bundler in watch mode, re-assembling the files on
|
2018-06-27 22:44:04 +00:00
|
|
|
file change. Additionally, this builds debug-friendly assets and enables
|
|
|
|
[Redux DevTools] debugging.
|
2018-03-14 16:39:54 +00:00
|
|
|
* `npm run build` Will compile the assets just once, ready for deployment. You
|
|
|
|
*must* run this step before sending the patch or CI will fail (so that
|
|
|
|
sources and built assets are in sync).
|
2017-02-01 11:09:42 +00:00
|
|
|
* On another terminal, run tests and linting tools:
|
2018-03-14 16:39:54 +00:00
|
|
|
* `npm test` To run the linting tools and the tests.
|
|
|
|
* You can find the QUnit tests that depend on running MediaWiki under
|
|
|
|
`tests/qunit/`
|
|
|
|
* You can find the isolated QUnit tests under `tests/node-qunit/`, which you
|
2019-01-24 15:29:27 +00:00
|
|
|
can run with `npm run test:unit`
|
2018-03-14 16:39:54 +00:00
|
|
|
* We recommend you install a file watcher like `nodemon` to watch sources and
|
|
|
|
auto run linting and tests.
|
|
|
|
* `npm install -g nodemon`
|
|
|
|
* Example running linting and node unit tests:
|
2019-01-24 15:29:27 +00:00
|
|
|
* `nodemon -w src/ --exec "grunt lint:all && npm run test:unit"`
|
2018-03-14 16:39:54 +00:00
|
|
|
* Get code coverage report with `npm run coverage`
|
|
|
|
* Reports printed in the `coverage/` folder
|
2018-03-07 20:15:30 +00:00
|
|
|
|
|
|
|
Developers are likely to work with local MediaWiki instances that do not have
|
|
|
|
content to test with. To reduce this pain, you can create a single page with
|
|
|
|
a list of links that point to an existing and external wiki by using the
|
|
|
|
following config flag:
|
|
|
|
|
2018-03-14 16:39:54 +00:00
|
|
|
$wgPopupsGateway = 'restbaseHTML';
|
|
|
|
$wgPopupsRestGatewayEndpoint = 'https://en.wikipedia.org/api/rest_v1/page/summary/';
|
|
|
|
|
|
|
|
Popups works with a local copy of the [Mobile Content Service] too:
|
|
|
|
|
|
|
|
$wgPopupsGateway = 'restbaseHTML';
|
|
|
|
$wgPopupsRestGatewayEndpoint = 'http://localhost:6927/en.wikipedia.org/v1/page/summary/';
|
|
|
|
|
2018-06-27 22:44:04 +00:00
|
|
|
[Redux DevTools]: https://chrome.google.com/webstore/detail/redux-devtools/lmhkpmbekcpmknklioeibfkpmmfibljd
|
2018-03-14 16:39:54 +00:00
|
|
|
[Mobile Content Service]: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/mobileapps/+/master
|
2018-03-20 20:20:43 +00:00
|
|
|
|
2018-06-27 22:44:04 +00:00
|
|
|
## Debugging
|
|
|
|
|
|
|
|
* Popups are dismissed ("abandoned") when the cursor leaves the popup
|
|
|
|
container. As such, it can be difficult to debug a popup of interest
|
|
|
|
without it popping in and out of the DOM. A useful workaround in
|
|
|
|
DevTools is to context click a link, select inspect, move the cursor
|
|
|
|
some place comfortable, and then from the console enter
|
|
|
|
`$($0).trigger('mouseenter')`.
|
|
|
|
* As described in [[#Development]], `npm start` enables Redux DevTools
|
|
|
|
functionality. In production builds, this same functionality can be
|
|
|
|
enabled by setting a `debug=true` query. E.g.,
|
|
|
|
`https://en.wikipedia.org/wiki/Popup?debug=true`.
|
|
|
|
|
2018-12-12 23:08:38 +00:00
|
|
|
## Storybook.js Component Library
|
|
|
|
|
|
|
|
The root of the repository contains a .storybook directory. This folder contains
|
|
|
|
a separate NPM project using the [Storybook.js](https://storybook.js.org/) UI framework.
|
|
|
|
This framework provides an environment that showcases all possible permutations of popups,
|
|
|
|
without the state-management constraints of having only one popup per page.
|
|
|
|
|
|
|
|
This framework requires Node v8 (because of the spread `...` operator) and is therefore
|
|
|
|
separated from the main package.json until CI upgrades from Node v6. NVM can be used to
|
|
|
|
manage multiple Node versions to run the Storybook app (`cd .storybook && nvm use`).
|
|
|
|
See the .storybook/README.md for details.
|
|
|
|
|
2018-03-20 20:20:43 +00:00
|
|
|
## Terminology
|
|
|
|
|
2019-01-21 10:24:33 +00:00
|
|
|
* Footnote - What the Cite extension shows at the bottom of the page.
|
2018-06-27 22:44:04 +00:00
|
|
|
* Hovercard - Deprecated term for popup.
|
|
|
|
* Link preview - A similar user feature in the Android native app.
|
|
|
|
* Navpop / nav pop - A popup-like UI from the NavigationPopups gadget.
|
|
|
|
* Popup - Generic term for a dialog that appears to float above a link that is
|
2018-03-20 20:20:43 +00:00
|
|
|
being hovered over by a cursor.
|
2018-06-27 22:44:04 +00:00
|
|
|
* Page preview - A specific type of popup that shows a page summary.
|
|
|
|
* Preview - A synonym for popup.
|
2019-01-21 10:24:33 +00:00
|
|
|
* Reference - A specific type of popup that previews the Cite extension's
|
|
|
|
footnotes. Since footnotes are typically used for references, and the tag's
|
|
|
|
name is `<ref>`, the terms are used synonymously.
|