wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-28 09:20:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Popups/package.json

59 lines
2 KiB
JSON
Raw Normal View History

build: Configure banana-checker and jsonlint Change-Id: Id3f1d601f6b99e9646c7a1c6b430b1dd777e952b
2015-06-20 05:09:03 +00:00
{
"private": true,
"scripts": {
Hygiene: use source-maps for dev builds not eval maps Webpack's `-d` option is an alias for `--debug --devtool cheap-module-eval-source-map --output-pathinfo`[0] which overrode the `devtool` specified in the config. Specify `--mode=development` which appears to be better supported than `-d`, although the distinction is poorly documented[1]. The build products are identical for `--mode=development --debug --output-pathinfo` and simply `--mode=development` so the latter is used. For consistency, replace `-p`, an alias for `--optimize-minimize --define process.env.NODE_ENV=production`[0], where `--optimize-minimize` is documented[2] as: Minimize JavaScript and switches loaders to minimizing UglifyJsPlugin and LoaderOptionsPlugin. With `--mode=production` which is documented[3] as: Sets process.env.NODE_ENV on DefinePlugin to value production. Enables FlagDependencyUsagePlugin, FlagIncludedChunksPlugin, ModuleConcatenationPlugin, NoEmitOnErrorsPlugin, OccurrenceOrderPlugin, SideEffectsFlagPlugin and UglifyJsPlugin. This change has already been made to MobileFrontend in c10f87d89. [0] https://webpack.js.org/api/cli/#shortcuts [1] https://medium.com/webpack/webpack-4-released-today-6cdb994702d4#dfa8 [2] https://webpack.js.org/api/cli/#optimize-options [3] https://webpack.js.org/concepts/mode/#usage Change-Id: I7a7ffc913592f0b18e091bb219a7fc75873d4d7a
2018-10-05 16:30:08 +00:00
"start": "webpack -w --mode=development",
"build": "NODE_ENV=production webpack --mode=production",
Add eslint auto-fixing to Gruntfile Run `npm run lint:fix` to use Change-Id: I445c17a57b5f240ddaa48956d7881cc3228eab76
2018-03-27 19:43:14 +00:00
"lint:fix": "grunt fix",
Hygiene: replace tap-dot reporter The tap-dot executable crashes on some test failure outputs.[0] This is confusing since a test failure in itself often requires debugging. The issue is present from v1.0.1 to the latest, v2.0.0. Instead of downgrading, replace tap-dot with the popular tap-mocha-reporter. This change comes with a bonus: console.log is no longer filtered out. The benefit cannot be overstated. [0]: https://github.com/scottcorgan/tap-dot/issues/9 Change-Id: I4ce2d2816885b7c5214f5c1863be595be0d8b1aa
2018-06-27 14:15:08 +00:00
"test:node": "node tests/node-qunit/run.js 'tests/node-qunit/**/*.test.js' | tap-mocha-reporter dot",
Hygiene: don't auto-add on pre-commit Since it can be unexpected for a pre-commit hook to make edits to the commit, leverage the existing tests to simply verify that the proper files have been staged. This also slightly simplifies the existing NPM scripts and forces the dev to run the same test about to be executed CI, `npm test` itself, which previously had no other automation tie in. Change-Id: I74e407ea17a6c2809a49ba56d3ef28b25d5ba5de
2018-05-01 18:40:05 +00:00
"test": "npm -s run check-built-assets && grunt lint && npm -s run coverage && npm -s run -s doc && bundlesize",
doc: Replace JSDuck v5.3.4 with JSDoc v3.4.3 JSDoc can handle ES2015 modules whereas JSDuck can't. Regardless of however many features JSDuck has that JSDoc mightn't [0], we can't use JSDuck to document this codebase. [0] T138401 Bug: T158236 Change-Id: I8da712075dd28f6b228c96fa9577ca39eb148fb5
2017-05-19 11:28:35 +00:00
"doc": "jsdoc -c jsdoc.json",
Update package.json to ensure assets get built on every commit diffs now correctly output errors. This will pick up changes to index.js and index.js.json that have not been committed --exit-code is passed to ensure that if there are changes then an error is thrown and the action is not allowed. The dist folder became out of date as depending on what version of node you run, the output is different. To aid debugging, the script that checks the diff now outputs the node version and the npm version. From now on, we will all have to use the same node version to build assets. This is annoying, but we will re-evaluate the approach we are taking to build assets in T202743. We can easily work around this by all using nvm and making consistent use of the same node version. The assets have been rebuilt with the node version that CI uses. Bug: T202748 Change-Id: I82aee879d4b04ca06447f95eb81230bfc24d20e9
2018-08-28 21:33:54 +00:00
"node-debug": "node -v && npm -v && echo 'Please ensure you are running the correct version of nvm before running this command.'",
"check-built-assets": "echo 'CHECKING BUILD SOURCES ARE COMMITTED OR STAGED' && npm -s run build && git diff --exit-code resources/dist || { npm run node-debug; false; }",
Fix: code coverage Replace Istanbul with nyc, Istanbul's CLI. nyc appears to have some bugs that this patch works around: - When all files in the project are considered, not just those imported via tests, the coverage rates and line numbers vary between runs. This patch disables the `all` option for now and points to the bug: https://github.com/istanbuljs/nyc/issues/537#issuecomment-390814662. - Source map line numbers appear to be incorrect except when `all` is enabled and working correctly (see previous bullet). - `sourceMap` must be disabled to avoid ENAMETOOLONG errors when nyc tries to include them as encoded strings. The patch disables the setting and points to: https://github.com/istanbuljs/nyc/issues/847. Using babel-plugin-istanbul and source-map-support appears to have no effect (the former in tests/node-qunit/run.js and .babelrc). - CI fails with `Error: EACCES: permission denied, mkdir '/nonexistent'`. Specify `SPAWN_WRAP_SHIM_ROOT` instead of constructing a subdirectory from a nonexistent home directory. Bug: T196952 Bug: T193519 Change-Id: Idf2e3accd4a6277cbef91c1156fcd206c9e7d882
2018-06-18 18:36:48 +00:00
"coverage": "SPAWN_WRAP_SHIM_ROOT=\"$PWD/.nyc_output\" nyc npm -s run test:node",
Selenium: add selenium-daily NPM script The script is needed to run the new Docker-based Jenkins job that runs daily and targets beta cluster. selenium-test script and NPM packages are dependencies. selenium-daily now just calls selenium-test. selenium-daily might seem redundant, but it provides flexibility. In case a repository does not want to run all tests daily, that's easily fixed by updating the selenium-daily script. Bug: T188742 Change-Id: I35c93ff1897afc4b9e66703a1acf765e3fe7b643
2018-07-31 16:04:12 +00:00
"precommit": "npm -s t",
"selenium-daily": "npm run selenium-test",
"selenium-test": "wdio tests/selenium/wdio.conf.js"
build: Configure banana-checker and jsonlint Change-Id: Id3f1d601f6b99e9646c7a1c6b430b1dd777e952b
2015-06-20 05:09:03 +00:00
},
Update package.json to ensure assets get built on every commit diffs now correctly output errors. This will pick up changes to index.js and index.js.json that have not been committed --exit-code is passed to ensure that if there are changes then an error is thrown and the action is not allowed. The dist folder became out of date as depending on what version of node you run, the output is different. To aid debugging, the script that checks the diff now outputs the node version and the npm version. From now on, we will all have to use the same node version to build assets. This is annoying, but we will re-evaluate the approach we are taking to build assets in T202743. We can easily work around this by all using nvm and making consistent use of the same node version. The assets have been rebuilt with the node version that CI uses. Bug: T202748 Change-Id: I82aee879d4b04ca06447f95eb81230bfc24d20e9
2018-08-28 21:33:54 +00:00
"engines": {
"node": "6.11.0"
},
build: Configure banana-checker and jsonlint Change-Id: Id3f1d601f6b99e9646c7a1c6b430b1dd777e952b
2015-06-20 05:09:03 +00:00
"devDependencies": {
Switch from babel-preset-env to @babel/preset-env Replace: - babel-preset-env@1.6.0 with @babel/preset-env@7.2.0 - babel-register@6.24.1 with @babel/register@7.0.0 - babel-loader@7.1.4 with babel-loader@8.0.4 Add: - @babel/core@7.2.0 --- - babel-preset-env, @babel/preset-env babel-preset-env moved to @babel/preset-env in the Babel monorepo. This appears to have incremented the version from v1.6.0[0] to 7.x to match the rest of the Babel packages but appears to otherwise be undocumented.[1,3] [0] https://github.com/babel/babel-preset-env/blob/24b99ec/README.md [1] https://github.com/babel/babel/blob/efa571a/CHANGELOG.md - @babel/preset-env, @babel/register *Many* changes as identified by package [2] and summarized [3]. Node.js v6 or above now required. New dependency on @babel/core. Support for ES2018 and browserslist v4. `modules: false` is now the default for preset-env + babel-loader. The .babelrc has been updated. New babel-upgrade tool. babel.config.js can replace .babelrc. Popups doesn't seem to need it. TypeScript and JSX fragment support. [2] https://github.com/babel/babel/blob/efa571a/CHANGELOG.md [3] https://babeljs.io/blog/2018/08/27/7.0.0 - babel-loader Support for Babel 7.x. The following warning is printed when building but perhaps this is due to another dependency: (node:14559) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils. https://github.com/webpack/loader-utils/issues/56#issuecomment-286117000 https://github.com/babel/babel-loader/releases/tag/v7.1.5 https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.0 https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.1 https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.2 https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.3 https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.4 (v8.0.0-beta.5 was erroneous.) https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.6 https://github.com/babel/babel-loader/releases/tag/v8.0.0 https://github.com/babel/babel-loader/releases/tag/v8.0.1 https://github.com/babel/babel-loader/releases/tag/v8.0.2 https://github.com/babel/babel-loader/releases/tag/v8.0.3 https://github.com/babel/babel-loader/releases/tag/v8.0.4 Bug: T197883 Change-Id: Ie3a5404630fde87ea7fe618a842950ed8c0c6494
2018-12-03 10:08:49 +00:00
"@babel/core": "7.2.0",
"@babel/preset-env": "7.2.0",
"@babel/register": "7.0.0",
Hygiene: update mw-node-qunit dependency package mw-node-qunit has moved to a new NPM package, @wikimedia/mw-node-qunit. There are no functional changes with this release but dependencies should be kept up to date. https://github.com/wikimedia/mw-node-qunit/blob/9a368a1/CHANGELOG.md#500 Bug: T197251 Change-Id: I25bfc541551cbc29812985df7fa05dc17f0338c5
2018-06-28 22:33:27 +00:00
"@wikimedia/mw-node-qunit": "5.0.0",
Switch from babel-preset-env to @babel/preset-env Replace: - babel-preset-env@1.6.0 with @babel/preset-env@7.2.0 - babel-register@6.24.1 with @babel/register@7.0.0 - babel-loader@7.1.4 with babel-loader@8.0.4 Add: - @babel/core@7.2.0 --- - babel-preset-env, @babel/preset-env babel-preset-env moved to @babel/preset-env in the Babel monorepo. This appears to have incremented the version from v1.6.0[0] to 7.x to match the rest of the Babel packages but appears to otherwise be undocumented.[1,3] [0] https://github.com/babel/babel-preset-env/blob/24b99ec/README.md [1] https://github.com/babel/babel/blob/efa571a/CHANGELOG.md - @babel/preset-env, @babel/register *Many* changes as identified by package [2] and summarized [3]. Node.js v6 or above now required. New dependency on @babel/core. Support for ES2018 and browserslist v4. `modules: false` is now the default for preset-env + babel-loader. The .babelrc has been updated. New babel-upgrade tool. babel.config.js can replace .babelrc. Popups doesn't seem to need it. TypeScript and JSX fragment support. [2] https://github.com/babel/babel/blob/efa571a/CHANGELOG.md [3] https://babeljs.io/blog/2018/08/27/7.0.0 - babel-loader Support for Babel 7.x. The following warning is printed when building but perhaps this is due to another dependency: (node:14559) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils. https://github.com/webpack/loader-utils/issues/56#issuecomment-286117000 https://github.com/babel/babel-loader/releases/tag/v7.1.5 https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.0 https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.1 https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.2 https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.3 https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.4 (v8.0.0-beta.5 was erroneous.) https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.6 https://github.com/babel/babel-loader/releases/tag/v8.0.0 https://github.com/babel/babel-loader/releases/tag/v8.0.1 https://github.com/babel/babel-loader/releases/tag/v8.0.2 https://github.com/babel/babel-loader/releases/tag/v8.0.3 https://github.com/babel/babel-loader/releases/tag/v8.0.4 Bug: T197883 Change-Id: Ie3a5404630fde87ea7fe618a842950ed8c0c6494
2018-12-03 10:08:49 +00:00
"babel-loader": "8.0.4",
Upgrade bundlesize, clean-webpack-plugin, grunt-contrib-watch, nyc The following upgrades were made: bundlesize | 0.15.3 | 0.17.0 clean-webpack-plugin | 0.1.19 | 1.0.0 grunt-contrib-watch | 1.0.1 | 1.1.0 nyc | 12.0.2 | 13.1.0 These potentially breaking changes were listed for nyc (but were not observed): * "--hook-run-in-context, and --hook-run-in-this-context are no longer true by default (they should be enabled if you're using a library like requirejs)."[1] [1] https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md#breaking-changes Bug: T209314 Change-Id: Iaf705d4e6cdde1e3d3103f1c154a8fb172815535
2018-12-13 02:55:07 +00:00
"bundlesize": "0.17.0",
"clean-webpack-plugin": "1.0.0",
Upgrade elint-config-wikimedia (drop eslint-plugin-qunit) The following upgrade was made: eslint-config-wikimedia | 0.8.1 | 0.9.0 The upgrade of eslint-config-wikimedia removes the need of eslint-plugin-qunit as a peerDependency because it is now a hard dependency [1] so it was removed in our package.json. It appears the biggest change in the upgrade was the use of separate profiles [2]. Given this, our root .eslintrc.json was updated to extend from 'wikimedia/client'. Several test files were flagged by the upgraded linter and were fixed in this patch. Additionally, our build file was flagged for having too many statements on one line. This rule was turned off in .eslintrc.es5.json [1] https://github.com/wikimedia/eslint-config-wikimedia/blob/master/package.json#L48 [2] https://github.com/wikimedia/eslint-config-wikimedia/blob/master/CHANGELOG.md#090--2018-11-19 Bug: T209314 Change-Id: I29db72e77f04a327bc9c2b558c6d53849287bb80
2018-12-13 03:09:26 +00:00
"eslint-config-wikimedia": "0.9.0",
build: Update linters Bug: T202739 Change-Id: Ie3f68977598f46f7e12b216f8381b2e9dc6d83ad
2018-09-11 11:53:15 +00:00
"grunt": "1.0.3",
build: Update eslint and other linters Change-Id: I0a20ad5d16d46afbc2a328f8e254295972f58ab0
2017-10-09 14:56:15 +00:00
"grunt-banana-checker": "0.6.0",
Upgrade bundlesize, clean-webpack-plugin, grunt-contrib-watch, nyc The following upgrades were made: bundlesize | 0.15.3 | 0.17.0 clean-webpack-plugin | 0.1.19 | 1.0.0 grunt-contrib-watch | 1.0.1 | 1.1.0 nyc | 12.0.2 | 13.1.0 These potentially breaking changes were listed for nyc (but were not observed): * "--hook-run-in-context, and --hook-run-in-this-context are no longer true by default (they should be enabled if you're using a library like requirejs)."[1] [1] https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md#breaking-changes Bug: T209314 Change-Id: Iaf705d4e6cdde1e3d3103f1c154a8fb172815535
2018-12-13 02:55:07 +00:00
"grunt-contrib-watch": "1.1.0",
build: Update linters Bug: T202739 Change-Id: Ie3f68977598f46f7e12b216f8381b2e9dc6d83ad
2018-09-11 11:53:15 +00:00
"grunt-eslint": "21.0.0",
Remove jshint/jscs, add eslint and stylelint ...with the wikimedia presets. For automatically fixing most of the JS lint problems run grunt eslint:fix Some rules of stylelint were disabled given they cause problems with existing popups code (like no id selectors for example). Change-Id: I2153047c3ddbea50572dd329989088bb20787515
2016-12-16 11:11:54 +00:00
"grunt-jsonlint": "1.1.0",
build: Update linters Bug: T202739 Change-Id: Ie3f68977598f46f7e12b216f8381b2e9dc6d83ad
2018-09-11 11:53:15 +00:00
"grunt-stylelint": "0.10.1",
build: Bring SVGO optimization to build step Enabling SVGO automation with 'grunt-svgmin' and conservative plugin settings to build step, among those: - enable removeRasterImages and sortAttrs, - disable cleanupIDs, removeDesc, removeTitle, & removeViewBox as described in https://www.mediawiki.org/wiki/Manual:Coding_conventions/SVG#Exemplified_safe_configuration - disable removeXMLProcInst; if the SVG doesn't start with an XML declaration, then it's MIME type will be detected as "text/plain" rather than "image/svg+xml" by libmagic and, consequently, MediaWiki's CSSMin CSS minifier. libmagic's default database currently requires that SVGs contain an XML declaration: <https://github.com/threatstack/libmagic/blob/master/magic/Magdir/sgml#L5>. - make use of pretty and multipass options. Settings are stored in a JSON file to be independent of the Grunt build process. Also updating SVG accordingly. Bug: T185596 Change-Id: I715ad4cf2e900665e4c32c78b4c2d9d9cebf0222
2018-02-12 19:36:32 +00:00
"grunt-svgmin": "5.0.0",
Fix: JSDoc Node.js file copy bug Upgrade JSDoc from v3.4.3 to 3.5.5: - v3.5.0 JSDoc can parse any JavaScript that is supported by Babel compiler. - v3.5.1 fixes an incompatibility bug in Node.js < v5.10.0 - v3.5.5 fixes an incompatibility bug in Node.js v8.5.0 Prior to this change, object shorthand caused the following errors: jsdoc -c jsdoc.json fs.js:1979 binding.copyFile(src, dest, flags); ^ Error: EISDIR: illegal operation on a directory, copyfile '/home/stephen/dev/wmf/vagrant2/mediawiki/extensions/Popups/node_modules/jsdoc/templates/default/static/fonts/OpenSans-Bold-webfont.eot' -> 'doc/autogenerated/fonts' at Object.fs.copyFileSync (fs.js:1979:11) at /home/stephen/dev/wmf/vagrant2/mediawiki/extensions/Popups/node_modules/jsdoc/templates/default/publish.js:471:12 at Array.forEach (<anonymous>) at Object.exports.publish (/home/stephen/dev/wmf/vagrant2/mediawiki/extensions/Popups/node_modules/jsdoc/templates/default/publish.js:468:17) at Object.module.exports.cli.generateDocs (/home/stephen/dev/wmf/vagrant2/mediawiki/extensions/Popups/node_modules/jsdoc/cli.js:430:39) at Object.module.exports.cli.processParseResults (/home/stephen/dev/wmf/vagrant2/mediawiki/extensions/Popups/node_modules/jsdoc/cli.js:383:20) at module.exports.cli.main (/home/stephen/dev/wmf/vagrant2/mediawiki/extensions/Popups/node_modules/jsdoc/cli.js:227:14) at Object.module.exports.cli.runCommand (/home/stephen/dev/wmf/vagrant2/mediawiki/extensions/Popups/node_modules/jsdoc/cli.js:180:5) at /home/stephen/dev/wmf/vagrant2/mediawiki/extensions/Popups/node_modules/jsdoc/jsdoc.js:103:9 at Object.<anonymous> (/home/stephen/dev/wmf/vagrant2/mediawiki/extensions/Popups/node_modules/jsdoc/jsdoc.js:104:3) at Module._compile (module.js:662:30) at Object.Module._extensions..js (module.js:673:10) at Module.load (module.js:575:32) at tryModuleLoad (module.js:515:12) at Function.Module._load (module.js:507:3) at Function.Module.runMain (module.js:703:10) https://github.com/jsdoc3/jsdoc/releases/tag/3.5.0 https://github.com/jsdoc3/jsdoc/releases/tag/3.5.1 https://github.com/jsdoc3/jsdoc/releases/tag/3.5.2 https://github.com/jsdoc3/jsdoc/releases/tag/3.5.3 https://github.com/jsdoc3/jsdoc/releases/tag/3.5.4 https://github.com/jsdoc3/jsdoc/releases/tag/3.5.5 Bug: T165036 Change-Id: Ic7a22b6992d45fa0ea3d011a9ad5200d7cc73b80
2018-03-20 13:46:06 +00:00
"jsdoc": "3.5.5",
Upgrade bundlesize, clean-webpack-plugin, grunt-contrib-watch, nyc The following upgrades were made: bundlesize | 0.15.3 | 0.17.0 clean-webpack-plugin | 0.1.19 | 1.0.0 grunt-contrib-watch | 1.0.1 | 1.1.0 nyc | 12.0.2 | 13.1.0 These potentially breaking changes were listed for nyc (but were not observed): * "--hook-run-in-context, and --hook-run-in-this-context are no longer true by default (they should be enabled if you're using a library like requirejs)."[1] [1] https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md#breaking-changes Bug: T209314 Change-Id: Iaf705d4e6cdde1e3d3103f1c154a8fb172815535
2018-12-13 02:55:07 +00:00
"nyc": "13.1.0",
Replace husky dependency with pre-commit MobileFrontend uses the npm package 'pre-commit' to execute pre-commit hooks but Popups was using 'husky'. This commit rectifies that for consistency. Bug: T209314 Change-Id: I56e841d6dc6739ffe040cb930ddf0ebce3905a9f
2018-12-13 03:29:00 +00:00
"pre-commit": "1.2.2",
Upgrade redux / redux-thunk redux | 3.6.0 | 4.0.1 redux-thunk | 2.2.0 | 2.3.0 Upgrading these two dependencies caused the build size to increase from from 12.2 KB to 12.4 KB (gzip) and so the bundlesize was adjusted accordingly in our package.json. Additionally, our linters flagged two rules that were then turned off in .eslintrc.es5.json. Looks like the changes in Redux were mostly cosmetic with much work dedicated to typescript definitiions and dropping support of private imports [1]. The changes to redux-thunk only involved changing typescript typings and should not affect us. [2] The upgrade was tested locally and did not appear to break anything. [1] https://github.com/reduxjs/redux/issues/1342#issue-130452197 [2] https://github.com/reduxjs/redux-thunk/releases/tag/v2.3.0 Bug: T209314 Change-Id: I35284793ca0c72914d9b9b2e7c28dd407bafd4d8
2018-12-13 06:41:12 +00:00
"redux": "4.0.1",
"redux-thunk": "2.3.0",
Upgrade stylelint-config-wikimedia and remove stylelint The following upgrade was made: stylelint-config-wikimedia | 0.4.3 | 0.5.0 The upgraded version stylelint-config-wikimedia includes stylelint as a dependency (no longer a peer dependency) [1] so our stylelint dependency was removed. As a result of this upgrade, several of our .less files were flagged by the linter and corrected in this patch. [1] https://github.com/wikimedia/stylelint-config-wikimedia/blob/v0.5.0/package.json#L36 Bug: T209314 Change-Id: Ic6d4b1caf60f4e03fa60076a2ae74d6639117f25
2018-12-13 03:14:09 +00:00
"stylelint-config-wikimedia": "0.5.0",
Hygiene: move SVG string to file - Add SVG Inline Loader for Webpack. This allows SVG files to be imported. - Update the Webpack and test configurations to use the new loader. - Scope the ESLint rules down to just JavaScript files so that linting isn't attempted on the SVG. Bug: T165036 Change-Id: I00bccff4c3167975c19d577be6343dcaca7ddb2d
2018-03-07 19:53:09 +00:00
"svg-inline-loader": "0.8.0",
Hygiene: replace tap-dot reporter The tap-dot executable crashes on some test failure outputs.[0] This is confusing since a test failure in itself often requires debugging. The issue is present from v1.0.1 to the latest, v2.0.0. Instead of downgrading, replace tap-dot with the popular tap-mocha-reporter. This change comes with a bonus: console.log is no longer filtered out. The benefit cannot be overstated. [0]: https://github.com/scottcorgan/tap-dot/issues/9 Change-Id: I4ce2d2816885b7c5214f5c1863be595be0d8b1aa
2018-06-27 14:15:08 +00:00
"tap-mocha-reporter": "3.0.7",
QA: add missing wdio-junit-reporter tests/selenium/wdio.conf.js defines a Junit reporter but it is not installed when running the suite directly from the extension. Bug: T203591 Change-Id: Idf192506d0af01abbfea479223a3bbcfc5eef4ea
2018-09-06 14:04:24 +00:00
"wdio-junit-reporter": "0.4.4",
Selenium: add selenium-daily NPM script The script is needed to run the new Docker-based Jenkins job that runs daily and targets beta cluster. selenium-test script and NPM packages are dependencies. selenium-daily now just calls selenium-test. selenium-daily might seem redundant, but it provides flexibility. In case a repository does not want to run all tests daily, that's easily fixed by updating the selenium-daily script. Bug: T188742 Change-Id: I35c93ff1897afc4b9e66703a1acf765e3fe7b643
2018-07-31 16:04:12 +00:00
"wdio-mediawiki": "0.2.0",
Upgrade webdriverio / wdio-spec-reporter wdio-mocha-framework | 0.6.1 | 0.6.3 wdio-spec-reporter | 0.1.4 | 0.1.5 webdriverio | 4.13.1 | 4.14.1 Selenium tests were tested locally with these upgrades and passed. Note: I had some difficulty in upgrading wdio-mocha-framework to the latest version 0.6.4 on my mac os (10.14) and experienced a `'utility' file not found` error when npm installed the 'fibers' package. This appears to be a known problem relating to node-gyp and older versions of node. [1] Running the following suggested command [2] worked for me: `CXXFLAGS="-mmacosx-version-min=10.9" LDFLAGS="-mmacosx-version-min=10.9" npm i` However, it was a hassle. Therefore, I chose to upgrade to only 0.6.3 in which this problem doesn't occur. [1] https://github.com/nodejs/node-gyp/issues/1564 [2] https://github.com/nodejs/node-gyp/issues/1564#issuecomment-436609523 Bug: T209314 Change-Id: I0657ca5db4747b4ebb7aa0d01e2aeb97d6b2a7d0
2018-12-13 04:54:22 +00:00
"wdio-mocha-framework": "0.6.3",
"wdio-spec-reporter": "0.1.5",
"webdriverio": "4.14.1",
Upgrade webpack / webpack-cli webpack | 4.1.1 | 4.27.1 webpack-cli | 2.0.12 | 3.1.2 The upgrade of webpack modified our build files and included these side effects: * Our linter flagged the usage of bitwise operators in the build files so I turned that off in our build file lint config (.eslintrc.es5.json) * Our build file's size increased slightly from 12.1 KB to 12.13 KB (gzip) so the package.json's bundlesize was updated accordingly. No deleterious effects were noticed to popups running locally, but the jump in webpack version included these notable changes: * Switch from uglify-es to terser minimizer [1] [1] https://github.com/webpack/webpack/releases/tag/v4.26.0 The upgrade for webpack-cli was a major version jump, but the params that we pass to it in our package.json file appear to work as before. Bug: T209314 Change-Id: I1403f2c4d354cf54554a740f8c23176bf80fd3c6
2018-12-13 06:01:01 +00:00
"webpack": "4.27.1",
"webpack-cli": "3.1.2"
Hygiene: add bundlesize test This patch adds a production build output gzipped file size check to the test script so that any future changes may only introduce known size differences. Note: • The initial limit was taken from the present gzipped file size rounded up to the 10th of a kibibyte. • JEDEC notation is used. bundlesize internally uses Bytes utility which only supports base 2 units. https://github.com/visionmedia/bytes.js Bug: T176211 Change-Id: Ie95f388673b0b982b105fef9a2917513a3307060
2018-01-30 17:02:46 +00:00
},
"bundlesize": [
{
"path": "resources/dist/index.js",
Upgrade redux / redux-thunk redux | 3.6.0 | 4.0.1 redux-thunk | 2.2.0 | 2.3.0 Upgrading these two dependencies caused the build size to increase from from 12.2 KB to 12.4 KB (gzip) and so the bundlesize was adjusted accordingly in our package.json. Additionally, our linters flagged two rules that were then turned off in .eslintrc.es5.json. Looks like the changes in Redux were mostly cosmetic with much work dedicated to typescript definitiions and dropping support of private imports [1]. The changes to redux-thunk only involved changing typescript typings and should not affect us. [2] The upgrade was tested locally and did not appear to break anything. [1] https://github.com/reduxjs/redux/issues/1342#issue-130452197 [2] https://github.com/reduxjs/redux-thunk/releases/tag/v2.3.0 Bug: T209314 Change-Id: I35284793ca0c72914d9b9b2e7c28dd407bafd4d8
2018-12-13 06:41:12 +00:00
"maxSize": "12.4KB"
Hygiene: add bundlesize test This patch adds a production build output gzipped file size check to the test script so that any future changes may only introduce known size differences. Note: • The initial limit was taken from the present gzipped file size rounded up to the 10th of a kibibyte. • JEDEC notation is used. bundlesize internally uses Bytes utility which only supports base 2 units. https://github.com/visionmedia/bytes.js Bug: T176211 Change-Id: Ie95f388673b0b982b105fef9a2917513a3307060
2018-01-30 17:02:46 +00:00
}
]
build: Configure banana-checker and jsonlint Change-Id: Id3f1d601f6b99e9646c7a1c6b430b1dd777e952b
2015-06-20 05:09:03 +00:00
}
Reference in a new issue Copy permalink