In I845694d4f2109a8b9125410e8533ca69bbea50fa we changed the format of
parser tests using the 'property' option. This updates the parser
tests in PageImages to the new format used for metadata in parser tests
(in this case, adding `!! metadata` sections).
Depends-On: I845694d4f2109a8b9125410e8533ca69bbea50fa
Change-Id: Ia7060c9bfcdebe9783ea48d429442bcdbaac459e
PageImages::getPropNames can return either array or string,
and PageProps::getProperties accepts both.
But the latter's return value will be different depending
on the type of input: with an array as input, the returned
array's values will be an associative array where the index
is the propname; with a string, it's just the propvalue.
This difference matters because the code below assumes an
array with propname keys.
Bug: T323152
Change-Id: I422951ec0cd5c651b32c65e88a557d49f2f22712
Size is not a useful (and thus far, unused) value that
is expensive to compute & we want to get rid of.
Let's not expect any particular value (or it even
existing) because that may not remain true for much longer.
Bug: T323125
Change-Id: I20d5c4358e225be7759ed38afb2267d6f811fa34
The default thumbnail size (SearchResultThumbnailProvider::THUMBNAIL_SIZE),
the code to build a SearchResultThumbnail object from a File object
(SearchResultThumbnailProvider::buildSearchResultThumbnailFromFile),
and the code that provides thumbnails from NS_FILE pages (now already
provided in the hook's $results param) have essentially been adopted
in core and no longer need to be handled here.
Also updated test to reflect that NS_FILE results will no longer be
provided by this extension (since core already provides them)
Depends-On: I2a679b51758020d3e822da01a1bde1ae632b0b0a
Change-Id: I2eafc8556022432929973755d8cd76010ea24f39
Bug: T306883
The return value of ParserOutput::getPageProperty() has transitioned
to returning `null` instead of `false` when the page property is missing.
Bug: T301915
Depends-On: Iaa25c390118d2db2b6578cdd558f2defd5351d15
Change-Id: Ie746883bd14eb579b40390d5fe824a5c6f93fa1e
The return value of ParserOutput::getPageProperty() will transition to
returning `null` instead of `false` when the page property is missing.
Bug: T301915
Change-Id: I383abb6b7dc5e96c0061af13957609f6e31a1065
Including regression test for T299798.
Bug: T299798
Depends-On: Idc4ac4eb4e20d8e3e2fdbd093ff75f26d3af0d57
Change-Id: I89fa346651e756d1981a950a8b778020359b86a2
I added ParserModifyImageHTML to core to make it easier for PageImages
to identify images in the lead section.
This also allows PageImages to stop writing to LinksUpdate properties.
It is one of only two extensions that do that.
Depends-On: I24528381e8d24ca8d138bceadb9397c83fd31356
Bug: T176520
Bug: T296895
Change-Id: I472f4a023969bfde6298eb56112c16d2ae842199
SearchResultPageIdentityValue will become an alias for
PageIdentityValue, which requires the forth parameter.
Needed-By: I6eb55c78a0a72be66814f8bc854ba663e7c6f62b
Change-Id: I9b1ab02e0acf12ace107361ea2c443aa543c4880
Replace instances of "blacklist" with "denylist" throughout extension.
Bug: T277955
Depends-On: Ib4985ec2fcb22eafad8f3a7cf9fc3161782a71db
Change-Id: Ibe460cb9691d56a9e83686b53c7629b5404af6fb
* any() doesn't do anything. It's the default anyway.
* Prefer the more strict assertSame() where possible.
* Use shortcuts like createMock() where possible.
Change-Id: Iff33f111312448e9fc8ff827e2ef9eb2b583ff6f
As we switch ParserCache to JSON, we can no longer serialized
class instances in extension data. PageImages was writing the
full set of properies it received from Parser into it's extension
data, some of which are sometimes class instances. Instead, only
write the nessessary subset of data into extension-data.
This change is completely forward and backward compatible.
Since before this change we were already writing the same array,
but with many additional unused properties.
Bug: T266251
Change-Id: Ieb4a139465159611e6b3a99c4b68c3c174b1944f
* Images on pages can be localized (eg. SVG text)
* Allow API consumers to select the language the images are rendered in
Bug: T257082
Change-Id: I05f498444c55aea9028a58de80e21ba1e236bf02
