wikimedia/mediawiki-extensions-PageImages
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/PageImages synced 2024-11-15 03:43:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

rest: Verify that file exists before calling filesize

Browse source 
Bug: T252128
Change-Id: I2de87d723fdd99bea0f1dadd23648470759a103e
This commit is contained in:
Peter Ovchyn 2020-05-07 19:29:51 +03:00
parent 34f54dd1ad
commit 6e004092ca
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/Hooks/SearchResultProvideThumbnailHookHandler.php
View file

@ -92,7 +92,9 @@ class SearchResultProvideThumbnailHookHandler {
if ( !$thumb ) {
continue;
}
$thumbSize = $thumb->getLocalCopyPath() ? filesize( $thumb->getLocalCopyPath() ) : null;
$localPath = $thumb->getLocalCopyPath();
$thumbSize = $localPath && file_exists( $localPath ) ? filesize( $localPath ) : null;
$res[$pageId] = new SearchResultThumbnail(
$thumb->getFile()->getMimeType(),

2
tests/phpunit/Hooks/SearchResultProvideThumbnailHookHandlerTest.php
View file

@ -35,7 +35,7 @@ class SearchResultProvideThumbnailHookHandlerTest extends MediaWikiTestCase {
] )
->getMock();
$thumbnail->expects( $this->exactly( $thumbFilePath ? 2 : 1 ) )
$thumbnail->expects( $this->once() )
->method( 'getLocalCopyPath' )
->willReturn( $thumbFilePath );