Commit graph

411 commits

Author SHA1 Message Date
jenkins-bot 7009da69fa Merge "Add phan" 2019-03-08 20:21:48 +00:00
Umherirrender 5682f9c0e2 Use ::class for class name resolution
Available since php5.5

Change-Id: Iaaffa6b0f3c1314c575b5f46f729c8a2b2630107
2019-03-02 17:50:46 +01:00
Umherirrender 6e81389a00 Add phan
Change-Id: Ib50452c57c9ca2256d22a9952d932bb9b577e3b1
2019-02-28 21:33:10 +01:00
Umherirrender 272b98a34c Pass string as field to IDatabase::selectField
It is documented as string, because it can only select one field,
not a list of fields

Change-Id: Id3e51bdc12a2abea16e4963ea95caf7f9213f853
2019-02-28 21:21:11 +01:00
libraryupgrader 50511d6fa8 build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Change-Id: I4ca4095d2c4c3bf18dfae0bb92f993ecefaeee0f
2019-02-07 02:23:14 +00:00
Translation updater bot 4139477986 Localisation updates from https://translatewiki.net.
Change-Id: Id8a9b0b3dd4aa1431bc979c8c2754b80df60adcf
2019-01-28 22:27:11 +01:00
Thiemo Kreuz 71b5c4db22 Relax score calculation in LinksUpdateHookHandler to use floats
This allows to use floats in the $wgPageImagesScores configuration.
Before, decimal places have just been cut off with no warning. I find
this pretty unexpected. When I see the terminology "score" being used,
I always think of float values. I checked all the code that consumes
these scores (it is all internal to LinksUpdateHookHandler), and it's
all fine with floats. I don't see a reason to forcefully cut decimal
places off.

Bug: T212013
Change-Id: I0f1f0ea0865f07b3e58a2fc142dcd838eb687c97
2019-01-10 09:31:20 +01:00
Thiemo Kreuz 0fd9a2b5f4 Fix score calculation in LinksUpdateHookHandler failing on unordered input
This patch is motivated by Iad694e0.

* I rearranged the code a little bit to avoid a duplicate line of code.
* I added a ksort() and a comment explaining it.
* Additional tests demonstrate why the ksort() is needed.
* I had to refactor the tests a little bit to allow for more test cases
  that have been missing before.

Bug: T212013
Change-Id: Ia96dc8c6cf57ddcea410a7300756d0013052ac79
2019-01-10 09:26:54 +01:00
jenkins-bot 835af0936b Merge "Don't use non-images as candidates, e.g. audio files from a <gallery>" 2019-01-09 20:09:33 +00:00
Thiemo Kreuz ba066df1e2 Don't use non-images as candidates, e.g. audio files from a <gallery>
Bug: T212013
Change-Id: Ibed6effb7b46d420264730f4ec2b11c34c0159f4
2019-01-09 13:12:38 +01:00
Thiemo Kreuz baabc300ba Remove bogus @doc… elements from default $wgPageImagesScores setting
Such @doc… keys are not allowed at this level. They make it to the code
and cause confusion there. I added a test case for an edge case where this
really causes wrong results.

Bug: T212013
Change-Id: Ib391e5639ef5a34f9ee44f8c19b99e1dd19207bc
2019-01-09 12:41:21 +01:00
Kunal Mehta b058df99b8 build: Set "root": true, in .eslintrc.json
This ensures that each repository's "npm test" command is fully
independent of wherever it might be in the filesystem.

Bug: T206485
Change-Id: I81139c50ce9cde87ecf4b52ad688719735d1f154
2018-12-17 18:57:17 -08:00
Translation updater bot d72b10c9fd Localisation updates from https://translatewiki.net.
Change-Id: Icea18eb246bae52183a528535c812dd1ae87ee5d
2018-12-07 22:21:44 +01:00
libraryupgrader 1d5e35277f build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Change-Id: I9f0706406568dc51eb8af8db2ed80feefdbe294d
2018-11-16 06:37:25 +00:00
Translation updater bot 989be21df0 Localisation updates from https://translatewiki.net.
Change-Id: I3ed18b46cb117dc779aef6536b65c9c043d0e0af
2018-11-10 22:28:23 +01:00
Translation updater bot 652070938e Localisation updates from https://translatewiki.net.
Change-Id: I0b010a12dec291b252c15c79018dc4bd4dc0436f
2018-11-04 22:42:28 +01:00
Translation updater bot 47aa8bf497 Localisation updates from https://translatewiki.net.
Change-Id: Iaaa9091e0a1aeb52b40b4a33766aedf69f498848
2018-11-03 11:03:15 +01:00
libraryupgrader 8ba6afb479 build: Updating npm dependencies for security issues
* Updated grunt to 1.0.3, addressing:
  * https://npmjs.com/advisories/577
  * CVE-2018-3721

Change-Id: I8534f5e4820b74977399a4b76632d20587c0a0a3
2018-10-11 10:05:09 +00:00
Peter Boehm cd2115f80d Reenable Indexing for Images
PageImages returned no images, found the solution here:
https://www.mediawiki.org/w/index.php?title=Topic:Txp3e225prn7u8mf&topic_showPostId=uf6ic04q8nneq
- thanks to the anonymous helper

Bug: T203965
Change-Id: I6a024d27edf9060f7bf3ffb0d51761b0a86f6696
2018-09-26 23:36:40 +00:00
Fomafix 16b5cfd18e Start showing warning for deprecated PHP entry point
Change-Id: I657672b9eb49a4313bbde5dd8aadfff015182a50
2018-09-11 06:47:43 +02:00
libraryupgrader 672a9fd309 build: Updating mediawiki/phan-taint-check-plugin to 1.5.0
Change-Id: I425f35b7ac9ccfdb20080a8492ad0bed78097607
2018-09-08 04:27:54 +00:00
libraryupgrader 1d629c73d8 build: Updating mediawiki/mediawiki-codesniffer to 22.0.0
Change-Id: If9f0d1d185f177228981319650addf2b0f11a919
2018-09-03 06:48:54 +00:00
libraryupgrader d6d4d73d7c build: Updating mediawiki/phan-taint-check-plugin to 1.4.0
Change-Id: I43ba5bf117eb13b1ebca5093983f726619d85a42
2018-09-01 12:32:04 +00:00
jenkins-bot e716b5c13f Merge "Remove backward usage of ApiBase::dieUsage" 2018-08-20 01:03:58 +00:00
libraryupgrader 89dda946d3 build: Updating mediawiki/phan-taint-check-plugin to 1.3.0
And updating CoC link to use Special:MyLanguage (T202047).

Change-Id: I79a19af4eff16b2283e9673fe77ca8f2c9b8ed53
2018-08-19 14:57:59 +00:00
Umherirrender da5312fb70 Remove backward usage of ApiBase::dieUsage
ApiBase::dieUsage is deprecated since 1.29, this extension required
1.29

Change-Id: Ide05c1dc6a92708deaf859e6963b607194133b5d
2018-08-18 15:53:42 +00:00
Translation updater bot 9a63080018 Localisation updates from https://translatewiki.net.
Change-Id: I0124fa5b7f5f16767973651c54166ef17d95d6c1
2018-08-06 22:22:19 +02:00
Kunal Mehta c211b57ba5 Configure phan-taint-check-plugin
The plugin checks and flags potential security issues (XSS, SQLi, etc.)
using static analysis.

See <https://www.mediawiki.org/wiki/Phan-taint-check-plugin> for more
details.

Bug: T201219
Change-Id: Ie3157955183a1810ff18c48f6a42ba3fe2ed3d1a
2018-08-03 21:22:56 -07:00
libraryupgrader cf82413701 build: Updating mediawiki/mediawiki-codesniffer to 21.0.0
Change-Id: I278138cb74d1686a801b3a2a295ef82e0c92e862
2018-07-27 11:55:05 +00:00
Kunal Mehta 494c9b53c0 Stop setting PAGE_IMAGES_INSTALLED
Callers should check with ExtensionRegistry instead.

Bug: T200381
Depends-On: I0b9725fa4b3c4ce4fbb1004cfd3570ba39865fc1
Depends-On: Ib9a480396fc28358e681f749f80800c9bab4e0d0
Change-Id: Ibe4384238161edc8d40cff5e2a532fb36ecec64d
2018-07-25 18:20:55 -07:00
Translation updater bot c60c2bd307 Localisation updates from https://translatewiki.net.
Change-Id: Ia5049ec1348fcb685758820417ca21a77220ffa8
2018-07-05 22:43:57 +02:00
Translation updater bot ede605b746 Localisation updates from https://translatewiki.net.
Change-Id: I13f3e836003e7ecb9e62b059d565e1f054f60bf9
2018-06-27 22:19:52 +02:00
Translation updater bot 95894d76b3 Localisation updates from https://translatewiki.net.
Change-Id: I596497f1af2571414eccc0e5308074888485a4b5
2018-06-24 22:25:54 +02:00
libraryupgrader eaead3c305 build: Updating mediawiki/mediawiki-codesniffer to 20.0.0
Change-Id: I20229e891f2ea5985a515fb1e6176c88b2d23fa8
2018-05-26 05:23:03 +00:00
Kunal Mehta a9ad31c7f8 Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag issues
Change-Id: I3b0c14dcd5961254d49a98df4061f8ff83589f3a
2018-05-24 21:42:59 -07:00
jenkins-bot 7afb479887 Merge "Remove backward compatibility code for 1.25" 2018-04-28 20:50:57 +00:00
Translation updater bot 6888263807 Localisation updates from https://translatewiki.net.
Change-Id: Ie5729d4213b920289c904bb8426de566cc9900dc
2018-04-25 22:38:50 +02:00
Umherirrender ebbfdf7a1b Remove backward compatibility code for 1.25
Extension requires 1.29 in extension.json
ApiResult::META_CONTENT exists since 1.25

Change-Id: Ibdbabf628975b277b2d3cc01e5b8ff12116fb97d
2018-04-25 22:01:49 +02:00
Umherirrender fd0d231a3c Remove backward compatibility code for 1.25
Extension requires 1.29 in extension.json

Change-Id: Ie58a10402c207fa097eedd760b22a891d0a8cc78
2018-04-25 21:46:58 +02:00
jenkins-bot 3633c216cb Merge "Adjust InitImageDataJob" 2018-04-20 22:58:50 +00:00
Kunal Mehta 34b0dd5ff6 Unbreak test that only worked by accident, and fails on PHP 7.2
`$leadImages || $images` will return a boolean, it doesn't work like
JavaScript or Python. Use `?:` to implement what was wanted.

This only worked because `count( true ) === 1`. Using assertCount()
would have caught it also.

Change-Id: I11357b23ad1124ed96d863872014cdca7c59e284
2018-04-13 22:25:26 -07:00
libraryupgrader ded0ca4290 build: Updating mediawiki/mediawiki-codesniffer to 18.0.0
Change-Id: I266801663a036db96a03ee026abbb78f34941c27
2018-04-13 22:20:36 -07:00
Kunal Mehta b138993e96 Properly specify method that will be mocked
Change-Id: I2bb3b586727a4a7c52f4fd8813f87d0a4e7c5952
2018-04-13 22:20:17 -07:00
Umherirrender bc4b81c7bb Adjust InitImageDataJob
$params cannot a bool here
Job::run has to return a bool

Change-Id: Ieed6675e8de0e3ed4c3376676d5b027a6ab9f4f2
2018-04-10 19:11:55 +00:00
Translation updater bot 848c07a762 Localisation updates from https://translatewiki.net.
Change-Id: I339bf731ecee6e995b504024ad6952f310c9770a
2018-04-09 23:17:05 +02:00
Umherirrender 2db7a8728e Migrate call to Http::get to use options for timeout
Since 1.25 the timeout is part of the options array.
Also added the caller for profiling

Change-Id: I111b1a0199f8a5fd0bfcfb490717861757f1d496
2018-04-05 10:14:50 +02:00
jenkins-bot 5b60adad39 Merge "Add later-than option to PageImages InitImageData maitenance script" 2018-04-03 17:44:46 +00:00
Piotr Miazga 9f605c75bc Add later-than option to PageImages InitImageData maitenance script
Bug: T152252
Change-Id: Ie4f416dce9e4703f55a0dbbcb72ae6a30554b8c1
2018-04-03 19:21:12 +02:00
Translation updater bot ca4e635b8d Localisation updates from https://translatewiki.net.
Change-Id: I9752d4037841bfdd4f96b26f451dbca26392a88f
2018-04-01 09:38:53 +02:00
libraryupgrader 534b1df71b build: Updating mediawiki/mediawiki-codesniffer to 17.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.LicenseComment.InvalidLicenseTag

Change-Id: Ieade4ff304a47e9900e7d2a97bdd2edf534524b6
2018-03-29 04:37:56 +00:00