Commit graph

1486 commits

Author SHA1 Message Date
Translation updater bot 7290062aef Localisation updates from https://translatewiki.net.
Change-Id: I0e1bf7537ce449b60fca061571f63856f22f0430
2022-04-04 09:34:50 +02:00
gerritbot 3f5f7f6db9 Fix usage of ApiBase::PARAM_* deprecated constants
The ones that are replaced with ParamValidator

Bug: T275455
Change-Id: Id4800f82472f859d1a725fd98ec1007600ccd369
2022-04-04 01:28:34 +02:00
Reedy b5a762d7fe Rename oauthauth-ui-no-module
Change-Id: I23a05cd04756b87d0a97db32ddedc1ea8af0c1b7
2022-04-02 21:39:07 +00:00
jenkins-bot 710361fada Merge ""OATHUserRepository: Stop handling legacy single-key" take 2" 2022-04-01 15:47:27 +00:00
Translation updater bot 7b4cb85502 Localisation updates from https://translatewiki.net.
Change-Id: If07423b4ecf4b0d4e4202d63c6d6c40d763f7e7b
2022-04-01 08:27:14 +02:00
Reedy 81b69d625a "OATHUserRepository: Stop handling legacy single-key" take 2
This reverts commit 851656bbdf.

Change-Id: I80b20d6105a1f34834a4b60f215313fd53b0195a
2022-03-31 20:46:08 +00:00
Translation updater bot 15196bc1e4 Localisation updates from https://translatewiki.net.
Change-Id: Ia0aca926538c38a315efa0a5070c4ba7760983c1
2022-03-31 08:36:10 +02:00
jenkins-bot 7f97014390 Merge "Revert "OATHUserRepository: Stop handling legacy single-key"" 2022-03-30 12:28:58 +00:00
Zabe 851656bbdf Revert "OATHUserRepository: Stop handling legacy single-key"
This reverts commit 6898d6ba93.

Reason for revert: the transition is apparently not completed yet

Bug: T305029
Change-Id: Ie5079b25bf4403da7bbe9aaa927f40190904bf20
2022-03-30 12:17:36 +00:00
Translation updater bot 54371e9072 Localisation updates from https://translatewiki.net.
Change-Id: Iad8096217327197547d7947e3d9646dcf005dadd
2022-03-30 08:18:27 +02:00
Reedy 0535912298 OATHUser: Annotate that getModule() can return null
Change-Id: I83e34a9b1b58956b10af099668177ce426937b58
2022-03-29 13:45:22 +01:00
Reedy 7c4649ce37 ApiOATHValidate: Fix example passing TOTP token in data
Change-Id: Idee5685cbf69e4d6dfe4e03e109a0523bc94784f
2022-03-29 12:12:14 +01:00
Translation updater bot 1a92eef0bf Localisation updates from https://translatewiki.net.
Change-Id: I3b96bf1bbf95f46a7955ace3fa4f445b36cf1c02
2022-03-29 08:06:00 +02:00
Translation updater bot 4faabe76b5 Localisation updates from https://translatewiki.net.
Change-Id: I37943a2b3846dae741c5c5834ea5f8faba1ca784
2022-03-28 08:21:35 +02:00
Reedy 6898d6ba93 OATHUserRepository: Stop handling legacy single-key
Migration is handled by UpdateTables::switchTOTPToMultipleKeys()

The transition has been completed at WMF as well.

Bug: T304375
Change-Id: I0e6d30075dfbd66d692cd8a5e3f7c9ebf44bc065
2022-03-26 09:44:55 +00:00
jenkins-bot 1ee5f486d6 Merge "OATHUserRepository: Remove some legacy handling" 2022-03-25 20:44:02 +00:00
Reedy 22505f73ae OATHUserRepository: Remove some legacy handling
The migration from `oathauth_users.secret` to `oathauth_users.module`
was added in I71286534d21d950834. It resides now in the UpdateTables
class, which runs from the LoadExtensionSchemaUpdates hook.

The transition has been completed at WMF as well.

Bug: T304375
Change-Id: I5fa88704c6da2ae2679a19e0c5a2cfe7f3bf5f50
2022-03-25 20:38:16 +00:00
Translation updater bot 1b6ed147d7 Localisation updates from https://translatewiki.net.
Change-Id: Iab3beb8db6aabbf4058815a2394d3e239b4423b5
2022-03-25 08:35:09 +01:00
Translation updater bot 9606a8f679 Localisation updates from https://translatewiki.net.
Change-Id: I36c3607874a56f9754676f691dabda84d4f269fd
2022-03-24 08:34:59 +01:00
Translation updater bot feb4ae190e Localisation updates from https://translatewiki.net.
Change-Id: I0ffd4e269fcff02c3f7c36071b9d9ea42ec5ab63
2022-03-22 08:29:50 +01:00
Reedy 6adc5ecabf Remove unused $key variables from foreach()
Change-Id: Ib035ff7fc3eeeb73b6f870b226775d61b3caee11
2022-03-21 23:58:03 +00:00
Alexander Vorwerk 248d2bb8d6 Disable user only after it has been removed from the db
OATHUser::disable sets the 'module' value to null, but
OATHUserRepository::remove reads that value, in order to add the type
to the log entry, resulting in fatals.

Bug: T304350
Change-Id: Ied622f1ba65bfabad3f048dbca885e4dadab0907
2022-03-21 21:50:20 +00:00
Alexander Vorwerk bd8bb22ecd Revert "Explicitly specify SQL columns to SELECT"
This reverts commit 6f37618f4f.

We are later calling isLegacy and that is checking whether
'secret' is set, but due to the change in the select,
'secret' is never set, breaking the functionality of isLegacy().

Change-Id: Ic2c53dca6d1b1608192a5722408f157505187092
2022-03-21 19:11:42 +00:00
Translation updater bot 81ece94b9d Localisation updates from https://translatewiki.net.
Change-Id: I7906b17770bf9e45b4b8014f60018c66d3a92a84
2022-03-21 08:15:06 +01:00
Translation updater bot 0f3ec513fb Localisation updates from https://translatewiki.net.
Change-Id: I01803540ade12679c1b1ca00b42bb9f0764c46b3
2022-03-18 08:45:09 +01:00
Translation updater bot ead1dde666 Localisation updates from https://translatewiki.net.
Change-Id: Id7b58b44a21542e4d60da2ec664475f6dd95528d
2022-03-17 08:37:26 +01:00
Translation updater bot 4410eb9da0 Localisation updates from https://translatewiki.net.
Change-Id: I5fda7e98750dbbfd2b521ad611c21f70c10a2535
2022-03-16 08:07:59 +01:00
jenkins-bot 3043b1eb75 Merge "Send a notification when 2FA is enabled" 2022-03-15 18:32:59 +00:00
Translation updater bot 5b6921caca Localisation updates from https://translatewiki.net.
Change-Id: Id282f9cefbd7e474e3d8b9431af57c77aa138ea2
2022-03-14 08:14:25 +01:00
Translation updater bot e96bd2e768 Localisation updates from https://translatewiki.net.
Change-Id: I8a5e1c889432085ceef61d9e6eb3a77241ba26bb
2022-03-10 08:19:31 +01:00
Translation updater bot 792e6f10d4 Localisation updates from https://translatewiki.net.
Change-Id: I32369421add4f351fbfb9f4b76372463831b618f
2022-03-09 08:09:51 +01:00
Translation updater bot 2978eba304 Localisation updates from https://translatewiki.net.
Change-Id: I48113b595c0f3b46ef19215f55114b24c4e29598
2022-03-07 08:11:22 +01:00
Translation updater bot 3f2d81f837 Localisation updates from https://translatewiki.net.
Change-Id: Ice717fdf645285750e92224028abbe52c756638c
2022-03-03 08:22:58 +01:00
Translation updater bot abdf3584c0 Localisation updates from https://translatewiki.net.
Change-Id: Ie94bc63e21e8394d3c725a863c11551d38787577
2022-02-28 14:29:08 +01:00
jenkins-bot caee0f788b Merge "Explicitly specify SQL columns to SELECT" 2022-02-28 07:36:04 +00:00
jenkins-bot e3624a3b8a Merge "Add basic tests for TOTPKey" 2022-02-28 07:32:29 +00:00
Kunal Mehta 6f37618f4f Explicitly specify SQL columns to SELECT
...instead of `SELECT *`, in anticipation of future schema changes.
Notably, we didn't need to select the `id` field, since we don't ever
use it (spotted by Thiemo!).

Change-Id: I1089199bdad70401684377d88877eccc689427f9
2022-02-27 23:15:50 -08:00
Kunal Mehta ba39a4dfa8 Add basic tests for TOTPKey
Mostly I wanted to add tests for verifying serialization and
deserialization, since that's what I modify in my next commit.

Change-Id: I8223f2e3e1b3ce79afc8c5cd9ca4afe6d418abf9
2022-02-27 23:01:58 -08:00
Translation updater bot a458752222 Localisation updates from https://translatewiki.net.
Change-Id: I7771da37eaed44691782976168fba716ba2f19b2
2022-02-25 09:44:51 +01:00
Reedy 211c1cb930 Replace usages of Wikimedia\(suppress|restore)Warnings()
Change-Id: Iac7480957819652d487e177bc9caf0c8c3db83e4
2022-02-24 21:18:30 +00:00
Translation updater bot e3ef5d1619 Localisation updates from https://translatewiki.net.
Change-Id: I3cde834312cd4208580b32f6b7b85f98f60c1e50
2022-02-24 08:49:40 +01:00
Reedy 16bc5d7168 Send a notification when 2FA is enabled
Bug: T301987
Change-Id: I0fe32b735e34753442ec9811ea41d15b76999d87
2022-02-24 00:39:37 +00:00
jenkins-bot be665c93cc Merge "SECURITY: Use constant time checks for token values" 2022-02-23 23:07:22 +00:00
Translation updater bot fa6acfbc17 Localisation updates from https://translatewiki.net.
Change-Id: Icc0870102ede8c370457e55646d208514df5d602
2022-02-23 08:19:18 +01:00
sbassett 274c82043e SECURITY: Use constant time checks for token values
Bug: T302059
Change-Id: If726c61233d44e76a22fe25c2c910ce59771b49c
2022-02-22 16:11:07 -06:00
Translation updater bot 7c64eaf0a4 Localisation updates from https://translatewiki.net.
Change-Id: I870f0a7a161d11e7f9edd994a62a45bc5304043b
2022-02-22 08:12:01 +01:00
Translation updater bot 900f9e171c Localisation updates from https://translatewiki.net.
Change-Id: Id7282b409d4df3f66ac7fae4558cfd7399304600
2022-02-21 08:16:21 +01:00
Reedy de936aef6a Convert OATHAuth to abstract schema
Bug: T268564
Change-Id: I251fac0e1939cc84e7eab3e7514e07c81b2b0f1e
2022-02-18 10:36:56 +00:00
jenkins-bot 88552e65bf Merge "Add module types to log entries" 2022-02-18 09:18:09 +00:00
Translation updater bot 44831d0ecf Localisation updates from https://translatewiki.net.
Change-Id: Icbe945f1481cdc10980b68f04fad9bceb0b287f6
2022-02-18 08:40:54 +01:00