Commit graph

1213 commits

Author SHA1 Message Date
Translation updater bot 9bb97a9a43 Localisation updates from https://translatewiki.net.
Change-Id: I79c7f6f21e3fafa11ceb0555c60e87738f5b795c
2021-03-30 08:33:22 +02:00
Timo Tijhof 6b106fe10c TOTPKey: Use foreach instead of for-i-length and remove dead code
Follows-up c943f75.

* Use foreach to iterate the list of tokens, instead of i-to-length.

* Remove the redundant 'retval = false' assignment, as this was
  within an `if (!$retval)` block where the only previous assignment
  to it was either retval = 1 or retval = false. Hence redundant.

* Remove the conditional that made the list only checked if the
  list was not identical to `[ 0 => "" ]`.
  It is unclear to me why this check existed.
  I can imagine one of two scenarios, neither of which appears
  to be the case:
  1. Maybe the scratch list contains 10 tokens plus an empty string,
     and if we see it only contains that, we know it's logically empty
     and don't "need" to iterate the list.
     Except... iterating the list is cheap, so why bother?

  2. Maybe the scratch list contains 10 tokens plus an empty string,
     and we don't want to allow the empty string to be considered
     a valid scratch token to we skip the loop if that's the only
     one left.

     Except... if that were the case we'd be in trouble as it
     isn't being disallowed when the list contains other items
     still. And again, afaik it never contains an empty string,
     and hopefully empty input is already rejected by now.

   Neither of these are good reasons to remove the code without
   knowing what it was for though, so I'd rather we figure this
   out before merging. I can restore the check if it's non-trivial
   to find out.

Bug: T256918
Change-Id: Ide4160bdc18bc47da9632791fb4321e44d6d115a
2021-03-29 21:42:56 +00:00
Translation updater bot 04522fa6f9 Localisation updates from https://translatewiki.net.
Change-Id: I1ce20e1cb0e8a89830b32284d233485c05629d2d
2021-03-29 08:36:41 +02:00
libraryupgrader 9e8171867e build: Updating eslint-config-wikimedia to 0.19.0
Additional changes:
* eslint: Renamed `wikimedia/client` profile to `client-es5` (T277085).

Change-Id: I03280687b9740a26c27319c15f3aea9d41c28674
2021-03-14 04:29:18 +00:00
libraryupgrader 60b1ad5283 build: Updating eslint-config-wikimedia to 0.18.2
Change-Id: I27ddf85ef6aee2412e846d2002c3f0c5145c0ec0
2021-03-07 10:03:42 +00:00
Translation updater bot 58b26f743a Localisation updates from https://translatewiki.net.
Change-Id: I7e425648d4b3fccfe83af72efd859ea30a1a79aa
2021-03-01 08:52:49 +01:00
Translation updater bot ef2cf90e4a Localisation updates from https://translatewiki.net.
Change-Id: I4a48cfd4db9cb78b8840b84cde42d45b0a15355b
2021-02-26 08:57:10 +01:00
Translation updater bot aeae5e05a6 Localisation updates from https://translatewiki.net.
Change-Id: I763d31d0de05e414b537a2019b1c7628b11c0ab8
2021-02-24 08:51:51 +01:00
Translation updater bot 68e68b5d86 Localisation updates from https://translatewiki.net.
Change-Id: I78ba43882f6b0940def85d186ef4549fd4dfa96f
2021-02-15 10:05:56 +01:00
Translation updater bot 77407fc703 Localisation updates from https://translatewiki.net.
Change-Id: I3e70a53d9094d1ab6fe72fff43364a613b1bf479
2021-02-11 08:39:39 +01:00
Translation updater bot 8700272120 Localisation updates from https://translatewiki.net.
Change-Id: I0d620d18ca1315d15fb9a1cfd9f9604c35e93efc
2021-02-08 08:43:01 +01:00
Translation updater bot c7dd350664 Localisation updates from https://translatewiki.net.
Change-Id: I3df01abf770ced60b8156f227b9182dafbdec0ee
2021-02-02 08:39:36 +01:00
Translation updater bot 9a9aec9f7a Localisation updates from https://translatewiki.net.
Change-Id: I3a6b5943283e96f586760855732fefb6d1f87bd8
2021-02-01 08:48:16 +01:00
libraryupgrader 255d43e6a1 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 34.0.0 → 35.0.0
* mediawiki/minus-x: 1.1.0 → 1.1.1

npm:
* eslint-config-wikimedia: 0.17.0 → 0.18.1

Additional changes:
* Added the "composer phan" command to conveniently run phan.
* Removing manual extensions for eslint.

Change-Id: I8bb66a4485564d0518f105ccbbdd8f8ba73d20a3
2021-01-30 06:33:24 +00:00
Martin Urbanec b5a187624e Add oathauth-verify-user to oath grant
Change-Id: I4baf29ad39bd56bcbf45670423fd553643af6b55
2021-01-29 00:51:06 +01:00
Translation updater bot 4595e3e53c Localisation updates from https://translatewiki.net.
Change-Id: I08667ee4b0f7aaa3befa8a4c3ab68247bac874f4
2021-01-28 08:36:28 +01:00
Translation updater bot ee4c2973b4 Localisation updates from https://translatewiki.net.
Change-Id: I43b847c2c8775c6a23d0ffe659ddbe2ffb8030f0
2021-01-20 08:27:11 +01:00
Translation updater bot 5a7398d1c7 Localisation updates from https://translatewiki.net.
Change-Id: Ie70506164163af46c6573dea7afd323cdc0a33ff
2021-01-18 08:39:00 +01:00
Reedy 615965c730 Inject services to Special Pages
Change-Id: Ice0c63368e9c0aa77688b63a74eb706dd00691ce
2020-12-31 23:54:43 +00:00
Reedy 85d6681fef Convert to HookHandler
Bug: T270971
Change-Id: Idf8dad4872a220624b4355a8a9b5e9a02d0e442c
2020-12-31 19:52:49 +00:00
Reedy 1d97d5ef1b OATHManage: Code cleanup
* Stop returning return values of function that don't return anything
* Remove & from IManageForm reference

Change-Id: I7afa12a4f154cabee03be8947a0bfaadf9598a03
2020-12-31 04:25:10 +00:00
jenkins-bot dccf665960 Merge "Minor code style changes" 2020-12-31 03:29:55 +00:00
jenkins-bot 2545f76b6b Merge "Update christian-riesen/base32 (1.3.2 => 1.4.0" 2020-12-31 03:28:36 +00:00
jenkins-bot 58b670015e Merge "Updating jakobo/hotp-php (1.0.1 => 2.0.0)" 2020-12-31 03:28:34 +00:00
Reedy 37d2b0ff19 Remove TwoFactorIsEnabled hook handler
Hook was part of Extension:OpenStackManager, but removed by REL1_35, so unnecessary
I4741fcb073f8463f017bc1b477206dee801b662b / 46d9149c2db7c2b2d4573bede74b54779d66bee8

Change-Id: I2c5f99bfa9028c57a1eadbd81a51f84b47668848
2020-12-31 02:37:42 +00:00
Reedy ec1c1dcb22 Update TOTP Scratch Tokens to array
Bug: T237303
Change-Id: Ie8de059888363bf1cea4f0b268a46faaa5671904
2020-12-31 01:18:05 +00:00
Reedy 08aa532b59 Update christian-riesen/base32 (1.3.2 => 1.4.0
Depends-On: I719d5a2d08e2f86a428d7afff5eb8984b5c0e131
Change-Id: If838fbdc79f4573d530b4bd6815a173d73852c66
2020-12-29 20:46:26 +00:00
Reedy 12a0420203 Updating jakobo/hotp-php (1.0.1 => 2.0.0)
Bug: T269710
Change-Id: If1fb9111ddf7e425087bb290b7a031b2034f62a8
Depends-On: I2f4caa93653c4cd4cdc79047ea5fda114d4f9132
2020-12-28 03:47:08 +00:00
Reedy 6bb34e9265 Minor code style changes
Change-Id: I4bdc173fb6dd1cfeefc537c904a92724ea50112f
2020-12-28 02:47:09 +00:00
Translation updater bot 2f88a2c537 Localisation updates from https://translatewiki.net.
Change-Id: I84968764cd521f60473e14220bb6f67342006ceb
2020-12-23 08:32:48 +01:00
Translation updater bot 3acbeb0abf Localisation updates from https://translatewiki.net.
Change-Id: I27f76d51ea4f29a413cbb377423d55da75d884c2
2020-12-22 08:32:02 +01:00
libraryupgrader 6d56637bcd build: Updating mediawiki/mediawiki-phan-config to 0.10.6
Change-Id: I46aa2cd1e4408dc5ea51d15984cdfe4cea15f2ce
2020-12-19 23:28:08 +00:00
Umherirrender 69ef3c1bcb Avoid wfMessage in special page
Use self::msg instead to avoid global state

Change-Id: I78f914facee4174e76bbc77716b99d4aebd26c67
2020-12-19 12:16:51 +01:00
Ed Sanders 60714e7a81 Convert null global to false
Bug: T270147
Change-Id: I7b6d3bae126d7a1dc57eaf9ab0aef070595910e0
2020-12-16 17:52:16 +00:00
Reedy 53bb01d46a Minimise duplication of getting correct database instance in UpdateTables
Change-Id: Ide7dfe87f5e23997321c39623d3c574ae52fdb3e
2020-12-16 17:51:00 +00:00
Translation updater bot 4ab5f4474b Localisation updates from https://translatewiki.net.
Change-Id: I7cfae2969e12dfe5b85f1a3fe162b0bd844af33d
2020-12-14 08:42:42 +01:00
Translation updater bot ddbde0ab6e Localisation updates from https://translatewiki.net.
Change-Id: Id1d0458297bd257eff7a0034380a8368d278a700
2020-12-11 08:36:05 +01:00
libraryupgrader 33f9f74a0f build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.10.4 → 0.10.5

npm:
* ini: 1.3.5 → 1.3.7
  * https://npmjs.com/advisories/1589

Change-Id: Ia4be0a753d7a491ea6a5f34f749651a435687046
2020-12-10 21:40:19 +00:00
Translation updater bot 032548f80b Localisation updates from https://translatewiki.net.
Change-Id: Id8a6c519271b687b5190f1484dfb55feb9de46ce
2020-12-10 08:35:17 +01:00
Translation updater bot 3df655d9fa Localisation updates from https://translatewiki.net.
Change-Id: Iad55e4d616a95ee5039082af2479aa8ce09c48e2
2020-12-07 08:46:11 +01:00
libraryupgrader f90cf3b308 build: Updating mediawiki/mediawiki-codesniffer to 34.0.0
Change-Id: I31a8f87b84b7e4771703d303946ec4648baf30eb
2020-12-06 19:31:45 +00:00
Martin Urbanec 25208dce10 Czech translation of new special pages
Change-Id: Ie0d838a05ace4f5751b66b077d69bccf821b6172
2020-11-25 23:48:08 +01:00
Translation updater bot d0dd8041f7 Localisation updates from https://translatewiki.net.
Change-Id: Idf62664d745ef447465c806366c37ab0ee03997d
2020-11-23 08:39:44 +01:00
libraryupgrader 0e34c3be68 build: Updating npm dependencies
* grunt-stylelint: 0.15.0 → 0.16.0
* stylelint-config-wikimedia: 0.10.1 → 0.10.3

Change-Id: Ic347c29d218c06ceaa512b6c9b95ddd82a0c4cd8
2020-11-22 07:01:04 +00:00
libraryupgrader c5d50da753 build: Updating mediawiki/mediawiki-phan-config to 0.10.4
Change-Id: I9af907dddcab79451ca654c2795ae6212576e823
2020-11-20 10:50:39 +00:00
DannyS712 e801672feb disableOATHAuthForUser: Use fatalError
Bug: T268303
Change-Id: I93474a87e4263edfb46dce80e7216ec74a94580c
2020-11-20 04:11:56 +00:00
Translation updater bot f906c85adc Localisation updates from https://translatewiki.net.
Change-Id: I092d741bc02802931d2544d3688b58843c13fa68
2020-11-19 09:10:26 +01:00
Translation updater bot 7755b1a718 Localisation updates from https://translatewiki.net.
Change-Id: I5a533020978aa6a6232e727158a2da9910d54bed
2020-11-18 08:56:39 +01:00
Translation updater bot 07e52856d0 Localisation updates from https://translatewiki.net.
Change-Id: I921a321e97d96ad8102af32448809d6faf87d018
2020-11-17 08:42:56 +01:00
Translation updater bot bd3b1a56dd Localisation updates from https://translatewiki.net.
Change-Id: I34e9f57cb4f0ea15d32955ded08c9d3c0679eb44
2020-11-11 08:36:20 +01:00