Commit graph

1411 commits

Author SHA1 Message Date
jenkins-bot e127b3a13d Merge "Add feature flags for Media Viewer" 2014-03-20 23:50:22 +00:00
Mark Holmquist 547ddc97b1 Add client-side flag for disabling the viewer
Also set it on server-side. Use mw.config to override.

Change-Id: I00ea1ee8544d2c802f09fd25f7abaf29752f3641
2014-03-20 23:43:27 +00:00
Gergő Tisza c1ff536c3c Get more license info
Fetch more license information from the imageinfo API
(as needed by the reuse panel), store it in a new model

Change-Id: I331598b55b86d13e23a8bcd58c3ad8fcab749e6f
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-20 23:07:02 +00:00
Gergő Tisza 341d0199f1 Improve embed credit line
Gets the text closer to the spec:
* links have #mediaviewer (lots of code duplication, see #373)
* image has alt text (was title in the spec but that made less sense)
* less convoluted logic in getCreditHtml()

Change-Id: I43db84adb7fe29850706f92ee978016939b59aaa
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/369
2014-03-20 22:08:28 +00:00
jenkins-bot 68399ff376 Merge "Reuse dialog styling" 2014-03-20 21:16:04 +00:00
Aaron Arcos 40a6980d28 Fix some text selection issues with share/embed
Change-Id: Ic9d330c04d4e9335cdfce6e99870d1e5877b2a90
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/374
2014-03-20 14:12:39 -07:00
Translation updater bot dc20e45340 Localisation updates from https://translatewiki.net.
Change-Id: Ia344b4552188b774337f7f883ffc88e42350282c
2014-03-20 20:30:31 +00:00
Pau Giner 7e3d794c9f Reuse dialog styling
Adjustments of several styling aspects for the reuse file panel:
* Border style and colours to match the ones used in similar borders and Agora style
* Highlight the trigger also on hover
* Tweak the margins to avoid info on the embed panel to appear next to the edge.

Change-Id: I3a5448e3e81006ae35d2c18a9b2cbc2a6598210e
2014-03-20 14:52:39 +01:00
Translation updater bot 464448b346 Localisation updates from https://translatewiki.net.
Change-Id: I5991aef9a44d160817f06dc38cb106490a7a7a54
2014-03-19 20:43:30 +00:00
Gergő Tisza c7ae4a36ba Handle image loading rejections
Displays the rejection error message when loading something fails, so that the
user knows what's going on and can send meaningful error reports.

Needs non-crappy design.

Change-Id: I7d2914d89549b598bd1070ed40c6f1c9d45b55f0
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/271
2014-03-19 18:51:01 +00:00
Gilles Dubuc 49bc5edd93 Clear the cursor hiding class when attaching the lightbox
This ensures that if fullscreen was exited with the cursor hidden
reopening the lightbox should happen with a visible cursor

Change-Id: I33846234fd4c314ff9ff924e9f42d4e8c5c5bd8d
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/288
2014-03-19 16:01:30 +01:00
jenkins-bot 9cc429506e Merge "Add HTML text to embed tab" 2014-03-19 14:39:01 +00:00
jenkins-bot 965eda6b44 Merge "Add embed tab to reuse dialog" 2014-03-19 14:33:14 +00:00
jenkins-bot 548dafc0f3 Merge "Add share panel, replace reuse" 2014-03-19 14:24:31 +00:00
jenkins-bot 7ba96d7e87 Merge "Don't launch in articles with no text" 2014-03-19 13:57:43 +00:00
Gergő Tisza 466735fc10 Add HTML text to embed tab
Change-Id: Idcafe6dad9ffb17ffac365a350feff3903b37ff3
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148
2014-03-19 05:47:47 +00:00
Gergő Tisza f650813eb5 Add embed tab to reuse dialog
Implements the wikitext part of the mingle card

Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148
Change-Id: I5bcd8e2171f45c70736b7a7cfc695134269ed12d
2014-03-19 05:46:55 +00:00
Gilles Dubuc 56f923ae21 Add share panel, replace reuse
Mingle: 147

Change-Id: I5678002ac84965a80f5e63635151032e6c293194
2014-03-19 02:06:21 +00:00
Mark Holmquist 4b3c7867e7 Add feature flags for Media Viewer
$wgMediaViewerIsInBeta is one, $wgEnableMediaViewerForLoggedInUsers is
the other - use the former on all sites, the latter on pilot sites in
April.

Before merging, MERGE https://gerrit.wikimedia.org/r/117376

Change-Id: I232997918dee4a00be18c021eb351d81609df2b0
2014-03-18 21:17:58 +00:00
jenkins-bot 96523bc02f Merge "Fix navigation issue with alt+esc on Ubuntu/Unity." 2014-03-18 09:18:34 +00:00
Translation updater bot ec5b574172 Localisation updates from https://translatewiki.net.
Change-Id: If57108863ba6a4ddec5bfb706da51f895c5cd9f1
2014-03-17 21:20:09 +00:00
Gergő Tisza e8c099f3b7 Fix navigation issue with alt+esc on Ubuntu/Unity.
Bug: 62580
Change-Id: Ib2c8e21ee05000f7582f6e478034664c8be881e5
2014-03-17 21:14:07 +00:00
Prateek Saxena 652094039f Use animation mixin in core for invite-animation
Makes it easier to change the animation later without repetition.

Change-Id: I0dadafb91c288342480054d47fdda09a97d1773d
2014-03-17 09:02:30 +01:00
Translation updater bot 03ec8b46d7 Localisation updates from https://translatewiki.net.
Change-Id: I3cea8aaa582f84c181c26cd7b868bc7d1e74c695
2014-03-15 20:09:23 +00:00
Gilles Dubuc c6683b7e3f Make the panel animation more subtle
Also turns it into a CSS animation, which allows us
to clean a lot of code

Change-Id: Id6705b63b26d8be341e77352924cad6ac4b73da1
2014-03-14 09:04:28 +01:00
Translation updater bot d2f7e785ea Localisation updates from https://translatewiki.net.
Change-Id: If637fe8874c2924463828627357af2a6e7028521
2014-03-13 15:45:15 +00:00
jenkins-bot 54a699fe33 Merge "Simplify "Usage box" and layout adjustments" 2014-03-12 16:27:33 +00:00
Pau Giner f0061261e6 Simplify "Usage box" and layout adjustments
Adjustments to simplify the uses box by removing borders
and adjusting font sizes and colors.

Change-Id: Ia2cdc6af130d2280b7c94734174da5c154e42b7c
2014-03-12 17:23:51 +01:00
Translation updater bot 27d5897b05 Localisation updates from https://translatewiki.net.
Change-Id: I9592f4e6f9edddbf1353a5576dd8187efbfdad97
2014-03-11 20:44:50 +00:00
Mark Holmquist 2abb867b76 Don't launch in articles with no text
This is a silly bug.

Change-Id: I5d54cda34d5b7f383c182e41da13dfce141e36bb
2014-03-11 11:53:12 -07:00
jenkins-bot e2966b4079 Merge "Point the navigation E2E test to the right image" 2014-03-11 17:01:05 +00:00
Pau Giner 4ee0e06c6d Use different widths for metadata columns
This change makes the columns on the matadata panel use
a different width (2/3 and 1/3) to emphazize the description
with respect to the more advanced technical details.

Change-Id: I246e3496dd01649f360c1f80b859e2260bb1d87f
2014-03-11 16:05:14 +01:00
Gilles Dubuc 773ed3673b Point the navigation E2E test to the right image
Since we shuffled content around on Lightbox_demo,
the test was trying to read the wrong image.

Change-Id: I4ccaa0a1ab354aa4c19bc3870fb54b0ea11ff086
2014-03-11 16:02:18 +01:00
jenkins-bot 472f56d4ad Merge "Loads of fix-ups to our module definitions" 2014-03-10 21:56:50 +00:00
Translation updater bot 6b0af2fdbb Localisation updates from https://translatewiki.net.
Change-Id: I0ef2c1bfc334c152d23d97c2c05f6b7bf47efd41
2014-03-10 21:27:43 +00:00
Mark Holmquist 1cd9de75d8 Loads of fix-ups to our module definitions
I suspected the performance -> eventlogging dependencies were wrong
and took the opportunity to fix all the things.

Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-10 19:14:48 +00:00
jenkins-bot c350658093 Merge "Do not add icons to media viewer image list" 2014-03-10 19:02:27 +00:00
Translation updater bot 3d3afe335a Localisation updates from https://translatewiki.net.
Change-Id: Idf89c7d5b880a4eddc1f5dd7e0060187bf15ff7c
2014-03-09 20:32:49 +00:00
jenkins-bot c1fb20fedb Merge "Add checkered background to make black-on-transparent images visible" 2014-03-08 01:55:06 +00:00
Gergő Tisza 5a3d56f81b Merge MultiLightbox into LightboxInterface
Change-Id: I4363095e0504dd941793ba3addc7ee3cbe835536
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/178
2014-03-08 01:14:07 +00:00
Gilles Dubuc c386719cdb Some refactoring to get LightboxInterface closer to a proper UI component
* remove reference to MultimediaViewer
* move hash handling to MultimediaViewer
* make it inherit from Element, remove code duplication
* cleaner event handling life cycle (register on attach,
  unregister on unattach)

Change-Id: Ida8f68dead758a6ae3c429eb85c548af61e46801
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/178
2014-03-08 00:26:44 +00:00
Translation updater bot 308a377081 Localisation updates from https://translatewiki.net.
Change-Id: If34dcaae99344ff34b0c081f6972956fa24fdd8c
2014-03-07 21:41:21 +00:00
Mark Holmquist 21549d7547 Do not add icons to media viewer image list
e.g. {{refimprove}} on enwiki - there is an icon of a book that is only
meant to be illustrative on the page. It interferes with the page's image
collection and the flow.

Change-Id: Icd7e5885aaf8b31fffe07bd18cc0feb0f76b848c
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/229
2014-03-06 15:26:25 -08:00
Translation updater bot 3f73ea1076 Localisation updates from https://translatewiki.net.
Change-Id: If549af5b4bbdcfca9d8e0a255638b5a3ae2f03b3
2014-03-06 19:55:24 +00:00
Gergő Tisza d0f76bb160 Add checkered background to make black-on-transparent images visible
Bug: 57620
Change-Id: Ibabbb6d64f9d02ff5b94431a431ebb5222e344d7
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/284
2014-03-05 21:32:34 +00:00
Translation updater bot f51d22e4c3 Localisation updates from https://translatewiki.net.
Change-Id: I5f16fe4c1ed9194e9494486af05f14f410b5799e
2014-03-05 21:11:06 +00:00
jenkins-bot 0fa8f80942 Merge "Get rid of global viewer instance" 2014-03-05 17:52:18 +00:00
jenkins-bot d55e6e7417 Merge "Updated Ruby version from 2.1.0 to 2.1.1" 2014-03-05 10:55:01 +00:00
Gilles Dubuc 8beca0b106 Get rid of global viewer instance
- split event handler setup out of bootstrap and viewer creation
- simplify the tests setup/teardown

Change-Id: Icde1db81efd6191207ba35757192c800ea2d2e91
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/278
2014-03-05 02:33:06 +00:00
Gergő Tisza 59bd5e0032 Add tests for promise rejection error logging
Change-Id: I20d0803f211cbc4a7f00b58d015b565ca5c3b49b
Mingle:https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/268
2014-03-05 01:15:28 +00:00