Commit graph

1327 commits

Author SHA1 Message Date
Namit d66509e2de Open the download panel when an image is right clicked
Many users right-click on images as a way to download them.Due to this,
they may get a scaled-down version which is used for display purposes and
also not given guidance on how to attribute.

Bug: T75999
Change-Id: I30655a0dda4430b494a393f1fa708fce6ca6fafe
2015-01-07 22:48:00 +05:30
Translation updater bot 0788669bc7 Localisation updates from https://translatewiki.net.
Change-Id: I3dc4ac8eec19aac82fbf75a5fd1f3cee958d72e5
2015-01-05 23:08:11 +01:00
jenkins-bot 87591ab67f Merge "QA: back button workaround for Safari" 2015-01-05 16:56:43 +00:00
Cmcmahon c3a7bb5782 QA: back button workaround for Safari
Bug T85802

Change-Id: I4a3b360ffddbab5c22ca1eb3b03c45159425de70
2015-01-05 09:43:23 -07:00
Translation updater bot 0cda956cea Localisation updates from https://translatewiki.net.
Change-Id: Ia1dab9bfe82786adcddbdeb93fce73ee8b7ffe31
2015-01-04 21:49:29 +01:00
Translation updater bot f1942eb0f3 Localisation updates from https://translatewiki.net.
Change-Id: I7f9e5679353f2f83cf89dd28ad33fd117d9990d1
2015-01-03 23:03:44 +01:00
Translation updater bot b8821a2a3b Localisation updates from https://translatewiki.net.
Change-Id: I445108f6f889ec4d1c84d83b81a660ebc768603c
2015-01-02 22:36:23 +01:00
gladoscc 7f4ce833d4 Log right-clicks on the image
Record how many users right-click on the image in MediaViewer, with the
assumption being they're intending to download the image. However, that
image has been resized and is not the original.

The event is logged even if the metadata panel is open, as the user probably
still intended to download.

Bug: T75962
Change-Id: I223ed957bcc60646adf9c9a00d2d9ca18ad128e6
2015-01-01 13:24:32 +11:00
Geoffrey Mon cf67495467 Allow bold and italic text
Added mmv.HtmlUtils.htmlToTextWithTags()
  which is similar to htmlToTextWithLinks()
  but allows <b> and <i>
Added test for mmv.HtmlUtils.htmlToTextWithTags()
Most text fields now use htmlToTextWithTags()
  except Permission field which is not supposed to
  have HTML

Bug: T69887
Change-Id: I16833f218e2f64586aa13925356fa2b8b7ec3100
2014-12-31 01:01:50 +00:00
jenkins-bot f65d846b81 Merge "Add mw.mmv.viewer shortcut for current MediaViewer instance" 2014-12-31 01:01:00 +00:00
jenkins-bot ac7bfa9274 Merge "Show alt-text in export dialog and for lightbox image" 2014-12-30 21:00:09 +00:00
Geoffrey Mon 8ba4ff03c8 Show alt-text in export dialog and for lightbox image
Pass alt parameter from mmv.bootstrap.js to mmv.js and
set it as a parameter on the displayed lightbox image.
Include the alt text in the embed text.

Bug: T66519
Bug: T75923
Change-Id: I29503eb582ac2bc8cf89f737a3bcb787b660d918
2014-12-30 15:47:25 -05:00
Translation updater bot 8862a625e3 Localisation updates from https://translatewiki.net.
Change-Id: I3c04369891a35fe388554f01e7f7379025124e8c
2014-12-30 21:11:39 +01:00
jenkins-bot 9119af8534 Merge "More accurate looking for image caption" 2014-12-30 08:56:22 +00:00
m4tx eb7d6ef537 More accurate looking for image caption
MediaViewer now handles Template:Multiple_image. Instead of looking
for caption in whole thumbnail container, it tries to find the
closest one to the image.

Bug: T85354
Change-Id: I18d982a4bf245c4925213d83a3410274d499845e
2014-12-30 09:50:18 +01:00
gladoscc c0c50a8d35 Add mw.mmv.viewer shortcut for current MediaViewer instance
Bug: T76923
Change-Id: I38142b541d58e66fcef6e6e589507dcf30b1b3be
2014-12-30 18:23:48 +11:00
jenkins-bot dc8c2bc545 Merge "Change "view terms" to "hide terms" once clicked" 2014-12-29 22:37:53 +00:00
m4tx dac77cafc4 Change "view terms" to "hide terms" once clicked
metadataPanel overrides the grow() and shrink() methods in Permission
class instance, so the text is changed also when user clicks the
"view more" link inside the box.

Bug: T71233
Change-Id: I66fe57980c6f469d86e3d52b67d01e06a3a14270
2014-12-29 23:23:07 +01:00
jenkins-bot af4f85a326 Merge "Show custom Attribution line instead of Author/Credit when available" 2014-12-29 21:15:33 +00:00
Sn1per e4b8e860c8 Show custom Attribution line instead of Author/Credit when available
- Adds attribution variable to Image model
  - In mmv.ui.metadataPanel and mmv.EmbedFileFormatter, display
      attribution line instead of author and credit when it is set
  - Update junit tests for mmv.model.Image and mmv.EmbedFileFormatter

Bug: T67445
Change-Id: Idfe542a1542d28cf8d27c1720ab0bd54324b2f37
2014-12-29 15:56:05 -05:00
gladoscc db01284c6e Ignore events with modifier keys
I've combed through the entire codebase for keydown, keyup, keypress
and .which and I've only found one case where modifier keys are not
ignored for keyboard shortcuts.

Bug: T68329
Change-Id: I10ca2b89b9eb5addd7c706cf796331b5206d6bef
2014-12-29 17:52:44 +11:00
Translation updater bot 87151071e4 Localisation updates from https://translatewiki.net.
Change-Id: I3cb454f1fba5e3ee4273611b3e130c0bc0e78d1a
2014-12-28 21:45:53 +01:00
Translation updater bot ed5d49f1b6 Localisation updates from https://translatewiki.net.
Change-Id: Ibefc6603563de277973d985564480eac3c360e4c
2014-12-27 19:52:41 +01:00
Translation updater bot 72309d2d77 Localisation updates from https://translatewiki.net.
Change-Id: I5a7c13f71557cd5b1589497aa84f2bec7984a5c9
2014-12-26 09:46:39 +01:00
Namit 36ad534988 Ignore generated captions on special file related pages
Most special pages which list images generate a caption using
various information and MediaViewer displays this caption.It should
fall back to the file description instead.

Bug: T85234
Change-Id: I5448e5de7d6f8de9852a2a845400299b6b51b8ef
2014-12-24 23:19:01 +05:30
Translation updater bot 9258418a64 Localisation updates from https://translatewiki.net.
Change-Id: I065ef6ceee86639c25a46b5bd90926a9405d321c
2014-12-23 21:42:06 +01:00
jenkins-bot b343f85c05 Merge "MultimediaViewer usable on Special file related pages when enabled" 2014-12-23 18:15:43 +00:00
Namit 3244e8f1c6 MultimediaViewer usable on Special file related pages when enabled
When media viewer is enabled, go through the latest images in full-screen
mode making it look neat.

Bug: T63085
Bug: T73372
Change-Id: I8d92689eba580a88c98207e9197f1af0ea8ac96b
2014-12-23 18:06:42 +00:00
Translation updater bot 946e9cfb81 Localisation updates from https://translatewiki.net.
Change-Id: I3cb27e416eb94820887412148038f73c563ba507
2014-12-22 22:45:35 +01:00
Translation updater bot 7f70407399 Localisation updates from https://translatewiki.net.
Change-Id: Id5a64e2f743be29f121292ff35aa1febe8685087
2014-12-20 22:25:12 +01:00
Translation updater bot 7bedbe550f Localisation updates from https://translatewiki.net.
Change-Id: I6d6b048a398ce0d549977f4984e453ca9e608340
2014-12-19 22:27:32 +01:00
Namit 50391b6a01 Permission title changed to "Permission details"
It is not about the license but the permission why Commons may keep this file.
Other permission messages also changed accordingly.

Bug: T66804
Change-Id: Ic3f1f1f8280022f4c0d1b48502cac1709b5c14a1
2014-12-19 12:49:52 -06:00
Translation updater bot d74f2ec5bb Localisation updates from https://translatewiki.net.
Change-Id: I5441f245884dedeafb74f23e3cf96ac60244bd18
2014-12-18 23:21:33 +01:00
jenkins-bot 25c294d569 Merge "QA: update navigation test for rspec" 2014-12-18 09:15:17 +00:00
jenkins-bot ba5acde550 Merge "Make "and X more" message more flexible for translators" 2014-12-18 09:00:14 +00:00
Cmcmahon 711e2837fc QA: update navigation test for rspec
This should be pretty straightforward

* use RSpec3 expect() syntax
* prefer string to regex as argument to match() when appropriate
* use Selenium $browser.back instead of inline javascript

Change-Id: I2e214752224397859a00f11bf9acc5bdc7685464
2014-12-17 15:02:38 -07:00
Translation updater bot e80ee41442 Localisation updates from https://translatewiki.net.
Change-Id: I1236320c9e0d7351d42d65dcfa37aea5db5fb274
2014-12-17 21:50:14 +01:00
jenkins-bot 3d346f2886 Merge "Log Last-Modified header in performance logger" 2014-12-17 19:26:54 +00:00
jenkins-bot 9c38b75f30 Merge "QA: WIP update tests for RSpec3 syntax etc." 2014-12-17 18:24:20 +00:00
Gilles Dubuc b3e281237c Log Last-Modified header in performance logger
Bug: T78767
Change-Id: If747453b32cbe1db7e307193609af9eaa2bdcc7d
2014-12-17 11:31:45 +01:00
Translation updater bot 79ae4efee5 Localisation updates from https://translatewiki.net.
Change-Id: I54ee47d426ebb436de52d4064741c55f6d41b7d0
2014-12-16 21:57:40 +01:00
Cmcmahon 32cd6c7892 QA: WIP update tests for RSpec3 syntax etc.
Add back a sleep to make the test pass

* make a Then statement with no assertion into a When
* remove Then statements assertions from Given steps
* prefer single quotes per rubocop
* use strings instead of regexes where appropriate for match operator
* use appropriate wait_until syntax
* remove redundant steps that call a single other step
* sort invisible selection criteria from steps to Feature input
* add when_present polling because test is now much faster

Change-Id: I24435362836945833942e87d7caee49c9b34368d
2014-12-15 16:42:34 -07:00
Translation updater bot b49642c654 Localisation updates from https://translatewiki.net.
Change-Id: I233e2fe2781ceaac823aee2ba29d420bf4776f88
2014-12-15 22:19:56 +01:00
Translation updater bot 96de4e5ef3 Localisation updates from https://translatewiki.net.
Change-Id: Iabc30302a52598f90269edfe69e050fa80ec3c72
2014-12-14 22:21:57 +01:00
Translation updater bot adf8581bbe Localisation updates from https://translatewiki.net.
Change-Id: I20d7c960ec700f01cee3993a3ac6e158f4b14f70
2014-12-13 22:33:11 +01:00
Translation updater bot 07dd523664 Localisation updates from https://translatewiki.net.
Change-Id: I60cd2d40d20a064c9ace34886bf4055eff6535b3
2014-12-11 23:54:17 +01:00
jenkins-bot 5c869aa9ec Merge "Rough logging of metadata panel scrolling" 2014-12-09 09:53:50 +00:00
jenkins-bot 219315766e Merge "Remove superfluous write of ensureEventHandlersAreSetUp flag" 2014-12-09 09:27:15 +00:00
Translation updater bot 0598f25891 Localisation updates from https://translatewiki.net.
Change-Id: Ie09081b0bd0fe9ce1cd0fd32c58ff25df870dde8
2014-12-08 23:22:46 +01:00
Gergő Tisza 361464a55e Remove superfluous write of ensureEventHandlersAreSetUp flag
Change-Id: Ie28f58ea7d7b92f9eced46d94490bde9df69daa5
2014-12-08 21:58:20 +00:00