wikimedia/mediawiki-extensions-MultimediaViewer
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer synced 2024-12-18 19:01:47 +00:00
Code Issues Packages Projects Releases Wiki Activity
2904 commits 14 branches 22 tags 40 MiB
Commit graph

58 commits

Author SHA1 Message Date
Simon Legner f00dbbb939 Remove IIFE 
Remove Immediately-invoked function expression throughout production code base.

Bug: T77349
Change-Id: Ia31b556975209bbea27df8444b69d924654b181e
 2024-05-21 22:31:15 +02:00
libraryupgrader 147b576b57 build: Updating dependencies 
composer:
* mediawiki/mediawiki-phan-config: 0.12.1 → 0.14.0

npm:
* eslint-config-wikimedia: 0.25.1 → 0.26.0
  The following rules are failing and were disabled:
  * resources:
    * es-x/no-resizable-and-growable-arraybuffers
  * tests/qunit:
    * es-x/no-resizable-and-growable-arraybuffers

* grunt-banana-checker: 0.11.0 → 0.11.1

Change-Id: Ief610bdadaccd2325cd1b8a2cae70b7e465d8b76
 2024-02-13 02:13:29 +00:00
Simon Legner 30fad6b8b8 Use ES6 features 
* classes
* arrow functions
* const/let
* string templates
* Object.assign

Bug: T337102
Change-Id: I757b9993a2feeed707fb4ad213944001498f3f6a
 2023-06-12 16:45:08 +00:00
Simon Legner 0683f3ecc8 Remove global mw.mmv 
Bug: T337030
Change-Id: I90e8507cb1b7c30f6ba29dbdec8966e84b46aff2
 2023-05-21 08:02:54 +00:00
Simon Legner d82910fbb3 Use packageFiles in mmv 
Bug: T337030
Change-Id: I833c7e91230272b82a2512fd55f1c7c0f61233b4
 2023-05-20 10:04:41 +03:00
Simon Legner 35cd0f18c0 Use packageFiles in mmv 
Bug: T337030
Change-Id: I90cdfb626c176b27b59db6b92b9edd6b2fe49b68
 2023-05-20 09:34:56 +03:00
Sam Smith 34e4968b2c Remove instrumentation 
The MediaViewer and MultimediaViewer* instruments were disabled circa
October 2021 in Ie7dd8739efc.

This patch removes those instruments and any supporting code and data.
Notably, this patch does not remove the mw.mmv.logging.ViewLogger
instrument, which is responsible for logging image views.

Bug: T310890
Change-Id: I97d41be93849b2ae9d1adba6660546ea716657fd
 2022-07-05 17:41:24 +00:00
Ed Sanders e131da48f9 build: Update eslint-config-wikimedia to 0.22.1 
Change-Id: I275ecfa03b3df8554b30f2a0f6d94d4b66da8088
 2022-05-20 00:05:49 +01:00
jdlrobson d9925de6d5 Catch malformed URIs 
Malformed URIs are difficult to filter due a lack of normalization
across browsers. This is our top error message with over 300 instances.

Catching this would reduce logspam and make our client error logging
much more usable.

Bug: T268060
Change-Id: If1c345af704df82f16c7ef1ecbf63862c1fbee77
 2021-03-04 09:12:47 -08:00
Cormac Parle ecbb6856cf url-encode page uri before starting the view duration timer 
Bug: T268060
Change-Id: I956f745786fe41b2c62c8ee6d13d91d9dc89bda5
 2020-12-10 12:22:15 +00:00
Ed Sanders bfdcd8dbf1 eslint: Update eslint-config-wikimedia to 0.16.2 
Change-Id: I0c35ed9b5ab00952124cb0e5c6c48fbc0d734f60
 2020-06-26 12:14:27 +01:00
Ed Sanders d554d7f426 Docs: Fix whitespace 
Change-Id: I98dc12787f68bd8db60e5a5bcb9366daf9f2f6b8
 2020-06-26 11:21:04 +01:00
Fomafix f89d7dc878 Remove "window." for location and setTimeout 
The JavaScript in core also don't use "window." for these browser
properties and methods.

Change-Id: I344573fd7ef0e73c252779b4e59a53168d16574f
 2019-06-10 12:46:58 +02:00
James D. Forrester c6008c7844 build: Be more aggressive in fixing old bad JS code style 
Change-Id: I7f734f1440a4a3216e774d2bddbc39b34f4125d2
 2019-02-20 19:28:25 +00:00
James D. Forrester 1b21470703 build: Update eslint-config-wikimedia to 0.11.0 
Change-Id: I66788a2c1fa59b617abd13b7c8e8fb59ad74130c
 2019-02-20 19:22:21 +00:00
Ed Sanders a518cb03a5 build: Update eslint-config-wikimedia to 0.9.0 
Change-Id: I92ed1f7093cfaed47f0372f9cb063fe4e65b4f55
 2019-01-03 13:47:16 +00:00
Ed Sanders 1ded292f83 Remove obsolete aliases from closures 
Bug: T208951
Change-Id: Ice695dfb489974faa23ba19d74cf17b06e3f6075
 2018-11-12 16:33:24 +00:00
Kunal Mehta c50794c3f2 Don't use deprecated jquery.hidpi module 
Using window.devicePixelRatio directly means we won't be supporting Windows 8
and/or IE 10 & 11. But that seems intentional based on 828f6d6ac9db.

Bug: T206099
Change-Id: I53dbce0a8ddc69c4edfd4d10f98031aa4f7cd20a
 2018-10-08 20:15:18 -07:00
Fomafix 965b496850 Replace jQuery by native JavaScript 
Change-Id: I8ae88f9f569be61902e19f89c687b0188a7c099c
 2018-09-11 21:15:07 +02:00
Timo Tijhof 5c9faa580e Move files to their own directory per module 
Bug: T193826
Change-Id: I925b1c7be2dbbb50994ed9f1ef12b5978ba175ff
 2018-07-30 15:15:25 +02:00
Ed Sanders 42b577bae9 build: Update linters 
Change-Id: I7262fb369df0428c39adaf55128b83f019afb4c0
 2017-10-31 18:42:04 +00:00
Ed Sanders 9514e3107a Code lint: Throw errors, no strings 
Change-Id: I4bb4de96a5e61b67b7a4c8f16a22f67f53cb034f
 2017-05-17 11:28:53 +01:00
Matthias Mullie 5bc3a2d90e Fix mmv.logging.PerformanceLogger qunit tests 
Bug: T164473
Change-Id: I6ae5c0170bf12fb076ddc505299ceeb7b9c292e8
 2017-05-16 16:54:43 +02:00
Ed Sanders d7ea64137c build: Replace jshint/jscs with eslint 
Change-Id: I423add157245353031e36b7e44fee7ace7c753c7
 2017-01-10 10:24:39 -08:00
Fomafix 8869af6eed Replace $( document ).ready(...) by $(...) 
In jQuery 3 $(document).ready(...) is deprecated.
https://jquery.com/upgrade-guide/3.0/#deprecated-document-ready-handlers-other-than-jquery-function

Change-Id: Iddec938b358388db11203b4b604928ecdcb3abe2
 2017-01-06 16:04:56 +01:00
Gilles Dubuc a149b63b05 Make performance statsv call sampled 
Bug: T149168
Change-Id: I5614d1eec1834c1d694a5bf71d5ca05ec29ad354
 2016-11-19 03:31:20 +00:00
Ed Sanders b46529d1b2 build: Introduce jshint & jscs and make a pass 
These replace the hard-coded jshint task in CI.

Change-Id: Id14eec1ecba4ceae735ffd10f9114233a580302f
 2016-07-19 13:48:06 -07:00
Gilles Dubuc 53a3d9a379 Make Media Viewer pluggable for the 3D extension 
Some of the code encountered accessed mw.config directly,
I cleaned that up by migrating to mmv.Config, which is an
abstraction added to avoid peeking at mw.config directly.

Bug: T132064
Change-Id: I2a95ba703e6c7f46296f8e435bceec769dceebf9
 2016-04-15 16:43:45 +02:00
Julius Alphonso a9758d21e0 Remove uploader's name from MediaViewer 
Only last uploader's name is shows, this turns out to be
more confusing than useful.

Bug: T59308
Change-Id: I7d06b72c581fe8738bffc64b5e36be9983b01ccf
 2015-12-29 10:56:08 +05:30
Gilles Dubuc 04be1d5fcc Add most common non-bucket size to statsv performance tracking 
Bug: T105681
Change-Id: I11e971141455d41e935543e3a06f587ebcd070ef
 2015-08-05 11:01:14 +02:00
Gilles Dubuc 66d510dddc Track image load time with statsv 
Bug: T105681
Change-Id: Ic25edf7852d4b87d2b35fabf6494d88dbfdb922e
 2015-07-30 14:01:55 +02:00
jenkins-bot 0464c2b9e7 Merge "Record virtual image views" 2015-03-12 09:04:54 +00:00
Gergő Tisza c3c549f1b4 Make logging less noisy in debug mode 
Suppress logger console output if the logger is disabled.

Change-Id: I5f45bb7fc68f33880f8a4d1737f0055335fe5071
 2015-02-19 23:50:04 +00:00
Gilles Dubuc 2b1c1b2260 Record virtual image views 
Soft-depends on Ie20ed8fc7041e89510a6558d9e2647c67a0a4bbf

Bug: T89088
Change-Id: If1459bd9acde8b6e5040afbd89e2ceafc61dedc9
 2015-02-16 18:06:08 +01:00
Gilles Dubuc d638d9906c Record performance log hits regardless of ResourceTiming data contents 
Bug: T87877
Change-Id: Ia196ef82004413144a9a256b73bd35aec8135760
 2015-01-29 11:23:11 -08:00
Fomafix ae99be730e Apply coding conventions for JavaScript 
Change-Id: I57a8f188eb1152438a8e94235a6f6801e2617c28
 2015-01-23 12:48:27 +00:00
gladoscc 7f4ce833d4 Log right-clicks on the image 
Record how many users right-click on the image in MediaViewer, with the
assumption being they're intending to download the image. However, that
image has been resized and is not the original.

The event is logged even if the metadata panel is open, as the user probably
still intended to download.

Bug: T75962
Change-Id: I223ed957bcc60646adf9c9a00d2d9ca18ad128e6
 2015-01-01 13:24:32 +11:00
Gilles Dubuc b3e281237c Log Last-Modified header in performance logger 
Bug: T78767
Change-Id: If747453b32cbe1db7e307193609af9eaa2bdcc7d
 2014-12-17 11:31:45 +01:00
Gergő Tisza fdbefc27fc Rough logging of metadata panel scrolling 
Logs metadata panel open/close by scroll. When the panel is opened
via keyboard or the "view terms" button, both a normal and a scroll
opening event is logged (same for closing). When the panel is opened
in fullscreen mode, neither event is logged.

Change-Id: I09092b8b6c20e6fea03b4fe59c811d7b441ca224
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/559
 2014-12-08 21:56:51 +00:00
Gilles Dubuc 30029b8b78 Track the most recent upload time for performance events 
Change-Id: I673f9487deea15dc148452a3a4d6b91563a2c417
Bug: T76035
 2014-12-03 16:15:20 +01:00
Gilles Dubuc 00d345f8b4 Rename Performance to PerformanceLogger 
Change-Id: Iacfde35851cf8f617c4672d3ea466d4f0e2e448f
 2014-11-21 11:07:40 +01:00
Gilles Dubuc 0e01796a3c Track how long users are viewing images for 
This is complete, but it would be better if the HEAD request
was actually aborted by Varnish when the viewDuration parameter is
present, or if the hit pointed to a script that does that.

Change-Id: I66cafd97427756411e967de1901324af2215e3ae
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/1001
 2014-11-21 00:39:29 +01:00
Gilles Dubuc c98a243639 Track image "unviews" 
Change-Id: I4441b6df511f99b73bfafea0d804171435e129d2
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/998
 2014-11-21 00:37:11 +01:00
Trevor Parscal a8838e4bae Update OOjs UI Class Names (549ff9ab7d) 
Changes were generated by running this script:
https://gist.github.com/trevorparscal/92ccdc4c49ab033d9ba8

File content changes:
Scripts (*.js)
- TextInputMenuWidget → TextInputMenuSelectWidget
- MenuWidget → MenuSelectWidget
- MenuItemWidget → MenuOptionWidget
- MenuSectionItemWidget → MenuSectionOptionWidget
- OutlineWidget → OutlineSelectWidget
- OutlineItemWidget → OutlineOptionWidget
Styles (*.less)
- textInputMenuWidget → textInputMenuSelectWidget
- menuWidget → menuSelectWidget
- menuItemWidget → menuOptionWidget
- menuSectionItemWidget → menuSectionOptionWidget
- outlineWidget → outlineSelectWidget
- outlineItemWidget → outlineOptionWidget

Change-Id: I19ad3990837c0c565773fbb4c3d9d4d18e5f616e
 2014-11-20 01:04:32 +00:00
jenkins-bot 4dc8ec2669 Merge "Track the most recent upload time for duration events" 2014-11-20 00:04:14 +00:00
Gilles Dubuc 6eb64f39ba Track the most recent upload time for duration events 
This will allow us to see if images uploaded recently, which have been
subjected to thumbnail prerendering, load faster.

Change-Id: I4ce358ff54e4ca4e290349aa3ff4810ad4714d24
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/975
 2014-11-11 18:14:24 +01:00
Gilles Dubuc 0e782adf7d Add the ability to apply a different duration sampling factor to loggedin users 
Change-Id: I10fc042ddf50f02e1a86711621b66c14fc981311
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/978
 2014-11-06 18:51:08 +01:00
Mark Holmquist ff7a8b23c2 Add about link to disable/enable dialog 
This was the last issue with the dialogs. Tests included.

Change-Id: Ic08af400893950a04489af4b166827d059561974
 2014-10-24 13:51:32 -05:00
Gilles Dubuc 0d743977dd Fix issue with options dialog when media viewer has been reopened 
- Fixes the bug where the options menu wouldn't open if media
viewer was reopened
- Adds human-readable console messages for the options actions
- Makes the tooltip a tipsy one like all the other buttons
- Fixes the tooltip copy, it was referring to "previews", which we
said we wouldn't do anymore, in favour of "Media Viewer"

Change-Id: I1590f9501cc6c406cc1f466b414062d4d6435c1b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/963
 2014-10-23 15:29:44 +02:00
jenkins-bot 2203f89236 Merge "Log image dimensions" 2014-09-30 15:15:54 +00:00