Ed Sanders
d7ea64137c
build: Replace jshint/jscs with eslint
...
Change-Id: I423add157245353031e36b7e44fee7ace7c753c7
2017-01-10 10:24:39 -08:00
Fomafix
8869af6eed
Replace $( document ).ready(...) by $(...)
...
In jQuery 3 $(document).ready(...) is deprecated.
https://jquery.com/upgrade-guide/3.0/#deprecated-document-ready-handlers-other-than-jquery-function
Change-Id: Iddec938b358388db11203b4b604928ecdcb3abe2
2017-01-06 16:04:56 +01:00
Gilles Dubuc
a149b63b05
Make performance statsv call sampled
...
Bug: T149168
Change-Id: I5614d1eec1834c1d694a5bf71d5ca05ec29ad354
2016-11-19 03:31:20 +00:00
Ed Sanders
b46529d1b2
build: Introduce jshint & jscs and make a pass
...
These replace the hard-coded jshint task in CI.
Change-Id: Id14eec1ecba4ceae735ffd10f9114233a580302f
2016-07-19 13:48:06 -07:00
Gilles Dubuc
53a3d9a379
Make Media Viewer pluggable for the 3D extension
...
Some of the code encountered accessed mw.config directly,
I cleaned that up by migrating to mmv.Config, which is an
abstraction added to avoid peeking at mw.config directly.
Bug: T132064
Change-Id: I2a95ba703e6c7f46296f8e435bceec769dceebf9
2016-04-15 16:43:45 +02:00
Julius Alphonso
a9758d21e0
Remove uploader's name from MediaViewer
...
Only last uploader's name is shows, this turns out to be
more confusing than useful.
Bug: T59308
Change-Id: I7d06b72c581fe8738bffc64b5e36be9983b01ccf
2015-12-29 10:56:08 +05:30
Gilles Dubuc
04be1d5fcc
Add most common non-bucket size to statsv performance tracking
...
Bug: T105681
Change-Id: I11e971141455d41e935543e3a06f587ebcd070ef
2015-08-05 11:01:14 +02:00
Gilles Dubuc
66d510dddc
Track image load time with statsv
...
Bug: T105681
Change-Id: Ic25edf7852d4b87d2b35fabf6494d88dbfdb922e
2015-07-30 14:01:55 +02:00
jenkins-bot
0464c2b9e7
Merge "Record virtual image views"
2015-03-12 09:04:54 +00:00
Gergő Tisza
c3c549f1b4
Make logging less noisy in debug mode
...
Suppress logger console output if the logger is disabled.
Change-Id: I5f45bb7fc68f33880f8a4d1737f0055335fe5071
2015-02-19 23:50:04 +00:00
Gilles Dubuc
2b1c1b2260
Record virtual image views
...
Soft-depends on Ie20ed8fc7041e89510a6558d9e2647c67a0a4bbf
Bug: T89088
Change-Id: If1459bd9acde8b6e5040afbd89e2ceafc61dedc9
2015-02-16 18:06:08 +01:00
Gilles Dubuc
d638d9906c
Record performance log hits regardless of ResourceTiming data contents
...
Bug: T87877
Change-Id: Ia196ef82004413144a9a256b73bd35aec8135760
2015-01-29 11:23:11 -08:00
Fomafix
ae99be730e
Apply coding conventions for JavaScript
...
Change-Id: I57a8f188eb1152438a8e94235a6f6801e2617c28
2015-01-23 12:48:27 +00:00
gladoscc
7f4ce833d4
Log right-clicks on the image
...
Record how many users right-click on the image in MediaViewer, with the
assumption being they're intending to download the image. However, that
image has been resized and is not the original.
The event is logged even if the metadata panel is open, as the user probably
still intended to download.
Bug: T75962
Change-Id: I223ed957bcc60646adf9c9a00d2d9ca18ad128e6
2015-01-01 13:24:32 +11:00
Gilles Dubuc
b3e281237c
Log Last-Modified header in performance logger
...
Bug: T78767
Change-Id: If747453b32cbe1db7e307193609af9eaa2bdcc7d
2014-12-17 11:31:45 +01:00
Gergő Tisza
fdbefc27fc
Rough logging of metadata panel scrolling
...
Logs metadata panel open/close by scroll. When the panel is opened
via keyboard or the "view terms" button, both a normal and a scroll
opening event is logged (same for closing). When the panel is opened
in fullscreen mode, neither event is logged.
Change-Id: I09092b8b6c20e6fea03b4fe59c811d7b441ca224
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/559
2014-12-08 21:56:51 +00:00
Gilles Dubuc
30029b8b78
Track the most recent upload time for performance events
...
Change-Id: I673f9487deea15dc148452a3a4d6b91563a2c417
Bug: T76035
2014-12-03 16:15:20 +01:00
Gilles Dubuc
00d345f8b4
Rename Performance to PerformanceLogger
...
Change-Id: Iacfde35851cf8f617c4672d3ea466d4f0e2e448f
2014-11-21 11:07:40 +01:00
Gilles Dubuc
0e01796a3c
Track how long users are viewing images for
...
This is complete, but it would be better if the HEAD request
was actually aborted by Varnish when the viewDuration parameter is
present, or if the hit pointed to a script that does that.
Change-Id: I66cafd97427756411e967de1901324af2215e3ae
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/1001
2014-11-21 00:39:29 +01:00
Gilles Dubuc
c98a243639
Track image "unviews"
...
Change-Id: I4441b6df511f99b73bfafea0d804171435e129d2
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/998
2014-11-21 00:37:11 +01:00
Trevor Parscal
a8838e4bae
Update OOjs UI Class Names (549ff9ab7d)
...
Changes were generated by running this script:
https://gist.github.com/trevorparscal/92ccdc4c49ab033d9ba8
File content changes:
Scripts (*.js)
- TextInputMenuWidget → TextInputMenuSelectWidget
- MenuWidget → MenuSelectWidget
- MenuItemWidget → MenuOptionWidget
- MenuSectionItemWidget → MenuSectionOptionWidget
- OutlineWidget → OutlineSelectWidget
- OutlineItemWidget → OutlineOptionWidget
Styles (*.less)
- textInputMenuWidget → textInputMenuSelectWidget
- menuWidget → menuSelectWidget
- menuItemWidget → menuOptionWidget
- menuSectionItemWidget → menuSectionOptionWidget
- outlineWidget → outlineSelectWidget
- outlineItemWidget → outlineOptionWidget
Change-Id: I19ad3990837c0c565773fbb4c3d9d4d18e5f616e
2014-11-20 01:04:32 +00:00
jenkins-bot
4dc8ec2669
Merge "Track the most recent upload time for duration events"
2014-11-20 00:04:14 +00:00
Gilles Dubuc
6eb64f39ba
Track the most recent upload time for duration events
...
This will allow us to see if images uploaded recently, which have been
subjected to thumbnail prerendering, load faster.
Change-Id: I4ce358ff54e4ca4e290349aa3ff4810ad4714d24
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/975
2014-11-11 18:14:24 +01:00
Gilles Dubuc
0e782adf7d
Add the ability to apply a different duration sampling factor to loggedin users
...
Change-Id: I10fc042ddf50f02e1a86711621b66c14fc981311
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/978
2014-11-06 18:51:08 +01:00
Mark Holmquist
ff7a8b23c2
Add about link to disable/enable dialog
...
This was the last issue with the dialogs. Tests included.
Change-Id: Ic08af400893950a04489af4b166827d059561974
2014-10-24 13:51:32 -05:00
Gilles Dubuc
0d743977dd
Fix issue with options dialog when media viewer has been reopened
...
- Fixes the bug where the options menu wouldn't open if media
viewer was reopened
- Adds human-readable console messages for the options actions
- Makes the tooltip a tipsy one like all the other buttons
- Fixes the tooltip copy, it was referring to "previews", which we
said we wouldn't do anymore, in favour of "Media Viewer"
Change-Id: I1590f9501cc6c406cc1f466b414062d4d6435c1b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/963
2014-10-23 15:29:44 +02:00
jenkins-bot
2203f89236
Merge "Log image dimensions"
2014-09-30 15:15:54 +00:00
Gergő Tisza
ff76011032
Log image dimensions
...
Also add a sanity test to attribution logging which I forgot at the time.
Change-Id: I3010e57eb74a76fee4078c415182a033375ea890
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/898
2014-09-30 14:55:47 +00:00
Gergő Tisza
2e4379c66e
Only add country field when it's in the schema
...
Change-Id: Id38ce4d20312bd15014cf37d521aac0a97bd660b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/907
2014-09-26 22:05:22 +00:00
jenkins-bot
cdfd59feae
Merge "Remove copypasted code from attribution logger"
2014-09-26 14:56:12 +00:00
Gergő Tisza
af6688ef47
Remove copypasted code from attribution logger
...
Probably copied this from the duration logger and forgot to delete.
Change-Id: Ia59f9d8e5b384486c3d8509120223f6694a78529
2014-09-26 06:53:38 +00:00
Mark Holmquist
0d4863dd91
Make the download pane into its own dialog
...
Change-Id: Ia92545ed1ef7f2e4ba7934c682eef684a22ca17f
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/841
2014-09-24 17:05:50 +02:00
Gilles Dubuc
d4666c5715
Track more metrics
...
- About page
- Discuss page
- Help page
- Location page
- Uploader page
- Download, share and embed tabs in detail (each clickable element)
- "Use this file" closed (previous was counted as open event)
Change-Id: I1ebcb39049ad9b521968eb2024be9b86a49e5b0c
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/851
2014-09-08 10:26:55 +02:00
Gergő Tisza
e5de2a5415
Log whether attribution could be presented by MediaViewer
...
Change-Id: Ib4e8fbafa16c86ff902c838cc93b1710a7ca87af
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/858
2014-09-05 14:35:35 +00:00
Gergő Tisza
c4c262bf44
Move logging-related code to its own directory
...
Also make sure class and file names have the same case.
Change-Id: I21042e40030051326f8c55fd62a86a54e9011a4a
2014-09-04 23:34:45 +00:00
