Commit graph

1081 commits

Author SHA1 Message Date
Gergő Tisza af6688ef47 Remove copypasted code from attribution logger
Probably copied this from the duration logger and forgot to delete.

Change-Id: Ia59f9d8e5b384486c3d8509120223f6694a78529
2014-09-26 06:53:38 +00:00
jenkins-bot 53b4bd28c0 Merge "Fix patch which fixes the reuse dropdowns" 2014-09-17 22:36:01 +00:00
Gergő Tisza 1f78d2b83c Fix patch which fixes the reuse dropdowns
See https://bugzilla.wikimedia.org/show_bug.cgi?id=70968
for explanation.

Bug: 70918
Change-Id: Ibe1c4c1e415952982049d7c581253bb5b8a2e500
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/897
2014-09-17 22:30:55 +00:00
jenkins-bot 6a5a103ea7 Merge "Fix garbled dropdown text" 2014-09-17 22:21:43 +00:00
Translation updater bot 134a612330 Localisation updates from https://translatewiki.net.
Change-Id: I406be4de0f57de7949e98754988554b0fe2d7a54
2014-09-17 22:45:52 +02:00
Gergő Tisza 57b2799081 Fix garbled dropdown text
Bug: 70918
Change-Id: I84683ef373409c808ccfaa3b0c3aafef813349b7
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/897
2014-09-17 20:33:56 +00:00
jenkins-bot 8607a81e79 Merge "Fix over reported use-this-file-close event" 2014-09-15 09:19:58 +00:00
jenkins-bot f7cbc93b86 Merge "Make sure event handlers are set up even if onready handler is lost" 2014-09-15 08:19:01 +00:00
Translation updater bot 723da66a0b Localisation updates from https://translatewiki.net.
Change-Id: I9a3b81da0ae6b992da164c0d5c7560adf918b796
2014-09-15 02:07:12 +02:00
Gergő Tisza 4b6e44a2fc Make sure event handlers are set up even if onready handler is lost
Due to a jQuery bug, errors in local code (gadgets, user scripts)
can cause onready handlers to not be executed. For MMV this causes
catastrophic failure, with a black screen of death on exit.

This change makes sure that the setup code necessary for Media
Viewer to work is executed at latest when MV is invoked, even if some
onready handlers were skipped.

Opening MediaViewer via a hash-URL will still not work if the onready
handler fails, but that's hard to avoid and it is not a catastrophic
failure anymore. This change can be reverted when bug 70772 gets fixed.

Bug: 70756
Change-Id: Ida3b780791bc9dfec29303567d33e3aa4f44dd81
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/891
2014-09-12 23:49:43 +00:00
Translation updater bot 4d8634e8f8 Localisation updates from https://translatewiki.net.
Change-Id: I3dd0d05e7bb88eaccecf8a612d32613d257cf230
2014-09-13 00:47:50 +02:00
Cmcmahon 15705664dd QA: add tags to run in IE builds
Also add tags to run all tests in beta and test2. Let's see
what happens and remove them later if necessary.

NOTE: one test had no tags and ostensibly should run only on mw.o
We may have to remove them later, but let's see what happens for
now

Change-Id: I9c4adc7803afc975d9643a35631801bbac459eb7
2014-09-12 09:46:44 -07:00
Gilles Dubuc dca82c3866 Fix over reported use-this-file-close event
Merely opening media viewer would trigger it.

Change-Id: I62f4685b821aace3d6323c511d5ad889c1745c4b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/889
2014-09-12 10:48:04 +02:00
jenkins-bot 32429a7723 Merge "Revert "Change image load check strategy"" 2014-09-12 05:38:44 +00:00
Translation updater bot 717011766e Localisation updates from https://translatewiki.net.
Change-Id: Ib51bd36e63aca7ef51813f337d539ecf59e4e339
2014-09-11 23:58:32 +02:00
Mark Holmquist a82dfd6eb0 Remove tooltip for view-file
Change-Id: I89b2dfd43ea18a2e1fe9d2214b76218b24ce88cb
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/886
2014-09-11 10:41:45 -07:00
Gergő Tisza ea0689a7e9 Revert "Change image load check strategy"
Experimental revert of commit 
d6c142fd2b to see if it caused
the weirdness in the versus charts:
http://multimedia-metrics.wmflabs.org/dashboards/mmv#media_viewer_vs_file_page-graphs-tab

That commit affecting file page load times is extremely unlikely. 
A change in the test environment which exactly coincided with it is 
equally unlikely. This is an easy way  to tell which is the case.

Change-Id: I3581abd36d25494ca294db892480e25f6f4c5a73
2014-09-11 12:48:38 +00:00
Translation updater bot b5a71b8800 Localisation updates from https://translatewiki.net.
Change-Id: I0e3e41e73a518f1c34947ee7f0efbbf08f1083cf
2014-09-10 23:41:15 +02:00
jenkins-bot 01e05f07bf Merge "Feature detection for MV load: add SVG, remove Object.create" 2014-09-10 11:42:50 +00:00
Gilles Dubuc 2ef45b3058 Remove categories
Change-Id: I309b01592e874579d50bf5fc0810c238d47748f5
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/835
2014-09-09 13:23:50 +00:00
jenkins-bot 23c7258b31 Merge "Remove file usage" 2014-09-09 13:10:37 +00:00
Gilles Dubuc 81ab508697 Feature detection for MV load: add SVG, remove Object.create
OOJS polyfills Object.create now so there is no need to check for its
existence before loading OOJS-dependent code. On the other hand,
MediaViewer uses SVG icons extensively and the interface cannot be used
if they don't show up.

Bug: 70553
Change-Id: I716e12d4061cfc5c64ccca4563bc30a4394494af
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/863
2014-09-09 10:54:11 +00:00
Gilles Dubuc b70fa7251d Replace addEventListener call with jQuery's .on()
Bug: 70553
Change-Id: I24680e7b7759d30eca2a733d670e10c0b4bfe7ab
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/863
2014-09-09 11:18:03 +02:00
Gilles Dubuc d4666c5715 Track more metrics
- About page
- Discuss page
- Help page
- Location page
- Uploader page
- Download, share and embed tabs in detail (each clickable element)
- "Use this file" closed (previous was counted as open event)

Change-Id: I1ebcb39049ad9b521968eb2024be9b86a49e5b0c
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/851
2014-09-08 10:26:55 +02:00
jenkins-bot 79f1ee4a09 Merge "Go to the original image on image clicks" 2014-09-08 06:33:54 +00:00
Translation updater bot 0bb11a85a9 Localisation updates from https://translatewiki.net.
Change-Id: Ib471c808d5aab949d97e98985c3679655b4012a5
2014-09-07 22:00:31 +02:00
Translation updater bot a6469b1596 Localisation updates from https://translatewiki.net.
Change-Id: If287bae80d65ca9288df9e611ede5766a95064ee
2014-09-05 22:47:37 +02:00
Mark Holmquist f94d3362d9 Go to the original image on image clicks
Also removes original file button.

Change-Id: I6e73e46e910313fe6c5efb3087ecb693e499e064
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/831
2014-09-05 10:19:00 -07:00
jenkins-bot 0534d98b89 Merge "Log whether attribution could be presented by MediaViewer" 2014-09-05 14:41:38 +00:00
Gergő Tisza e5de2a5415 Log whether attribution could be presented by MediaViewer
Change-Id: Ib4e8fbafa16c86ff902c838cc93b1710a7ca87af
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/858
2014-09-05 14:35:35 +00:00
Gilles Dubuc caa624d711 Remove file usage
Change-Id: I538f7734e1c06a179ee98a5cd843ccee4d91349f
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/835
2014-09-05 08:14:52 +02:00
jenkins-bot e7ea5cb25d Merge "Move logging-related code to its own directory" 2014-09-05 05:32:33 +00:00
Gergő Tisza c4c262bf44 Move logging-related code to its own directory
Also make sure class and file names have the same case.

Change-Id: I21042e40030051326f8c55fd62a86a54e9011a4a
2014-09-04 23:34:45 +00:00
Reza 00e1980e4b Make aside ltr so it would overflow to right always
Proposed on https://meta.wikimedia.org/w/index.php?diff=9752968&oldid=9752027

Change-Id: I9546bc40cf600cddb3af124cb5b937c3ee739d4a
2014-09-04 22:38:06 +00:00
Translation updater bot 91b7bd265a Localisation updates from https://translatewiki.net.
Change-Id: I01be2ef68350ceb17a9dac715b34e5475f774320
2014-09-04 22:08:22 +02:00
jenkins-bot 57dca0ed8c Merge "Use link title as fallback for caption" 2014-09-04 06:56:49 +00:00
Translation updater bot 5f208dd6ea Localisation updates from https://translatewiki.net.
Change-Id: Ibac8d41be907a42ab4e9e1a0ac2e852fd1e09a40
2014-09-03 22:21:35 +02:00
Mark Holmquist 35b6f70ef2 Use link title as fallback for caption
This works because the title doesn't exist if there's no caption and we
won't get to this logic branch if the thumbnail is an explicit |thumb|
with a caption already.

Refactored caption-fetching a bit.

Change-Id: If84c890e7b71880db640a0993f8e3d6cd59951b8
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/513
2014-09-03 12:13:21 +00:00
Translation updater bot ebf2836401 Localisation updates from https://translatewiki.net.
Change-Id: Ice4bf7f0fc08abcb9f23456f08c0d1460b85b44b
2014-09-02 22:15:38 +02:00
Gergő Tisza 92c0ba8d99 Fix reuse panel layout issues
The OOUI inline menu widget does not use ul/li anymore; user
class name to target CSS instead.

Change-Id: Ia23f6c130145b411cb0c76a8448d725e51d5e700
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/838
2014-09-02 10:08:43 +00:00
Translation updater bot fe46ca97ef Localisation updates from https://translatewiki.net.
Change-Id: I0a1a0f8b2fee4ebb5491f48d39b431cb8b1f9390
2014-09-01 22:36:29 +02:00
Gilles Dubuc aa97b45c28 CSS compatibility with upcoming OOUI breaking change
Change-Id: Ic7bb6246b20706f8b7e4d7c39d6eb7fd921fde7b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/832
2014-09-01 10:02:48 +02:00
Translation updater bot 8e5999f01c Localisation updates from https://translatewiki.net.
Change-Id: I3056d082a933e7cd604741f1a749ff315ac8b737
2014-08-31 21:56:43 +02:00
Translation updater bot 6580d25a38 Localisation updates from https://translatewiki.net.
Change-Id: I1213158d3bff249349e721fb140b366747091101
2014-08-30 22:39:52 +02:00
Translation updater bot 1703aeff2c Localisation updates from https://translatewiki.net.
Change-Id: Ib8f0d04e4776dded722ee2ee33cf083f8aaeefb1
2014-08-29 21:20:36 +02:00
Translation updater bot 9968dbc3f5 Localisation updates from https://translatewiki.net.
Change-Id: I3ef7e5537612e3ab14ec34b156b02dbeb49e43f4
2014-08-28 22:29:59 +02:00
Gilles Dubuc d6c142fd2b Change image load check strategy
Using the "complete" property worked for the file page, but not
for media viewer because change the src of an img doesn't reset
the prop.

This introduces a custom event that cucumber can listen to in order
to know when the full resolution image had been loaded in media
viewer.

Change-Id: I40875166e70badbb35106c4a3536c706a7c815b4
2014-08-28 07:33:58 +02:00
Translation updater bot a0a7c2f995 Localisation updates from https://translatewiki.net.
Change-Id: I4581042e647458d52f1815fa8fe02aad2edfd6f9
2014-08-27 21:25:50 +02:00
Cmcmahon 781fc6d409 QA: update to fix deprecated API token call
Change-Id: I8842899e2467efdb9ba4b3035b2e6dc0df340a96
2014-08-27 09:21:30 -07:00
jenkins-bot fb6e8ad1e2 Merge "Fix preference DB values" 2014-08-27 08:11:08 +00:00