Commit graph

2957 commits

Author SHA1 Message Date
Simon Legner bc63438a16 Remove obsolete fields imageDisplayedCount and metadataDisplayedCount
Bug: T77349
Change-Id: Ie553107c33f24b26571ebd93e2458b4878c09f3b
2024-06-13 22:25:03 +02:00
Simon Legner a951a360d5 Remove obsolete property LightboxImage.filePageLink
Bug: T77349
Change-Id: I9c4fa491cb6bdc2668c6d21cc314c5290847bbc1
2024-06-13 22:17:00 +02:00
Simon Legner 8ecfc1aa7d LightboxImage.originalWidth needs to be a property
mmv.displayPlaceholderThumbnail overrides this value using ImageInfoProvider.

Bug: T64039
Follow-Up: Ic7c5889064492fc88dae33271b635c5327b091e1
Change-Id: I08d024f81336a76439f51b7684446f8725ddb905
2024-06-13 21:48:09 +02:00
Simon Legner 048c359806 Remove obsolete class IwTitle
Bug: T77349
Change-Id: Idc81f0d97ebfef725bcdb93ca50deac197d67590
2024-06-13 21:11:58 +02:00
Umherirrender 33f327dc69 tests: Use renamed class BundleSizeTestBase
Follow-Up: I131e0d85bd14e75aaebd6f212b2e64a45d4c73a2
Change-Id: I0361c994af6320f4b8100390e8f43da3b92bb689
2024-06-12 20:38:07 +02:00
Translation updater bot a63fb2f42f Localisation updates from https://translatewiki.net.
Change-Id: I87bf51a0be67de8655fdaee87df8ef5d307c6c44
2024-06-11 09:55:04 +02:00
Translation updater bot 8e364ecad6 Localisation updates from https://translatewiki.net.
Change-Id: Iaba451121dc330d42a022facf187fc42bb42e642
2024-06-10 09:55:48 +02:00
Umherirrender d9742f34f3 Use new namespace for Output hooks
Change-Id: I1e82fe02b676ecc776b0412f60bde18b3c944da2
2024-06-09 18:50:10 +02:00
Ed Sanders 39968fdb9a Update stylelint-config-wikimedia to 0.17.1
Change-Id: Icaa6d43338a747dbbf1d05d50646d6c7a0edda6d
2024-06-07 17:34:06 +01:00
Ed Sanders 27459e19dc Fix JSDoc complex return types
Change-Id: Ia50a9f086ebb0abcaf0409dac33f66178275cd30
2024-06-07 17:33:16 +01:00
Ed Sanders a74af878a4 Convert jQuery callbacks to arrow functions
Change-Id: I0a9ddd6931ac0f4f30b638491941d624582081ca
2024-06-07 17:33:16 +01:00
Ed Sanders fa18975543 build: Update eslint-config-wikimedia to 0.28.0 and autofix
Change-Id: Iff4b874580768b008427c0bea535ab08cea14a36
2024-06-07 17:33:12 +01:00
jenkins-bot 14f47a0509 Merge "Api: remove obsolete getQueryField function" 2024-06-05 18:43:21 +00:00
Translation updater bot eadbae2d78 Localisation updates from https://translatewiki.net.
Change-Id: I2f3235f5ef5a61402df4286f82d674b1c0ffd1b0
2024-06-05 09:23:29 +02:00
Simon Legner 0399ffff40 Api: remove obsolete getQueryField function
Obsolete since Ia4388fe4d5e1d6112a992e826453cd5799a6a4b4.

Bug: T77349
Change-Id: I13efa32786a2ba65edbaedde214057e9efe98145
2024-06-04 19:34:30 +02:00
Translation updater bot 2fdb205fc6 Localisation updates from https://translatewiki.net.
Change-Id: Ie47b3c4ddd85352c0ac64fe81a3fd23f1bdbff3e
2024-06-03 09:32:16 +02:00
jenkins-bot c754f877a6 Merge "Add loading bar while loading mmv module" 2024-05-31 20:10:23 +00:00
Derk-Jan Hartman c1a38cfe9e Add loading bar while loading mmv module
When opening the media viewer, we immediately display a black frame,
as we wait for the dependencies etc to load.

Add a codex indeterminate progress bar to this phase as we wait, so
the user has feedback that something is happening.

Bug: T77230
Change-Id: Ibba98150ac2e8034fbfcd586309632704cf0b606
2024-05-31 19:50:19 +00:00
Simon Legner 21438d2b22 Remove FileRepoInfo API and Repo model
Repo was only used in two locations:
1. StripeButtons.set for `isCommons` - can be replaced by `descriptionUrl.includes('//commons.wikimedia.org/')`
2. EmbedFileFormatter.getSiteLink (unused)

Furthermore:
- Simplify StripeButtons (we only have one button)
- Unwrap info objects consisting of `ImageModel` and `Repo`
- Remove unused EmbedFileFormatter.getSiteLink
- Inline EmbedFileFormatter.getCaption and EmbedFileFormatter.getLinkUrl
- Fix JSDoc type `ImageModel`

Reduces mmv bundle size from 28012 to 27246.

Bug: T77349
Change-Id: Ia4388fe4d5e1d6112a992e826453cd5799a6a4b4
2024-05-31 08:13:08 +02:00
Derk-Jan Hartman 82e36ddc61 Use CSS transitions for the progressbar.
Bug: T77349
Change-Id: Ib2e5367b913eaf1f4b8920ed7e78dbdecb01ca1d
2024-05-30 20:00:07 +00:00
jenkins-bot 167978ae5b Merge "Use mw.msg shortcut" 2024-05-29 21:53:16 +00:00
jenkins-bot da7401f983 Merge "Move dialog/reuse dialog code to mmv.ui.reuse module" 2024-05-29 20:23:47 +00:00
Translation updater bot c1d17ebd14 Localisation updates from https://translatewiki.net.
Change-Id: I8123a0fb67d57b5af712abd7ba14f76a1064a764
2024-05-29 09:32:02 +02:00
Simon Legner a8a5247c5e Use mw.msg shortcut
Change-Id: I5af9cc79d1c6108f643b690ded0dd9b876c3852b
2024-05-29 05:14:01 +00:00
Novem Linguae b02ba00fd0 JSDoc: convert @cfg to @param
Bug: T138401
Change-Id: Ib09d471a28821f54c6f8678e788ba85fbd426d35
2024-05-28 06:25:20 -07:00
Simon Legner 5bee6274e0 Move dialog/reuse dialog code to mmv.ui.reuse module
Initialise the corresponding dialogs upon first use by deferred loading of the mmv.ui.reuse module. Reduces code size of the main mmv module.

Bug: T77349
Change-Id: I672419e1a8af47d192843f7e7a4a038c0d8da2a3
2024-05-28 11:58:44 +02:00
Translation updater bot eca84a5542 Localisation updates from https://translatewiki.net.
Change-Id: I11f2f37c99358eaf1ad43c42534cf8533d1c8e52
2024-05-28 09:30:55 +02:00
Translation updater bot 584b7f63ed Localisation updates from https://translatewiki.net.
Change-Id: Ib279a7cbbbdc5cea418e42b32eecc9c0a013722f
2024-05-27 09:29:30 +02:00
Derk-Jan Hartman f8fe9c0af3 Remove the thumbnail blurring
This removes the thumbnail blurring.

The initial page thumbnail is still in place.
This too can be slightly improved as sizing up to the MMV frame is
done via JS right now, and causes a noticeable change. But we can
simply do this with CSS immediately i think.

Bug: T71609
Bug: T65504
Change-Id: If2a92689be9ee7ecd64561dc224991f31274d58a
2024-05-25 00:56:35 +00:00
Simon Legner 72ba58c134 Merge download/share/embed into mmv.ui.reuse module
Bug: T77349
Change-Id: I19f3444ac3e35d94ba3436e0c1387a1cb5b7e972
2024-05-24 18:27:03 +00:00
Translation updater bot 0be073a7a0 Localisation updates from https://translatewiki.net.
Change-Id: Ic8547be71afe116db8e82c72bd5d18fd60dddc9a
2024-05-24 09:44:01 +02:00
Translation updater bot fa48f2e9a8 Localisation updates from https://translatewiki.net.
Change-Id: I1e5a43dcc613ad25ac181a6bf5a64e67da4dac66
2024-05-23 09:28:00 +02:00
Simon Legner 4eaf0725a9 Remove index.js export indirection
Reduces mmv module size from 168.85kB to 167.92kB.

Bug: T77349
Change-Id: I40a4b044ca286dcda948243d5029b3377430d4ff
2024-05-21 22:12:17 +00:00
Simon Legner f00dbbb939 Remove IIFE
Remove Immediately-invoked function expression throughout production code base.

Bug: T77349
Change-Id: Ia31b556975209bbea27df8444b69d924654b181e
2024-05-21 22:31:15 +02:00
jenkins-bot d4cded1d88 Merge "Simplify MetadataPanel.setLocationData" 2024-05-21 19:27:04 +00:00
jenkins-bot bc3cc059bb Merge "Revert "Revert "Add position handling to URLs""" 2024-05-21 19:27:02 +00:00
TheDJ 24ee9dc48d Revert "Revert "Add position handling to URLs""
This reverts commit 5b89420182.

Reason for revert: restore previously reverted patch

Bug: T64039
Change-Id: Iac4486ae785f308d2a572f383073cfb73c7cb523
2024-05-21 19:09:16 +00:00
jenkins-bot 45ea6b65ab Merge "Touch events should make the controls visible" 2024-05-20 23:26:38 +00:00
Derk-Jan Hartman f592eeea3b Remove unused code from mmv.ui
Bug: T77349
Change-Id: I9e26dc68859d9dca3c6066837253e85a19039ce0
2024-05-20 23:02:04 +00:00
TheDJ 5b89420182 Revert "Add position handling to URLs"
This reverts commit de56d4a6de.

Reason for revert: breaks resize handler. Lets revert before branch cut.

Change-Id: I1e4d57d8384ab434f17968100f8bea1bf90c40ff
2024-05-20 20:51:59 +00:00
Derk-Jan Hartman 8940fbf6a7 Touch events should make the controls visible
Bug: T364942
Change-Id: If423570ba6e7b99f7383e71108fa2048852616b2
2024-05-20 22:04:59 +02:00
Simon Legner de56d4a6de Add position handling to URLs
- Instantiate LightboxImage object in mmv.bootstrap
- Add LightboxImage.position field: relative position of this image to others with same file
- Add optional routing suffix /:position

Bug: T64039
Change-Id: Ic7c5889064492fc88dae33271b635c5327b091e1
2024-05-20 18:36:23 +00:00
Translation updater bot e28bbde0c6 Localisation updates from https://translatewiki.net.
Change-Id: I6be6fd66295f804a1a2e61fb0f2758578ffe9527
2024-05-20 09:25:43 +02:00
libraryupgrader 75a0ba6a7f build: Updating grunt-banana-checker to 0.13.0
Change-Id: I8749eabf3a1d77c7a530b7a0912760092b8ed610
2024-05-18 18:35:54 +00:00
Simon Legner dad874d6ce Simplify MetadataPanel.setLocationData
Extract common function convertDegMinSec for latitude and longitude.

Change-Id: I7037ab1d1444b670f37834f178220fc7cabd433f
2024-05-18 17:27:20 +00:00
jenkins-bot 78f88fd300 Merge "Extract mmv.ui.restriction module" 2024-05-17 21:08:54 +00:00
Simon Legner c53047d181 Extract mmv.ui.restriction module
This module contains the restriction icons. The main mmv module shrinks from 196.88kB to 174.97kB.

Bug: T77349
Change-Id: I78d16b487f5272a8f779f3484c883d113db1878b
2024-05-17 20:51:05 +00:00
jenkins-bot ae063e56f3 Merge "Use heavier box shadow for the dialog" 2024-05-17 15:45:36 +00:00
jenkins-bot 1246e5bd5f Merge "Allow striken text in MMV descriptions" 2024-05-17 13:20:07 +00:00
Translation updater bot 6f0e429e49 Localisation updates from https://translatewiki.net.
Change-Id: I36a846b8be71c16fb7cccf049b9f4e0102cc54ed
2024-05-17 09:49:22 +02:00