Commit graph

1133 commits

Author SHA1 Message Date
jenkins-bot 2203f89236 Merge "Log image dimensions" 2014-09-30 15:15:54 +00:00
jenkins-bot 8b13ddbd90 Merge "Debounce resizes" 2014-09-30 15:15:52 +00:00
Gergő Tisza ff76011032 Log image dimensions
Also add a sanity test to attribution logging which I forgot at the time.

Change-Id: I3010e57eb74a76fee4078c415182a033375ea890
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/898
2014-09-30 14:55:47 +00:00
Gergő Tisza 6a0ad63085 Debounce resizes
* create a resize-end event which fires 100ms after resize ends
  (or pauses)
* move slow resize callback (fetching new thumbnail from the server)
  to resize-end

Change-Id: I1c1217ea43ffade4cfaf0c03f24574d0ebfee080
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/898
2014-09-30 14:45:00 +00:00
Gilles Dubuc 58d0d45730 Lowercase tooltip wording
Change-Id: I4b74981190084c43c5d3b608cfcb3de1d358eae6
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/914
2014-09-30 13:50:19 +02:00
Translation updater bot 5acb0fd0a4 Localisation updates from https://translatewiki.net.
Change-Id: I07c0f9b2cf0e53dca330df80857c9f853f2970ce
2014-09-29 23:31:56 +02:00
jenkins-bot 1181870ae7 Merge "Change tooltip wording" 2014-09-29 15:02:33 +00:00
Gilles Dubuc 2f1cfc0403 Change tooltip wording
Change-Id: I3c4ed1306fe355ef787bbfdc771b6df43854159b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/914
2014-09-29 16:59:33 +02:00
jenkins-bot 22966d4358 Merge "Only add country field when it's in the schema" 2014-09-29 14:05:25 +00:00
jenkins-bot 265e414c50 Merge "Remove duplicate details link in metadata panel" 2014-09-28 21:47:51 +00:00
Mark Holmquist 9187148b01 Remove duplicate details link in metadata panel
Change-Id: I2eaa221fa505e9f106fa8611adfe99677a24009b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/909
2014-09-28 21:45:55 +00:00
Translation updater bot 23514d8bce Localisation updates from https://translatewiki.net.
Change-Id: Ibf9476282aa397168bddce24f8ec98617d3a5b0b
2014-09-28 22:35:34 +02:00
jenkins-bot 68bbd8e4e0 Merge "Initialise dialogOpen value to false" 2014-09-28 17:49:56 +00:00
Translation updater bot afc028c7e1 Localisation updates from https://translatewiki.net.
Change-Id: Ia4617237c6aa2e9d87307a1b912efdd7b3908169
2014-09-27 20:30:15 +02:00
Mark Holmquist b0aa337fd5 Initialise dialogOpen value to false
Because it was undefined, the toggleClass method just turned the class on
if it wasn't there in the first place.

Silly jQuery, Trix are for kids.

Change-Id: I4e21e033529834a4f808270306c72f5756b69ab2
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/921
2014-09-26 19:03:14 -07:00
Gergő Tisza 2e4379c66e Only add country field when it's in the schema
Change-Id: Id38ce4d20312bd15014cf37d521aac0a97bd660b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/907
2014-09-26 22:05:22 +00:00
jenkins-bot cab8fe42d5 Merge "Revert "Layout adjustments to reduce overlap with chevron"" 2014-09-26 18:46:51 +00:00
jenkins-bot f4348a844a Merge "Revert "Show initially part of the below the fold area"" 2014-09-26 17:52:33 +00:00
MarkTraceur 640984b2e9 Revert "Layout adjustments to reduce overlap with chevron"
This reverts commit b77ae2c62b.

Change-Id: Ibc9d864d5309eb23ec1b495a1311a614e907b5a8
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/912
2014-09-26 17:52:13 +00:00
Gilles be3f2a3302 Revert "Show initially part of the below the fold area"
This reverts commit 248875e703.

Change-Id: I826d2b9ff346d862e7a7e6113c19b87e718e1acd
2014-09-26 15:17:11 +00:00
jenkins-bot cdfd59feae Merge "Remove copypasted code from attribution logger" 2014-09-26 14:56:12 +00:00
Gergő Tisza af6688ef47 Remove copypasted code from attribution logger
Probably copied this from the duration logger and forgot to delete.

Change-Id: Ia59f9d8e5b384486c3d8509120223f6694a78529
2014-09-26 06:53:38 +00:00
Translation updater bot 56b4ec2df7 Localisation updates from https://translatewiki.net.
Change-Id: I7e6beb42e0c40366f6f04ab00264bf36c9bad4b6
2014-09-25 23:06:40 +02:00
jenkins-bot f1b9c0c391 Merge "Fix dialog class" 2014-09-25 13:44:44 +00:00
jenkins-bot 8f27f2c67b Merge "More details button color fix" 2014-09-25 09:20:14 +00:00
jenkins-bot 1c56b23ff7 Merge "QA: Refactored performance tests" 2014-09-25 09:16:24 +00:00
Pau Giner 958bedac36 More details button color fix
This patchset avoids the more button to become tranlucent due to som legacy styling.
The margin is also slightly adjusted to center the button in the panel.

Change-Id: Ic3936e90c891ded71d2954cd0e591012fb7bb33b
2014-09-25 07:19:22 +02:00
Mark Holmquist b691086f2b Fix dialog class
Missed this small issue - doesn't affect actual behaviour but will make a
confusing cursor display in some instances.

Change-Id: I40c3cf0c9596f40983f090974044bcd6f7d203d3
2014-09-24 16:19:03 -07:00
jenkins-bot 0caa1c4ddc Merge "Fix bug where download dialog doesn't unattach" 2014-09-24 21:15:03 +00:00
jenkins-bot 7b1d3814fe Merge "Move focus event handlers to mmv.ui.Element" 2014-09-24 21:14:59 +00:00
jenkins-bot 6c2fe0aaf5 Merge "Style fixes for the UI changes" 2014-09-24 21:14:51 +00:00
jenkins-bot 93d678dcd6 Merge "Move dialogs to the left, make arrows point right" 2014-09-24 21:14:50 +00:00
jenkins-bot 18beee316e Merge "Make the download pane into its own dialog" 2014-09-24 21:12:20 +00:00
jenkins-bot 24e2487d7e Merge "Make "more details" button bigger 'n' prettier" 2014-09-24 21:12:18 +00:00
jenkins-bot e05655d880 Merge "Make the reuse button part of the canvas" 2014-09-24 21:12:10 +00:00
Mark Holmquist f7d9c66177 Fix bug where download dialog doesn't unattach
Change-Id: I02c45bf9d0aea8e92d02cb80f266f6c83633a50c
2014-09-24 14:05:53 -07:00
Translation updater bot e0e4b0d88e Localisation updates from https://translatewiki.net.
Change-Id: I3fd8edebd7288a2d77d06f72b43356706552c526
2014-09-24 22:17:37 +02:00
Mark Holmquist 133a94cb89 Move focus event handlers to mmv.ui.Element
Needed to make sure the download dialog can use the handlers.

Change-Id: If62146f1181f0e722be691f61e5fdc133c9b3795
2014-09-24 17:08:50 +02:00
Mark Holmquist 325a8a3e27 Style fixes for the UI changes
I decided to fix them all at once since we're merging all of these
patches together anyway. I can pull changes into other patches if
absolutely necessary.

Also fixes the dialog open/close handlers for the canvas click event,
and leaves the reuse dialog open on next/prev.

Change-Id: Id1564425442aec72e5e41f2f80986d8a104dd92c
2014-09-24 17:08:02 +02:00
Mark Holmquist c6f3be42aa Move dialogs to the left, make arrows point right
Change-Id: If8fc4ca5f902b3dc3271a33c44554d4e46faadb8
2014-09-24 17:07:05 +02:00
Mark Holmquist 0d4863dd91 Make the download pane into its own dialog
Change-Id: Ia92545ed1ef7f2e4ba7934c682eef684a22ca17f
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/841
2014-09-24 17:05:50 +02:00
Pau Giner b77ae2c62b Layout adjustments to reduce overlap with chevron
For files with long credit information, part of the text can get hidden
with the down-pointing chevron.
This patchset adjust sizes and margins of different elements to reduce that overlap.

Change-Id: I03f3b84d4ad0f754a0a20f2e78016711164ef433
2014-09-24 13:11:47 +02:00
jenkins-bot 01ef0368e0 Merge "Show initially part of the below the fold area" 2014-09-24 10:00:56 +00:00
Pau Giner 248875e703 Show initially part of the below the fold area
In order to communicate that there is more content below.
This is related to acceptance criteria #8 of story #830.
For more details check:  https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/830

Some further improvement to consider:
- We'll need to adjust the "more details" button margin to make it fit better in the current above the fold area (0.55 em instead of the current 0.7em).
- If the panel is open, and the user clicks outside of it (e.g., over the image), the panel should close.
- We may want to eliminate the pointing-down chevron if we don't want it to conflict with the big "more details" button.

Change-Id: If14886647aa0660a524a720e8d223eca655d5f3f
2014-09-24 11:59:39 +02:00
jenkins-bot 99367524f2 Merge "Add shadow when scrolling panel" 2014-09-24 09:57:10 +00:00
Dan Duvall c5a245309d QA: Refactored performance tests
Fixed up feature indentation and clauses and moved global methods into
the page-object classes.

Added @custom-browser tag to avoid starting multiple browser sessions
and updated mediawiki_selenium dependency for fix to custom browser
instantiation with SauceLabs.

Change-Id: I9741afb8d13ee8729f72210eb7617d9446311a8e
2014-09-23 14:19:16 -07:00
Mark Holmquist 7d7cd3a8e6 Make "more details" button bigger 'n' prettier
Change-Id: I81a370a910c0cec269a000c9dcaac8461d3421b0
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/830
2014-09-23 10:41:00 -07:00
Pau Giner 956cd4b47e Add shadow when scrolling panel
When the panel is scrolling a shadow is added to better communicate that
the panel moves over the image.
More details: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/193

Change-Id: I06866a3a034977002b98658a3d09b5421b583ee7
2014-09-23 17:37:41 +02:00
Gilles Dubuc 89800caedb Rename file page button
Change-Id: Ic3c2b2b7201c4870e1548597a4309483983ae431
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/870
2014-09-23 16:17:43 +02:00
Translation updater bot 43d88d8d30 Localisation updates from https://translatewiki.net.
Change-Id: Ifc5608024e2cbbb905ce46e693b58dd4c72fe415
2014-09-22 21:47:01 +02:00