James D. Forrester
c6008c7844
build: Be more aggressive in fixing old bad JS code style
...
Change-Id: I7f734f1440a4a3216e774d2bddbc39b34f4125d2
2019-02-20 19:28:25 +00:00
Ed Sanders
92157f6b05
build: Update eslint-config-wikimedia to 0.10.1
...
Change-Id: Icd89819ef38142e55c0bd4cc8dbb73745123f9f6
2019-02-06 01:56:53 +00:00
Ed Sanders
1ded292f83
Remove obsolete aliases from closures
...
Bug: T208951
Change-Id: Ice695dfb489974faa23ba19d74cf17b06e3f6075
2018-11-12 16:33:24 +00:00
Fomafix
965b496850
Replace jQuery by native JavaScript
...
Change-Id: I8ae88f9f569be61902e19f89c687b0188a7c099c
2018-09-11 21:15:07 +02:00
Ed Sanders
dec9c6321c
build: Enable more qunit lint rules
...
Where appropriate, convert assert.ok to assert.strictEqual.
Change-Id: I098ade9928958e8c2d36de221361d89b5c70ec35
2018-06-06 12:18:24 -07:00
Timo Tijhof
7ae8401c22
Avoid use of deprecated QUnit.asyncTest and QUnit.start/stop
...
Change-Id: I9cc132f71df072c724b6cff6f1d935abbe092596
2017-07-25 17:59:27 -07:00
Timo Tijhof
5bf1466e7f
Remove use of QUnit.test(, testCount, )
...
* Removed deprecated testCount, which is no longer supported in this way.
It's only useful when wanting to explicitly expect 0 assertions (normally
considered an error).
* Replaced use of testCount = 0, with assert.expect( 0 ).
Change-Id: I8fe82032d3af2a1ad2ed7febdb90a95d56dd3fc4
2017-07-26 00:12:06 +00:00
Ed Sanders
2264e5fdec
build: Update eslint to 0.4.0 and make a pass
...
Change-Id: I444cfd511121a0547901ed87c9aedd410e7920bd
2017-05-17 11:30:45 +01:00
Ed Sanders
9514e3107a
Code lint: Throw errors, no strings
...
Change-Id: I4bb4de96a5e61b67b7a4c8f16a22f67f53cb034f
2017-05-17 11:28:53 +01:00
Matthias Mullie
65c00b388c
Fix mmv.logging.DurationLogger qunit tests
...
Bug: T164473
Change-Id: I9787948e26d27e8fcee934e05e2c200eeec5d82f
2017-05-16 14:55:05 +00:00
Matthias Mullie
5bc3a2d90e
Fix mmv.logging.PerformanceLogger qunit tests
...
Bug: T164473
Change-Id: I6ae5c0170bf12fb076ddc505299ceeb7b9c292e8
2017-05-16 16:54:43 +02:00
Matthias Mullie
651476ccfb
Fix mmv.logging.ActionLogger qunit tests
...
Bug: T164473
Change-Id: I41f207519e27f63338298f68411fc2eb3eb7f13a
2017-05-16 16:53:39 +02:00
Matthias Mullie
934ed2d2dd
Fix mmv.logging.ViewLogger qunit tests
...
Bug: T164473
Change-Id: I11849743773e0382354009ccec1c8cb39c466aef
2017-05-16 14:52:49 +00:00
Ed Sanders
b46529d1b2
build: Introduce jshint & jscs and make a pass
...
These replace the hard-coded jshint task in CI.
Change-Id: Id14eec1ecba4ceae735ffd10f9114233a580302f
2016-07-19 13:48:06 -07:00
Gilles Dubuc
53a3d9a379
Make Media Viewer pluggable for the 3D extension
...
Some of the code encountered accessed mw.config directly,
I cleaned that up by migrating to mmv.Config, which is an
abstraction added to avoid peeking at mw.config directly.
Bug: T132064
Change-Id: I2a95ba703e6c7f46296f8e435bceec769dceebf9
2016-04-15 16:43:45 +02:00
Gergő Tisza
c3c549f1b4
Make logging less noisy in debug mode
...
Suppress logger console output if the logger is disabled.
Change-Id: I5f45bb7fc68f33880f8a4d1737f0055335fe5071
2015-02-19 23:50:04 +00:00
Fomafix
ae99be730e
Apply coding conventions for JavaScript
...
Change-Id: I57a8f188eb1152438a8e94235a6f6801e2617c28
2015-01-23 12:48:27 +00:00
Gilles Dubuc
30029b8b78
Track the most recent upload time for performance events
...
Change-Id: I673f9487deea15dc148452a3a4d6b91563a2c417
Bug: T76035
2014-12-03 16:15:20 +01:00
Gilles Dubuc
00d345f8b4
Rename Performance to PerformanceLogger
...
Change-Id: Iacfde35851cf8f617c4672d3ea466d4f0e2e448f
2014-11-21 11:07:40 +01:00
Gilles Dubuc
0e01796a3c
Track how long users are viewing images for
...
This is complete, but it would be better if the HEAD request
was actually aborted by Varnish when the viewDuration parameter is
present, or if the hit pointed to a script that does that.
Change-Id: I66cafd97427756411e967de1901324af2215e3ae
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/1001
2014-11-21 00:39:29 +01:00
Gilles Dubuc
c98a243639
Track image "unviews"
...
Change-Id: I4441b6df511f99b73bfafea0d804171435e129d2
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/998
2014-11-21 00:37:11 +01:00
Gilles Dubuc
6eb64f39ba
Track the most recent upload time for duration events
...
This will allow us to see if images uploaded recently, which have been
subjected to thumbnail prerendering, load faster.
Change-Id: I4ce358ff54e4ca4e290349aa3ff4810ad4714d24
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/975
2014-11-11 18:14:24 +01:00
Gilles Dubuc
0d743977dd
Fix issue with options dialog when media viewer has been reopened
...
- Fixes the bug where the options menu wouldn't open if media
viewer was reopened
- Adds human-readable console messages for the options actions
- Makes the tooltip a tipsy one like all the other buttons
- Fixes the tooltip copy, it was referring to "previews", which we
said we wouldn't do anymore, in favour of "Media Viewer"
Change-Id: I1590f9501cc6c406cc1f466b414062d4d6435c1b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/963
2014-10-23 15:29:44 +02:00
jenkins-bot
2203f89236
Merge "Log image dimensions"
2014-09-30 15:15:54 +00:00
Gergő Tisza
ff76011032
Log image dimensions
...
Also add a sanity test to attribution logging which I forgot at the time.
Change-Id: I3010e57eb74a76fee4078c415182a033375ea890
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/898
2014-09-30 14:55:47 +00:00
Gergő Tisza
2e4379c66e
Only add country field when it's in the schema
...
Change-Id: Id38ce4d20312bd15014cf37d521aac0a97bd660b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/907
2014-09-26 22:05:22 +00:00
Gergő Tisza
c4c262bf44
Move logging-related code to its own directory
...
Also make sure class and file names have the same case.
Change-Id: I21042e40030051326f8c55fd62a86a54e9011a4a
2014-09-04 23:34:45 +00:00
