wikimedia/mediawiki-extensions-MultimediaViewer
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer synced 2024-11-12 09:27:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Rough logging of metadata panel scrolling"

Browse source
This commit is contained in:
jenkins-bot 2014-12-09 09:53:50 +00:00 committed by Gerrit Code Review
parent 219315766e fdbefc27fc
commit 5c869aa9ec
3 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
MultimediaViewer.php
View file

@ -1062,7 +1062,7 @@ $wgResourceModules += array(
$wgHooks['EventLoggingRegisterSchemas'][] = function( array &$schemas ) { $wgHooks['EventLoggingRegisterSchemas'][] = function( array &$schemas ) {
$schemas += array( $schemas += array(
'MediaViewer' => 10536413, 'MediaViewer' => 10606177,
'MultimediaViewerNetworkPerformance' => 10596581, 'MultimediaViewerNetworkPerformance' => 10596581,
'MultimediaViewerDuration' => 10427980, 'MultimediaViewerDuration' => 10427980,
'MultimediaViewerAttribution' => 9758179, 'MultimediaViewerAttribution' => 9758179,

2
resources/mmv/logging/mmv.logging.ActionLogger.js
View file

@ -70,6 +70,8 @@
'image-view': 'User viewed an image.', 'image-view': 'User viewed an image.',
'metadata-open': 'User opened the metadata panel.', 'metadata-open': 'User opened the metadata panel.',
'metadata-close': 'User closed the metadata panel.', 'metadata-close': 'User closed the metadata panel.',
'metadata-scroll-open': 'User opened the metadata panel by scrolling.',
'metadata-scroll-close': 'User closed the metadata panel by scrolling.',
'next-image': 'User viewed the next image.', 'next-image': 'User viewed the next image.',
'prev-image': 'User viewed the previous image.', 'prev-image': 'User viewed the previous image.',
'terms-open': 'User opened the usage terms.', 'terms-open': 'User opened the usage terms.',

5
resources/mmv/ui/mmv.ui.metadataPanelScroller.js
View file

@ -222,8 +222,13 @@
if ( panelIsOpen && !this.panelWasOpen ) { // just opened if ( panelIsOpen && !this.panelWasOpen ) { // just opened
this.$container.trigger( 'mmv-metadata-open' ); this.$container.trigger( 'mmv-metadata-open' );
// This will include keyboard- and mouseclick-initiated open events as well,
// since the panel is anomated, which counts as scrolling.
// Filtering these seems too much trouble to be worth it.
mw.mmv.actionLogger.log( 'metadata-scroll-open' );
} else if ( !panelIsOpen && this.panelWasOpen ) { // just closed } else if ( !panelIsOpen && this.panelWasOpen ) { // just closed
this.$container.trigger( 'mmv-metadata-close' ); this.$container.trigger( 'mmv-metadata-close' );
mw.mmv.actionLogger.log( 'metadata-scroll-close' );
} }
this.panelWasOpen = panelIsOpen; this.panelWasOpen = panelIsOpen;
}; };