From fdbefc27fcf59e65e124ff54f8bdc5016b64323b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerg=C5=91=20Tisza?= Date: Tue, 25 Nov 2014 00:52:15 +0000 Subject: [PATCH] Rough logging of metadata panel scrolling Logs metadata panel open/close by scroll. When the panel is opened via keyboard or the "view terms" button, both a normal and a scroll opening event is logged (same for closing). When the panel is opened in fullscreen mode, neither event is logged. Change-Id: I09092b8b6c20e6fea03b4fe59c811d7b441ca224 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/559 --- MultimediaViewer.php | 2 +- resources/mmv/logging/mmv.logging.ActionLogger.js | 2 ++ resources/mmv/ui/mmv.ui.metadataPanelScroller.js | 5 +++++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/MultimediaViewer.php b/MultimediaViewer.php index e8f862836..e42147682 100644 --- a/MultimediaViewer.php +++ b/MultimediaViewer.php @@ -1062,7 +1062,7 @@ $wgResourceModules += array( $wgHooks['EventLoggingRegisterSchemas'][] = function( array &$schemas ) { $schemas += array( - 'MediaViewer' => 10536413, + 'MediaViewer' => 10606177, 'MultimediaViewerNetworkPerformance' => 10596581, 'MultimediaViewerDuration' => 10427980, 'MultimediaViewerAttribution' => 9758179, diff --git a/resources/mmv/logging/mmv.logging.ActionLogger.js b/resources/mmv/logging/mmv.logging.ActionLogger.js index 1a7d937c4..1e331478c 100644 --- a/resources/mmv/logging/mmv.logging.ActionLogger.js +++ b/resources/mmv/logging/mmv.logging.ActionLogger.js @@ -70,6 +70,8 @@ 'image-view': 'User viewed an image.', 'metadata-open': 'User opened the metadata panel.', 'metadata-close': 'User closed the metadata panel.', + 'metadata-scroll-open': 'User opened the metadata panel by scrolling.', + 'metadata-scroll-close': 'User closed the metadata panel by scrolling.', 'next-image': 'User viewed the next image.', 'prev-image': 'User viewed the previous image.', 'terms-open': 'User opened the usage terms.', diff --git a/resources/mmv/ui/mmv.ui.metadataPanelScroller.js b/resources/mmv/ui/mmv.ui.metadataPanelScroller.js index 8fa2733a9..7cd9a8efd 100644 --- a/resources/mmv/ui/mmv.ui.metadataPanelScroller.js +++ b/resources/mmv/ui/mmv.ui.metadataPanelScroller.js @@ -222,8 +222,13 @@ if ( panelIsOpen && !this.panelWasOpen ) { // just opened this.$container.trigger( 'mmv-metadata-open' ); + // This will include keyboard- and mouseclick-initiated open events as well, + // since the panel is anomated, which counts as scrolling. + // Filtering these seems too much trouble to be worth it. + mw.mmv.actionLogger.log( 'metadata-scroll-open' ); } else if ( !panelIsOpen && this.panelWasOpen ) { // just closed this.$container.trigger( 'mmv-metadata-close' ); + mw.mmv.actionLogger.log( 'metadata-scroll-close' ); } this.panelWasOpen = panelIsOpen; };