Commit graph

379 commits

Author SHA1 Message Date
Moritz Schubotz (physikerwelt) bd474256a6 Remove functional dead code about PNG images
* PNG images are no longer displayed as of
  I595926027433182cc0396570bc3f1ce0cd2cafb3
* Remove functional dead code about PNG images
* Replace some type hints with type delcarations

Bug: T311620
Change-Id: I283c23e327ef908cfb4c827599fdcdb16252b08c
2023-10-30 10:46:08 +00:00
Moritz Schubotz (physikerwelt) d878212655 style: Return early in evaluateRestbaseCheckResponse
* Put the status code into the logging context of unexpected errors

Change-Id: I9739eb4acc12a5dc23416a6db4d4df951cd9042a
2023-10-28 17:21:29 +00:00
Moritz Schubotz (physikerwelt) ca7205be3b
Identify errorous restBASE responses
In some cases restBASE seems to provide errorous responses
despite a 200 response code.
Check if all required fields exists and treat the response
as failed otherwise.

Bug: T349347
Change-Id: I3506401f8dd2962daf7fd5d30019c507f9de5def
2023-10-28 14:53:48 +02:00
jenkins-bot d916647b2f Merge "Fix error value in columnspacing attribute in mtable" 2023-10-27 16:11:30 +00:00
Stegmujo 184fcf44cb
Fix error value in columnspacing attribute in mtable
Bug: T349906
Change-Id: I4f5e472b37219ebab165dfbf6f364fd4d41146b9
2023-10-27 16:17:00 +02:00
jenkins-bot 9ba97826f4 Merge "Fix incorrect child count of some element" 2023-10-27 14:00:30 +00:00
Stegmujo 9e9ba0241a Fix incorrect child count of some element
- munder: if only one child munder is not added as wrapping mml tag
- msup: renders an empty mi if there is no content for the superscript

This prevents some warnings in firefox browser dev-console.

Bug: T349825
Change-Id: Ia5efc1f33e3368e71527153d56160eee4ba3a46d
2023-10-27 13:17:55 +00:00
jenkins-bot 413b21d3be Merge "Remove too many rows in smallmatrix" 2023-10-27 10:53:49 +00:00
Stegmujo a53a5d58c8
Remove too many rows in smallmatrix
* From Feedback: The {smallmatrix} example has its fences wrapped in too many mrows I think, so it renders without stretching them in both Firefox and Chrome. Ideally you should be able to emit the <mo>(</mo> followed directly by an <mtable>, and trailed by <mo>)</mo>, and only wrap those 3 into a parent <mrow>.
* removes mrows and adds OPEN / CLOSE attributes
* tests MMLFullcoverage 194 to ~196 which cover the bigXYZ macros look
  ok

Bug: T348971
Change-Id: Ie444e5bb3e3f87fac915d2692b69e976d721582e
2023-10-27 11:19:06 +02:00
Stegmujo 8112c65a5d
Remove mstyle around spacing elements
* From Feedback: There is a curious use of <mstyle> around spacing elements, as in <mstyle scriptlevel="0"><mspace width="-0.167em"></mspace></mstyle>. I am not sure that wrapper element is needed? The mspace ought to be successful standalone.
* this is in the 'bmod' case

Bug: T349822
Change-Id: I9229ad73891d5000679761d3d4b2028d4a51ddf1
2023-10-27 10:35:59 +02:00
Moritz Schubotz (physikerwelt) 06038f8bae
Log non json restbase responses
Bug: T343648
Change-Id: Idfa85c1be866af3c938353b31ba9a884ee5ab143
2023-10-25 14:14:17 +02:00
jenkins-bot 7eac3f09bb Merge "Remove utf8 encode / decode" 2023-10-23 20:15:33 +00:00
jenkins-bot f8d44c1caf Merge "Don't write native rendering to database" 2023-10-23 18:20:44 +00:00
Moritz Schubotz (physikerwelt) dd221cb1a2 Don't write native rendering to database
* Native uses WANObject cache and thus the db is
  not needed.

Change-Id: I2aec0c4bceb7db80dc24a716cabd7f2647709516
2023-10-22 15:29:50 +00:00
Moritz Schubotz (physikerwelt) 493a7ac9f0
native: Add onMathRenderingResultRetrieved hook
Allow in depth analysis of rendering results in
native mode with the same mechanism that is also
used for other rendering modes.

Change-Id: I4927f9bc683445f83ef7c29dc2a9298aa85ff4d0
2023-10-22 13:43:47 +02:00
Moritz Schubotz (physikerwelt) 804c026a61
Remove utf8 encode / decode
For old mysql versions utf8 encode decode was required to avoid
that math characters get messed up. This problem does not occur
with MariaDB 10.2. As now data is stored and retrieved as binary
by default, the data is returned in the same way as it is written.

Bug: T324173
Change-Id: Id29c9a8614156ff8170bc3148f2498b32c70fd8a
2023-10-22 07:41:56 +02:00
Moritz Schubotz (physikerwelt) e2ccab9687 Don't set purge in native mode
* Currently the native mode does always set render to true
  there is no reason to do, as this was initially introduced
  for testing.

Change-Id: I632ca5ea726d055f377439e439a39baca3bed385
2023-10-19 17:39:45 +00:00
Stegmujo aa5bba5bf9
Add a cache purging action for URL for Math rendering
* MathRenderer passes purge state, the purge state has to be rechecked
  since implicitly it is true in the MathRenderer
* for rechecking a new flag is introduced to isPurge function

Bug: T348976

Change-Id: Ifdcea4b2c17ac963a50ee48e2d6437c0feafc602
2023-10-19 18:43:23 +02:00
jenkins-bot d54a562d8f Merge "Fix: Handle null errors" 2023-10-17 18:52:48 +00:00
Stegmujo 24bcd11e5b Fix ce statements and displaystyle for chem rendering on wikipages
* rollback some previous changes for ce env in Parserhookhandler
* some minor fixes for feedback in previous commit
* set tex mode for mhchem preprocessor, since MediaWiki Hooks add
  explicit ce tags: i.e. frormula coming to TexVC look like
  "{\displaystyle \ce{ C6H5-CHO }}"

Bug: T348975
Change-Id: Id06852b030f9ea77f016289d4f9e2258d5a9f0d4
2023-10-17 14:37:25 +00:00
Stegmujo 5cce2b4512 Activate mhchemParser in PHP also in native rendering
* before an explicit fallback was used to standard MathML mode
* now, in addition native MathML mode can also be used
* added interface code activating texvc for chemical formulas correctly
* ParserHooksHandler removes implicit ce environment for native chem
  rendering

Bug: T348975

Change-Id: If2bbc7223d253d78e837eec2e007dd8171aa6349
2023-10-16 21:51:17 +00:00
Moritz Schubotz (physikerwelt) 9a4d6c50fe
Fix: Handle null errors
BaseChecker::getError may be null, thus handle the
case when the error is null and output
unknown_error in that case.

Bug: T348973
Change-Id: I072ebf200139436b4f27a90dfe940cb310886b28
2023-10-16 21:54:33 +02:00
Umherirrender f9f9f5dcd6 Use the expression assignment operator to simplify code
Suggested by phan, available since php7.4

Change-Id: I77c189ed451d08125fd6a6a008c55472cf3d046c
2023-10-14 00:53:38 +02:00
Stegmujo 9360ca94c4
Fix table alignment to left
* currently, \begin{align} generates <mtable columnalign="right" but it should be <mtable columnalign="left"

Bug: T348791
Change-Id: Ic0df45aba4fdb6ffbdc790b5e4bc56e7daeca802
2023-10-13 15:08:34 +02:00
Stegmujo 1aae7cde53
Deactivate stretchy attribute in left and right
Bug: T348793
Change-Id: I5c7c1fd02c4fb42eb8478b744fea3dd06463401e
2023-10-13 13:58:57 +02:00
Stegmujo 00f47e8866 Fix issues in MMLmhchemTest with braces and macro longrightleftharpoons
* updating the braces since mkern, mskip etc are Fun1 functions in TexVC
* updating TexVC support flag in test
* added macro longrightleftharpoons to rendered cases
* nearly all tests render correct in HTML now

Bug: T329620
Change-Id: I78da466c88d41f794e81f7222c9a67c3f4d482d2
2023-10-12 15:55:43 +00:00
Stegmujo 846edd1611 Add intbar and intBar to MathML rendering
* added some tests
* removing intbar from skipped tests in MMLGenTexUtilTest

Bug: T348318
Bug: T137787
Change-Id: If0dd9beb36d52bc5305fdb66438f1ad2ca092aaf
2023-10-10 10:19:45 +00:00
Moritz Schubotz (physikerwelt) 272f39ca2d
Fix integral command namings
* Remove \strokeint which was probably a typo and should be \strokedint
* Add \intBar command

Not done:
* Implement rendering of \intBar and \intbar, it would make sense to wait for
the mathoid reference rending here, which is just around the corner

Bug: T137787
Bug: T348373
Change-Id: I19d24fc23f59dda87c7c39a265f17efddb9fee8f
2023-10-09 15:02:46 +02:00
jenkins-bot d5c48b8260 Merge "Render MathML for atop and choose" 2023-10-05 16:20:25 +00:00
Stegmujo bbe6c3df8b Render MathML for atop and choose
Bug: T340024
Change-Id: I19f471645b569db49a64e5dd4c82cfdbac7dbe77
2023-10-05 14:39:04 +00:00
Stegmujo d3c636883a
Render MathML for some letters used in mhchem
* \Alpha  \Beta  \Chi  \Epsilon  \Eta  \Iota  \Kappa  \Mu  \Nu  \Omicron  \Rho  \Tau  \Zeta
* \ca

Bug: T340024
Change-Id: I0d9d8314644927ccae0794ae8459a3f3893fc24a
2023-10-05 16:08:13 +02:00
Stegmujo 7dfb557b92
Render MathML for harpoons and arrows for mhchem
* macros: longRightleftharpoons, longLeftrightharpoons,
  longleftrightarrows
* added tests for these

Bug: T340024
Change-Id: Ib8487f242766cef63f7cf8564f2033d9f332e0a8
2023-10-04 18:47:14 +02:00
Stegmujo 0c493bbbed Render MathML for tripledash for mhchem
* rendering textemdash for tripledash with unicode +2014

Bug: T340024
Change-Id: I2c68858063d7fe4e1d673522f6a2d58107fa3f7e
2023-10-04 13:04:17 +00:00
Stegmujo 372bf72acd Render MathML for mathchoice for mhchem
* defaults mathchoice to displaystyle
* adds several tests and introduces new Fun4 element for mathchoice in
  grammar

Bug: T340024
Change-Id: I37c8fd35303e3b8a00faad18a3a131a716c7bb47
2023-10-04 11:23:02 +00:00
jenkins-bot a801869ebb Merge "Add mhchem-tex macros to MMLGenerationTexUtilTest" 2023-10-04 11:05:14 +00:00
Stegmujo 759e6166f6
Add mhchem-tex macros to MMLGenerationTexUtilTest
* adds the recently implemented cases for mhchem specific tex to check full macro coverage
* fix a minor issue with tripledash

Change-Id: Id3033fab7b3c3432bed6e11f7b50f7ff8e3906ea
2023-10-04 10:57:12 +02:00
jenkins-bot f15dd203ab Merge "Fix tilde spacing" 2023-09-29 11:48:36 +00:00
Stegmujo 414295cdc5
Fix tilde spacing
* tilde is rendered as non escaped mspace

Bug: T315978
Change-Id: I33a751eb5ae62a45c7bc3941ff49f30fa436b00c
2023-09-29 12:19:28 +02:00
jenkins-bot 5dd7d8cba3 Merge "Fix alignments" 2023-09-28 17:13:32 +00:00
Stegmujo 6c43c7563c Fix escape spacing
* In test "\text{if}~n\ \text{is even} "

Bug: T315978
Change-Id: I839b7e912bc95abff1f589467c848fc8b2fb0fe6
2023-09-28 15:54:19 +00:00
Stegmujo 07f7942ac5 Fix alignments
*  "\ln c, \lg d = \log e, \log_{10} f" : c d etc should have be more extra space
* "\Pr j, \hom l, \lVert z \rVert, \arg z ": same as above, specifically for \hom
* fixes expected result in LocalCheckerTest

Bug: T315978
Change-Id: I842b45b2d20dc267d828dca2040a3500ce06f45d
2023-09-28 15:48:18 +00:00
Stegmujo 093ecf7c0f
Fix bigcap and bigcup scripts not placed correctly
* All recognized macros are in category nullary macros, so this adds a
  rule
* In test "\bigcap_{i=_1}^n E_i"
* In test "\bigcup_{i=_1}^n E_i"

Bug: T315978
Change-Id: I09287879c1448e404473891985457349a62554a7
2023-09-27 14:17:53 +02:00
jenkins-bot 4d3f6adc8f Merge "Move error to merror tags" 2023-09-27 11:24:25 +00:00
Stegmujo cbd830a934
Move error to merror tags
Bug: T315978
Change-Id: I8e0515a168a5983c24dac8a64e7a2f7fd1805a8d
2023-09-27 12:48:26 +02:00
jenkins-bot 21d3cf0f8f Merge "Fix oint size" 2023-09-27 10:47:38 +00:00
Stegmujo 0728ed4bd1 Fix oint size
* In several tests with preceding oint
* Add explicit testcase

Bug: T315978
Change-Id: I87b31490ed18461fec0cf4ebd6a2c207235ee734
2023-09-27 09:39:50 +00:00
Stegmujo b3545c1994
Fix negation (not) for operatorname
* Test example in MathNativeTests: " "\not\operatorname{R}"
* fixed forwarding state in Fun1nb

Bug: T315978
Change-Id: Ia651b14ba16f39cc8cbc6b42e0598d959bf72989
2023-09-27 10:39:27 +02:00
Stegmujo ede31d01ed Fix k=1 should appear under sum in displaystyle
* In test MathNativeTests: "\sum_{k=1}^N k^2"
* also verify that textstyle variant works correctly

Bug: T315978
Change-Id: I8f6cd5ef1e4539616439542184cb7d9dc5cf2363
2023-09-26 16:07:20 +00:00
Stegmujo f85fda42da Fix MMLGenerationParserTest creating HTML file
* also fixes a warning in phan that there is a tainted parameter in args in BaseParsing
* this is to pass CI

Bug: T343636
Bug: T347320
Change-Id: I91328bf26e208bd4e0e939c4628def2f40e2f0b6
2023-09-26 15:26:30 +00:00
jenkins-bot df4404456a Merge "Add mw-invert class to <img> which generates text" 2023-09-23 09:00:19 +00:00