wikimedia/mediawiki-extensions-Gadgets
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Gadgets synced 2024-12-23 12:12:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
1322 commits 15 branches 25 tags 23 MiB
Commit graph

1322 commits

This branch
This branch
All branches
Author SHA1 Message Date
Timo Tijhof dc834f3933 Implement support for specifying type=styles 
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().

Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).

In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().

For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).

The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.

Impact:

* [Bug fix] When mw.loader requires a styles module that already loaded,
            it will not load again.

* [Feature] It is possible for a general scripts+styles gadget to depend on
            a styles gadget. Previously this caused the styles to load twice.

* Specifying type=styles will load the module through addModuleStyles() only.

  Use this for modules that contain styles that relate to elements already
  on the page (e.g. when customising the skin, layout, or article content).

* Specifying type=general will load the module through addModules() only.

  Use this if your module contains both scripts and styles and the styles
  only relate to elements created by the script. This means the styles do not
  need to be loaded separately through addModuleStyles() and will not apply
  to noscript mode.

Effective difference:

* Gadgets with only styles: We assume type=styles.

  This fixes the main bug (styles loading twice) and requires no migration!

* Gadgets with only scripts: We assume type=general.

  This requires no migration! (And: No more empty stylesheet request)

* Gadgets with scripts (with or without styles): We assume type=general, but
  unless type=general was explicitly set we'll still load it both ways so
  that the styles apply directly on page load.

  If this is not needed, set type=general.

  If this is needed, it should become two separate modules. We do not support
  a single module having two purposes (1: apply styles to the page,
  2: provide scripts+styles). The styles module should be separate.
  It can be made hidden, and listed as dependency of the other module.

The latter case is detected on page load and results in a console warning
with a link to T42284.

Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
 2016-09-30 10:43:29 +00:00
Translation updater bot 7b97752434 Localisation updates from https://translatewiki.net. 
Change-Id: Ib803b6cceefc933396df011e8ff6a060e6d53c45
 2016-09-28 22:24:59 +02:00
Translation updater bot e7d4897053 Localisation updates from https://translatewiki.net. 
Change-Id: I361558c5be2c437255017268a8b000c1a23f4ff2
 2016-09-27 22:36:52 +02:00
Translation updater bot 33ed4c847e Localisation updates from https://translatewiki.net. 
Change-Id: I23a0a0e95e8b94f7f4d100218af1247cb8b0c973
 2016-09-23 22:33:37 +02:00
Translation updater bot b832ba78c6 Localisation updates from https://translatewiki.net. 
Change-Id: I518cfe6966c2c1f08ae768d842fb937619c32d01
 2016-09-22 23:38:20 +02:00
Translation updater bot 83236f356b Localisation updates from https://translatewiki.net. 
Change-Id: Idc0aad9652cc5ca8ab4d6ab178830a29a2af3356
 2016-09-19 22:55:11 +02:00
Translation updater bot 048c23d3c4 Localisation updates from https://translatewiki.net. 
Change-Id: I86a4332e0d21f38435d1570830cd25771ed6f664
 2016-09-17 23:19:03 +02:00
Translation updater bot 89b7e6bb55 Localisation updates from https://translatewiki.net. 
Change-Id: I187984682d92e79a5aa656963a32ed8955e4accd
 2016-09-15 22:59:53 +02:00
Translation updater bot 07492f8938 Localisation updates from https://translatewiki.net. 
Change-Id: If62ef95757c4c5913bc1e3d632b6833983886bbc
 2016-09-14 22:35:15 +02:00
Translation updater bot 9c32d93d8f Localisation updates from https://translatewiki.net. 
Change-Id: I96f3dc2787a9a1f16cab386fec8d2ff16b83cee9
 2016-09-13 22:51:12 +02:00
Translation updater bot 13d486ee33 Localisation updates from https://translatewiki.net. 
Change-Id: I684874294188a577e661d909dbeb0bd7dc3282d5
 2016-09-12 23:04:45 +02:00
Translation updater bot 3fc9db069c Localisation updates from https://translatewiki.net. 
Change-Id: I4382e37ce0f00cf3fda9d06648ec9a6c13b6182e
 2016-09-09 22:55:20 +02:00
Translation updater bot 20eed006b9 Localisation updates from https://translatewiki.net. 
Change-Id: I477bc199a50af4ecd9ba46cc8778a28a1ed67b61
 2016-09-08 23:44:45 +02:00
Translation updater bot 08944c2162 Localisation updates from https://translatewiki.net. 
Change-Id: If7e023c4e2875221d94e78a346f33f0aa489a240
 2016-09-01 23:24:51 +02:00
Translation updater bot a971be91f4 Localisation updates from https://translatewiki.net. 
Change-Id: I32d5cee3cf5c44a72085168ddaeaeaf273765858
 2016-08-28 22:37:08 +02:00
Translation updater bot 46fb40bcc8 Localisation updates from https://translatewiki.net. 
Change-Id: Id0233ecaa08a92f99a09e85f4945bc948a389b95
 2016-08-16 22:42:24 +02:00
Translation updater bot d84db79118 Localisation updates from https://translatewiki.net. 
Change-Id: I9bca53f3d2b7affde4f8eee294d0a02f649a85a4
 2016-08-13 22:29:31 +02:00
Translation updater bot 7cea0f88ce Localisation updates from https://translatewiki.net. 
Change-Id: I63ffb91a48298fcba75e8458f62e47db93d41211
 2016-08-12 23:11:24 +02:00
Translation updater bot 1965b6db1c Localisation updates from https://translatewiki.net. 
Change-Id: I8897f322d26e44853f166dc1d37f7f1a4bb111f7
 2016-08-11 23:53:52 +02:00
Translation updater bot ca9461ebaf Localisation updates from https://translatewiki.net. 
Change-Id: Ic6925a4accaf72d51cd56a92e1d05b42a888f18f
 2016-08-09 22:30:13 +02:00
Reedy 34795a8803 Remove 'UnitTestList' hook 
No longer needed now that extension unittests are autodiscovered.

Bug: T142120
Bug: T142121
Change-Id: I89cfc1ea3e652ebec1cd67f62810586c4ef49574
 2016-08-06 01:14:53 -07:00
Kunal Mehta 5257a2112c Unbreak tests 
Bug: T142236
Change-Id: Id30ea70a00a8e3ebcd71801cbbab694f99ce3f00
 2016-08-06 01:14:09 -07:00
Translation updater bot 870ba3b26e Localisation updates from https://translatewiki.net. 
Change-Id: I5b6098d49d7b6b0e5d3655a5c098224220321163
 2016-07-30 22:26:01 +02:00
Translation updater bot 306bd888f7 Localisation updates from https://translatewiki.net. 
Change-Id: I806858ae36fc0fa72442ebc1e5c05d15861272c3
 2016-07-25 22:24:22 +02:00
Translation updater bot ec3e053cf1 Localisation updates from https://translatewiki.net. 
Change-Id: I1f8b8fd720e385f294fda286850b896595e5654f
 2016-07-12 22:49:08 +02:00
Translation updater bot 94f6dacb2d Localisation updates from https://translatewiki.net. 
Change-Id: Ibdffbc75553d6d3828aa8f01b5519ba144f5ab4a
 2016-07-11 22:56:45 +02:00
Translation updater bot cfde0d304f Localisation updates from https://translatewiki.net. 
Change-Id: Idb403b944fa5e5d66ca2789f07dcfa2a3403abc6
 2016-07-10 22:20:55 +02:00
Translation updater bot e6a6875488 Localisation updates from https://translatewiki.net. 
Change-Id: Ice264fee026c9ca675a9d399cfcbd9f66aef8b01
 2016-07-01 23:20:59 +02:00
Translation updater bot 3fcf4621b9 Localisation updates from https://translatewiki.net. 
Change-Id: Idf257e83d955c908222d7b5fd6c6f1d937e77a3a
 2016-06-27 23:04:36 +02:00
Translation updater bot 98acb349c8 Localisation updates from https://translatewiki.net. 
Change-Id: I4b293e5cb1353b78b2f53b575d41396f2f8bb8c2
 2016-06-26 14:16:16 +02:00
Remko de Keijzer (Mbch331) 13ff6e3047 Added Dutch translation 
Bug: T138183
Change-Id: Icf673c64a284942f515d625fec9322be9e5321fc
 2016-06-25 16:27:23 +02:00
Translation updater bot 8b43b2e5da Localisation updates from https://translatewiki.net. 
Change-Id: I4375ecfcd16c4bd89de14d815cc63ccb1d45b7dc
 2016-06-25 14:52:32 +02:00
Translation updater bot 071875ac05 Localisation updates from https://translatewiki.net. 
Change-Id: I7357773f7e395aa53e9bedf10ab8f9e432ba94f9
 2016-06-24 11:10:35 +02:00
Translation updater bot 811e304e27 Localisation updates from https://translatewiki.net. 
Change-Id: I4260c5408dcb7d0f4a545d33aed4982aa62011fd
 2016-06-21 23:29:13 +02:00
Translation updater bot a62ab6b980 Localisation updates from https://translatewiki.net. 
Change-Id: I466bff7a1244d9ef1a0605a8a71d3229930c448a
 2016-06-13 22:57:13 +02:00
Translation updater bot 8158641b22 Localisation updates from https://translatewiki.net. 
Change-Id: Ib3cdeb22b26708f6ed197f07bbef553b79ea8fad
 2016-06-10 22:16:08 +02:00
Translation updater bot 44930706f1 Localisation updates from https://translatewiki.net. 
Change-Id: I41aca9bc9baa266d61dca21623344172f024dd64
 2016-06-08 22:28:10 +02:00
Translation updater bot 43b775f42b Localisation updates from https://translatewiki.net. 
Change-Id: I8bc972a953dc654a161136ae999240dbb996bd56
 2016-06-07 22:44:01 +02:00
Translation updater bot 8c11a3f4ff Localisation updates from https://translatewiki.net. 
Change-Id: I398a4e986743aacf6a7daf49f1467e823a25381f
 2016-06-05 22:19:53 +02:00
Translation updater bot aac10d6903 Localisation updates from https://translatewiki.net. 
Change-Id: Id39939f378793d51d4502bcb4a9cbddf46455e7f
 2016-06-03 23:19:12 +02:00
Kunal Mehta 1350d7e41b Use tabs for indenting Gadget definition pages 
For consistency with rest of MediaWiki, especially CodeEditor.

Note that this will cause dirty diffs for any definition pages created
before this patch, but that's not a big deal.

Change-Id: I3ed4b4aa7d18c489b9a322f67ea6ea31e610a257
 2016-05-31 00:23:12 +00:00
Translation updater bot 579d82f616 Localisation updates from https://translatewiki.net. 
Change-Id: I9fda9729d95b398aeed64a6791a6d1a994a5f6bc
 2016-05-29 22:29:15 +02:00
Translation updater bot de8886feb5 Localisation updates from https://translatewiki.net. 
Change-Id: I3888cd62c61d00697695c675ab1028a2ed1f6d81
 2016-05-23 22:25:06 +02:00
Translation updater bot 688d7a310a Localisation updates from https://translatewiki.net. 
Change-Id: I6d3e296ae1d14525982e06be74a6ba1f7840b7e7
 2016-05-20 22:27:57 +02:00
Translation updater bot 302b7d2582 Localisation updates from https://translatewiki.net. 
Change-Id: I9a2cfc692c453333b22abdc3cd5302adf18fbd16
 2016-05-17 22:22:05 +02:00
Translation updater bot 9db2f23e5c Localisation updates from https://translatewiki.net. 
Change-Id: I95c0a958ced6e614b38b4f2b20a4d1d0683dcd19
 2016-05-03 22:25:15 +02:00
Translation updater bot 24ebd27c37 Localisation updates from https://translatewiki.net. 
Change-Id: I5ad29cce9b812c7e485fc283c337b68f09c6dd60
 2016-04-24 22:34:11 +02:00
Translation updater bot 396f87b8d2 Localisation updates from https://translatewiki.net. 
Change-Id: I40576f6bd0ebc6ea006b3e2df93d002780750f6a
 2016-04-23 22:21:53 +02:00
Raymond f1ba2341e4 Add namespace translation for diq 
https://translatewiki.net/wiki/Thread:Translating_talk:MediaWiki/Namespace_translation_for_diqwiki

Change-Id: I845c61ade67cfa550c38ba7f7ce10dfc2e8067d0
 2016-04-22 10:21:09 +02:00
Translation updater bot 403755eff1 Localisation updates from https://translatewiki.net. 
Change-Id: I7710bacb5f7e66e6202440c41199ed3166b57ff6
 2016-04-19 22:21:02 +02:00