wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 07:54:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Echo/includes
History
Thiemo Kreuz acba72e011 Remove expensive regular expression that doesn't have any effect 
See, this last part of the compiled regular expression is wrapped in
an (…)*, which means it is entirely optional. It does not make any
difference if this part is found or not. The compiled regular
expression matches with or without any of these "line ending"
fragments being present.

I can not really figure out what the intention of this was. A line
ending anchor ($) is not missing – I'm pretty sure about this.
Otherwise it could not detect signatures that are wrapped in more
than a single HTML tag, for example.

Instead of fixing it I decided to remove it. The tests should show
this code was not needed.

The motivation for this patch is to improve performance. This part of
the regular expression is quite heavy and can cause a lot of
backtracking for literally zero benefit.

Bug: T203930
Bug: T204291
Change-Id: Ia5323b401b947edeb7094d7eec131ba6c80edf70
2018-09-25 18:15:49 +02:00
..
api ApiCrossWiki: Handle needsToken() returning false 2018-09-18 17:21:50 -04:00
cache cache: Reduce responsibility of subclass and remove unused parts 2018-08-17 03:28:02 +00:00
controller Add missing newlines before "use" sections 2018-08-13 09:29:32 +02:00
exception
formatters Merge "Make markasread parameter work cross-wiki" 2018-09-05 12:40:34 +00:00
gateway Initialize $success 2018-08-24 06:15:12 -04:00
iterator Fix some doc blocks 2017-11-07 17:06:17 +01:00
jobs NotificationMapper: Use batching in deleteByUserEventOffset() 2018-08-08 14:57:58 -07:00
mapper Split long lines over 140 chars 2018-08-25 12:51:14 +02:00
model Merge "Fix missing/mismatching type hints PHPDoc tags" 2018-08-16 08:39:29 +00:00
ooui Improve some parameter docs 2017-10-18 18:44:52 +02:00
special Build: Make pass phan-taint-check 1.5.0 2018-09-14 02:04:03 +00:00
AttributeManager.php Merge "Fix common typos in code" 2018-08-27 11:33:30 +00:00
Bundleable.php Remove some non-helpful lines of documentation 2018-07-06 15:14:44 +00:00
Bundler.php build: Update mediawiki/mediawiki-codesniffer to 0.7.1 2016-12-05 15:54:30 -08:00
DataOutputFormatter.php Build: Make pass phan-taint-check 1.5.0 2018-09-14 02:04:03 +00:00
DeferredMarkAsDeletedUpdate.php Merge "Make "@… array" type hints more specific" 2018-08-16 00:57:12 +00:00
DiscussionParser.php Remove expensive regular expression that doesn't have any effect 2018-09-25 18:15:49 +02:00
EchoArrayList.php Fix multiple PHP class declarations in one file 2018-01-21 21:17:53 +00:00
EchoCachedList.php CachedList: Use getWithSetCallback() 2018-05-30 05:15:20 +00:00
EchoContainmentList.php Make "@… array" type hints more specific 2018-08-13 09:27:37 +02:00
EchoContainmentSet.php Get rid of special casing for user blacklist 2018-07-09 15:50:38 -07:00
EchoDbFactory.php Merge "Use "false" as type hint in PHPDoc tags" 2018-08-16 01:00:05 +00:00
EchoDiffGroup.php Make "@… array" type hints more specific 2018-08-13 09:27:37 +02:00
EchoDiffParser.php Fix common typos in code 2018-08-25 17:35:13 +00:00
EchoHooks.php Make markasread parameter work cross-wiki 2018-09-03 10:59:31 -07:00
EchoOnWikiList.php Fix multiple PHP class declarations in one file 2018-01-21 21:17:53 +00:00
EchoSummaryParser.php Don't ping from user talk links in summary 2018-03-08 14:36:58 -08:00
EmailBatch.php Drop $wgNotificationReplyName, instead let just show the e-mail 2018-08-29 01:03:54 +00:00
EmailFormat.php HTML email formatter using presentation model 2016-05-12 09:29:24 -04:00
EmailFrequency.php HTML email formatter using presentation model 2016-05-12 09:29:24 -04:00
EventLogging.php Clean up EventLogging integration 2018-08-09 14:19:45 +00:00
ForeignNotifications.php build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 2018-09-03 01:46:10 +00:00
ForeignWikiRequest.php Add cross-wiki proxying to the action=markasread API 2018-09-03 08:07:39 -07:00
Notifier.php Drop $wgNotificationReplyName, instead let just show the e-mail 2018-08-29 01:03:54 +00:00
NotifUser.php Make markasread parameter work cross-wiki 2018-09-03 10:59:31 -07:00
ResourceLoaderEchoImageModule.php Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php 2017-03-27 23:46:45 +00:00
schemaUpdate.php Improve some parameter docs 2017-08-09 17:21:10 +02:00
SeenTime.php Merge "Use "false" as type hint in PHPDoc tags" 2018-08-16 01:00:05 +00:00
UnreadWikis.php Merge "Use "false" as type hint in PHPDoc tags" 2018-08-16 01:00:05 +00:00
UserLocator.php Fix page-linked notifications 2018-08-27 10:46:39 -07:00