mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo
synced 2024-11-24 07:54:13 +00:00
acba72e011
See, this last part of the compiled regular expression is wrapped in an (…)*, which means it is entirely optional. It does not make any difference if this part is found or not. The compiled regular expression matches with or without any of these "line ending" fragments being present. I can not really figure out what the intention of this was. A line ending anchor ($) is not missing – I'm pretty sure about this. Otherwise it could not detect signatures that are wrapped in more than a single HTML tag, for example. Instead of fixing it I decided to remove it. The tests should show this code was not needed. The motivation for this patch is to improve performance. This part of the regular expression is quite heavy and can cause a lot of backtracking for literally zero benefit. Bug: T203930 Bug: T204291 Change-Id: Ia5323b401b947edeb7094d7eec131ba6c80edf70 |
||
|---|---|---|
| db_patches | ||
| i18n | ||
| images | ||
| includes | ||
| maintenance | ||
| modules | ||
| scripts | ||
| tests | ||
| .eslintrc.json | ||
| .gitignore | ||
| .gitreview | ||
| .mailmap | ||
| .phpcs.xml | ||
| .stylelintrc.json | ||
| CODE_OF_CONDUCT.md | ||
| composer.json | ||
| COPYING | ||
| Echo.alias.php | ||
| echo.sql | ||
| extension.json | ||
| Gruntfile.js | ||
| jsduck.external.js | ||
| jsduck.json | ||
| jsduck_custom_tags.rb | ||
| Makefile | ||
| package.json | ||
| RELEASE_NOTES | ||