Go to file
Moriel Schottlender a7aae23806 Remove read item from counter after it was actually marked as read
We removed the item first from the 'unread' counter and then told
the API to mark it as read. The API, however, wisely first checks
if there is anything *to* mark as read, but by that point, the
unread count is zero, so it gracefully refuses and returns an
empty resolved promise.

That is clearly not the way to go. Remove the read item from its
smart unread counter only **after** it was sent to the API to be
marked as read.

Note: We shouldn't wait for the API promise to resolve to remove
the item from the counter, but the API should run its preliminary
tests before the item is removed.

Bug: T122087
Change-Id: Ia5fc35c7435db8c4742238897da67681cee23c41
2015-12-21 15:13:29 -08:00
db_patches
i18n Localisation updates from https://translatewiki.net. 2015-12-21 22:04:12 +01:00
includes Merge "Add mw-echo-payload class to body in Special:Notifications as well" 2015-12-19 10:16:21 +00:00
maintenance
modules Remove read item from counter after it was actually marked as read 2015-12-21 15:13:29 -08:00
scripts
tests
.csslintrc
.gitignore
.gitreview
.jscsrc
.jshintignore
.jshintrc
.rubocop.yml
autoload.php
composer.json
COPYING
Echo.alias.php
Echo.php Clarify link and revert icons on notifications 2015-12-17 20:04:33 +00:00
echo.sql
Gemfile
Gemfile.lock
Gruntfile.js
Hooks.php
Makefile
Notifier.php
package.json
phpcs.xml
Rakefile
RELEASE_NOTES
Resources.php