mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo
synced 2024-11-24 07:54:13 +00:00
a7aae23806
We removed the item first from the 'unread' counter and then told the API to mark it as read. The API, however, wisely first checks if there is anything *to* mark as read, but by that point, the unread count is zero, so it gracefully refuses and returns an empty resolved promise. That is clearly not the way to go. Remove the read item from its smart unread counter only **after** it was sent to the API to be marked as read. Note: We shouldn't wait for the API promise to resolve to remove the item from the counter, but the API should run its preliminary tests before the item is removed. Bug: T122087 Change-Id: Ia5fc35c7435db8c4742238897da67681cee23c41 |
||
---|---|---|
db_patches | ||
i18n | ||
includes | ||
maintenance | ||
modules | ||
scripts | ||
tests | ||
.csslintrc | ||
.gitignore | ||
.gitreview | ||
.jscsrc | ||
.jshintignore | ||
.jshintrc | ||
.rubocop.yml | ||
autoload.php | ||
composer.json | ||
COPYING | ||
Echo.alias.php | ||
Echo.php | ||
echo.sql | ||
Gemfile | ||
Gemfile.lock | ||
Gruntfile.js | ||
Hooks.php | ||
Makefile | ||
Notifier.php | ||
package.json | ||
phpcs.xml | ||
Rakefile | ||
RELEASE_NOTES | ||
Resources.php |