Commit graph

1021 commits

Author SHA1 Message Date
jenkins-bot 6d9fba9e7e Merge "NotificationItemWidgets: Remove property setting duplicated from parents" 2018-05-29 21:20:31 +00:00
Volker E b3b9720733 build: Extend 'svgmin' options and move to 'minify' task
Also re-crush all SVGs.

Bug: T185596
Change-Id: I9f2be4b1b5c4c0597d4040250d87c939567cb83b
2018-05-29 10:26:22 -07:00
Ed Sanders e0770024cf Update icons to latest WMUI designs
Bug: T183749
Change-Id: I620438adef9ad0c39e66a790c29efb30af556cdd
2018-05-23 23:49:55 +00:00
Ed Sanders 9de02857ae Replace .parent with .super
Also remove unused config fallbacks

Change-Id: I10b1ffc0cf69c52c4394f27c02aac5bca2473374
2018-05-22 15:56:46 +01:00
Ed Sanders 3b4be7b6c5 NotificationItemWidgets: Remove property setting duplicated from parents
Change-Id: I03c83d3cfb6ce22ccca0cc2dc1d1e20b36d739c8
2018-05-22 15:54:55 +01:00
Ed Sanders e204977063 Make 'links' a required argument of NotificationBadgeWidget
Change-Id: Ib1ae2cf1edc1d0a280eb62558d93d081f365ca84
2018-05-22 15:42:45 +01:00
Roan Kattouw af323781ab Follow-up 8b84ed2a3: fix eslint failure that snuck in somehow
Change-Id: Iad32afab81d1fc161b2f1e7f04bd8cd89937527e
2018-05-19 14:36:55 +02:00
jenkins-bot b926673987 Merge "Sticky toolbar: Add missing vendor prefix" 2018-04-30 22:56:43 +00:00
jenkins-bot 4538925597 Merge "Conditionally rearrange date and button in notif list" 2018-04-13 18:25:38 +00:00
jenkins-bot f5d47b3ee7 Merge "Revert "Revert "Remove unused 'trash' icon""" 2018-04-12 15:37:42 +00:00
Catrope ee44f96e2f Revert "Revert "Remove unused 'trash' icon""
Can be removed now that it's been moved to PageTriage.

This reverts commit b59eedd251.

Change-Id: If829148d09cb28f21bd48d5073886b44174b274d
Depends-On: I370391d7460c5b04a5a1ddb2e191f29044b30e5e
2018-04-11 19:54:35 +00:00
jenkins-bot caa28b5e6b Merge "Revert "Remove unused 'trash' icon"" 2018-04-05 19:53:44 +00:00
Catrope b59eedd251 Revert "Remove unused 'trash' icon"
Still being used by PageTriage.

The proper solution is to move the icon to PageTriage, but
for now let's bring it back in Echo to unbreak things.

This reverts commit 54f49875e9.

Bug: T191335
Change-Id: If4c709d9932ac0d063f6211c5ddd82846f0f6a6d
2018-04-05 19:07:04 +00:00
Moriel Schottlender 5a42e71171 Add extra margin for the badge when count is 99+
Bug: T183539
Change-Id: I57060bc9c442d4fc030608f9f6de98b77f5e1133
2018-03-28 19:44:38 +03:00
Moriel Schottlender 8b84ed2a3b Conditionally rearrange date and button in notif list
When there isn't enough space for both date and button,
separate them each on its own line.

Bug: T146288
Change-Id: I7ad022da82503f35ae630d171faeed1815c97f7a
2018-03-28 16:19:47 +03:00
Roan Kattouw 1eef6eeee3 Remove footer notice code
But keep the widget files in case we need them again.

Bug: T190481
Change-Id: Iec7dd472cebbee98ea88a0318c017707c7460ae8
2018-03-28 14:57:44 +02:00
jenkins-bot 2cf4bd1df3 Merge "Align Notifications popup header/footer with OOUI's default size" 2018-03-27 21:03:38 +00:00
jenkins-bot bc511b4af2 Merge "NotificationsOptionWidget: Fix icon alignment" 2018-03-27 21:00:26 +00:00
jenkins-bot ae9ee9bc35 Merge "Prevent FOUC when loading OOUI notification badges" 2018-03-27 19:58:37 +00:00
Ed Sanders 52cd0f9b05 Prevent FOUC when loading OOUI notification badges
Change-Id: I216d1f7ff90380040742e6c78df830a9dcb0b261
2018-03-27 13:54:27 +01:00
Ed Sanders 0fd6d64a29 Fix DOM structure of mw.echo.ui.MenuItemWidget
* Inherit from DecoratedOptionWidget as it comes with
  an icon mixin.
* Keep the DOM structure as similar to its parent as
  possible, to avoid breaking upstream child selectors.
* To this end, replace <a> wrapping hack with override
  of getTagName to set this.$element to <a>.

Change-Id: Ifde70785a1bc996eb09e581b06ed30708323e9f7
2018-03-27 12:33:40 +01:00
Volker E 77021e370c Align Notifications popup header/footer with OOUI's default size
Bug: T190397
Change-Id: I41ad96bbc7d3922772ecb026cb251476882601c7
2018-03-26 20:13:08 -07:00
Volker E cc3df57d71 NotificationsOptionWidget: Fix icon alignment
Change-Id: Ieb5c9a8e378608e096e921fdb6795949a119c8a8
2018-03-26 02:15:36 -07:00
jenkins-bot 05e42c6a6a Merge "Use updated bell/tray icons from OOUI 0.26" 2018-03-24 17:05:50 +00:00
Ed Sanders 4523cc4ac5 Follow-Up Ie6252a8c: Fix suffices of constructive icons
Also fix title of mention-success.

Change-Id: I699ae249ea7c4b3da869cc10bf6ee240c666547d
2018-03-24 15:22:03 +00:00
Ed Sanders 15a3443384 Use updated bell/tray icons from OOUI 0.26
As these are smaller canvases, fix positioning
hacks accordingly.

Change-Id: I472f8cdd5887243c3fd86ab1431532a99dba1ce9
2018-03-24 15:06:47 +00:00
Ed Sanders 91076ef7c0 Update OOUI-copied icons
* Rename to match their upstream names.
* For icons without upstream versions, fix canvas to 20x20.
* Use consistent suffices to indicator colour.

Change-Id: Ie6252a8ccbba79143a0f77536c6470b4350be1ad
2018-03-23 09:41:15 -07:00
jenkins-bot 9c57911f97 Merge "Replace double-check with checkAll from OOUI" 2018-03-22 23:42:11 +00:00
Ed Sanders 34e3d5feba Replace double-check with checkAll from OOUI
checkAll was specifically designed as a
replacement for double-check.

Change-Id: Ibdd6865213107650b9004ab40e12c6a7453b6251
2018-03-22 21:23:33 +00:00
jenkins-bot b5780d0d1a Merge "Remove unused 'trash' icon" 2018-03-22 20:11:29 +00:00
Ed Sanders 54f49875e9 Remove unused 'trash' icon
There are no references to 'trash' in the code.

Change-Id: Icbc50f6e0f647466a8f4a2a47ee7014c5d411ffe
2018-03-22 19:52:44 +00:00
Ed Sanders ff78ed310a Remove unused bellOn icons
Change-Id: I40903bb8a8ea964482b6603436af27caaf73f574
2018-03-22 19:40:43 +00:00
Moriel Schottlender cb43a785b8 Place the notification page settings popup in an overlay
Bug: T189428
Change-Id: I4d8ccb76b7fe46333f65a5f7caa15a1203b662ce
2018-03-11 15:18:24 -07:00
jenkins-bot 09177edf91 Merge "Prevent double-clicking on badge when initializing" 2018-02-23 22:47:02 +00:00
Moriel Schottlender b2f2ef9114 Prevent double-clicking on badge when initializing
Double-clicking would just recreate the badge midway while it is
being created, and produce 2 popups simultaneously. This patch
ignores the second click in a double-click until the widget is
being replaced anyways.

Bug: T184883
Change-Id: I2fda8df36b3828dbbe0d9b7892f159e598c630bd
2018-02-23 14:36:39 -08:00
jenkins-bot 30a265ef88 Merge "build: Bring SVGO optimization to build step" 2018-02-22 20:41:48 +00:00
Fomafix a447c3e65f Use jQuery 3 .catch( fn ) instead of .then( null, fn )
https://api.jquery.com/deferred.catch/ Since jQuery 3
deferred.catch( fn ) is an alias to deferred.then( null, fn )

Change-Id: I120ec780c9b008b5e7bf12491fed83ccc8ae2420
2018-02-10 11:48:26 +01:00
Volker E c9403011c8 build: Bring SVGO optimization to build step
Enabling SVGO automation with 'grunt-svgmin' and conservative
plugin settings to build step, among those:
- enable removeRasterImages and sortAttrs,
- disable cleanupIDs, removeDesc, removeTitle, removeViewBox &
  removeXMLProcInst and
- don't use multipass.

Also updating SVGs accordingly.

Bug: T185596
Change-Id: I2288c7576ac96f8b5c4d5b8671218fceefaf6037
2018-02-09 23:06:28 -08:00
Ed Sanders 17be84ec51 Sticky toolbar: Add missing vendor prefix
Change-Id: Ib1a68298295e7c0ae276a1cec92c5c67adb7b643
2018-02-04 21:26:06 +00:00
Stephane Bisson ac4b0ea899 Make icon not overlap with confirmation message
Use widgets instead of mixins to compose the ConfirmationPopupWidget.

Bug: T184733
Change-Id: I608e820ef81b01efc54a13df5de189ef40ce335f
2018-02-02 20:31:43 +00:00
Ed Sanders 2121daac96 Don't hide notification popup when scrolling
hideWhenOutOfView is for preventing popups from appearing
outside their container, but in this case the container
is the document, so it is already clipped.

Bug: T178384
Change-Id: Ie0cd83849446cf74b61e708f0a1fa79f2384a94a
2018-01-22 15:32:35 -08:00
jenkins-bot e63b9f9ac0 Merge "Fix help menu icon placement for monobook" 2018-01-19 18:44:00 +00:00
jenkins-bot f321dc1250 Merge "Align the icon in the popup action sub menus" 2018-01-19 18:38:39 +00:00
jenkins-bot d0550c9f6c Merge "Truncate page name in the sidebar and organize into table view" 2018-01-18 11:43:47 +00:00
Volker E 4bb614b5fd Use “OOUI” as unified name for code comments
Bug: T182360
Change-Id: Ib1daa160dd7597afe6a6ae22dc263ba7d297f757
2018-01-16 23:30:18 -08:00
Moriel Schottlender aecacd9443 Align the icon in the popup action sub menus
Also bring the icon rules up to a rule that actually
overrides ooui ruleset.

Bug: T185046
Change-Id: Iea0305d2b90c659fc24113980fa0900f559c2ab4
2018-01-16 16:40:46 -08:00
Moriel Schottlender 1e9f4a106c Fix help menu icon placement for monobook
Bug: T184023
Change-Id: I6aa356624c7d9532fc69503f0ab99f0511fc30dc
2018-01-16 14:09:58 -08:00
Moriel Schottlender df4aa8ea0b Truncate page name in the sidebar and organize into table view
Organize into table view for consistency and truncate the title.

Bug: T184143
Change-Id: I0ae3105ea60dcc2ae6c0f7f2545368a5f86cb2c4
2018-01-16 12:09:01 -08:00
jenkins-bot 9e56017681 Merge "Use findItem(s)FromData instead getItem(s)FromData" 2018-01-11 01:37:27 +00:00
petarpetkovic 309ea8e936 Fix "Mark as read" button icon on no-JS
Bug: T182167
Change-Id: I2c386e1ab2c95d2d1034c8d366d39c12827b3d22
2018-01-03 15:50:45 +01:00
Bartosz Dziewoński ada3be576c mw.echo.ui.NotificationBadgeWidget: Do not flip popups
Bug: T183296
Change-Id: I3850cf71626d700a73bbefae7da9870d59491347
2017-12-30 00:51:18 +01:00
Bartosz Dziewoński 7cc225ca33 mw.echo.ui.MenuItemWidget: Override OOUI styles harder
Bug: T183435
Change-Id: I949de77ac8221bdc4bb35ae7b75e3df91d861d07
2017-12-27 14:07:53 +00:00
jenkins-bot 010bb75603 Merge "Move the popups to the overlay" 2017-12-21 18:14:50 +00:00
Moriel Schottlender 77acb5b3ee Move the popups to the overlay
This will solve multiple issues with the design having to overcome
the theme-based design for the #p-tools.

Bug: T156080
Change-Id: Ibfcdfeea649e566059fd88485e146fbad2201016
2017-12-20 15:44:27 -08:00
Prateek Saxena 391f14cb4b Use findItem(s)FromData instead getItem(s)FromData
Depends-on: Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
Bug: T76630
Change-Id: Iddd1d3f5abaa233adbf030114343a8ed248de28b
2017-12-14 13:36:26 +05:30
petarpetkovic cde5b2d1e9 Add fallback to getting Preferences and Notifications URLs
Change-Id: I0ab756cafcbd535fa1765fd12fdd72bb75f0df62
2017-12-13 23:12:07 +01:00
Albert221 c6388532c0 Better color to represent read notifications
Replace color of read notification background
in notifications list with Base 80, also
slightly increase opacity of timestamp to
be more visible.

Bug: T78594
Change-Id: I93e26a9eb7e01a8b46bcac8b7ed72ddf06a63f30
2017-12-09 02:11:08 +01:00
petarpetkovic 41a4cc4ae6 Add left padding to PageNotificationsOptionWidget
Bug: T177065
Change-Id: I71a9bafe520faf04e59c093761ed1303b13861bb
2017-11-28 16:05:01 +01:00
Volker E 738524da4a Equal CrossWiki/BundleNotificationItemWidget group's padding
Follow-up I18c0caea2438399d6f97e59c47177691cb43816d.

Bug: T177723
Change-Id: Iaa7a19d3d2064d3258bdd161056976fc0ebc781e
2017-11-09 11:43:05 -08:00
Volker E 64c07dfb68 Unify SVG markup
Align SVG markup across Foundation products by:
- unifying XML declaration,
- removing unnecessary `standalone="no"` attribute as it's default,
- removing all `g` group elements where applicable,
- bringing attributes in order,
- removing unnecessary ids and
- unifying whitespace.

Bug: T178867
Change-Id: Id3799a46c14f793636ca9bca3ad0f642466ed5a0
2017-11-04 14:21:06 -07:00
jenkins-bot e25e8b1231 Merge "Use position:sticky for toolbar floating" 2017-10-18 23:01:56 +00:00
Bartosz Dziewoński 6fa38a985c mw.echo.ui.PageNotificationsOptionWidget: Fix CSS after changes in OOjs UI
We have to override 'position: absolute' and increase the specificity
of the selector to override 'display: block'.

Bug: T178439
Change-Id: Icd09e8302f124524779553eae3536d875f2e1227
2017-10-18 20:56:27 +02:00
Ed Sanders cfa130cc13 Use position:sticky for toolbar floating
Avoids any scroll-based DOM changes which slow down scroll events.
Removes floating in browsers without sticky support (mostly IE).

Change-Id: If75e2a90d76644296fe3db5ef8bd9b26de4e7b0c
2017-10-17 15:22:26 +01:00
Ed Sanders 892ba8e5fe build: Update eslint and other linters
Change-Id: I68b74742bea0c3d4c8e359fd7850beaa6bbc4190
2017-10-17 13:53:08 +01:00
jenkins-bot 3460faa930 Merge "Fix CrossWiki-/BundleGroup layout" 2017-10-17 01:44:02 +00:00
Volker E 6a74084e01 Fix CrossWiki-/BundleGroup layout
Fixing CrossWiki-/BundleGroup layout after OOUI button height,
which is used as header in this case, has been increased.
Also removing `border-bottom`, `box-shadow` and
`border` of next item respectively notification footer are
sufficient and result in the groups being less crowded.

Bug: T177723
Change-Id: I18c0caea2438399d6f97e59c47177691cb43816d
2017-10-16 18:29:12 -07:00
jenkins-bot bab8145f06 Merge "Align popup message color to toast message in MinervaNeue" 2017-10-12 19:19:12 +00:00
jenkins-bot b2b7547877 Merge "Replace vendor prefixed box-shadow with central mixin" 2017-10-10 21:16:49 +00:00
Volker E 4b3782a46a Replace subtle greys with WikimediaUI color palette ones
Bug: T177723
Change-Id: Iceafe2f3e702667e0ee68b79ddcb6aa4d8fd0010
2017-10-08 10:26:43 -07:00
Volker E d4682c9f14 Align popup message color to toast message in MinervaNeue
Toast messages carry now `#222`. This should be used here as well.

Bug: T177723
Change-Id: I7e1f6c2e1937353b0485ed0b5c2737742c62e770
2017-10-08 09:55:18 -07:00
Volker E 1a46e0f06f Replace vendor prefixed box-shadow with central mixin
Replacing vendor prefixed `box-shadow` with LESS mixin out of
mediawiki.mixins.less. This also removes obsolete `-moz-box-shadow`
saving some bytes.

Change-Id: I336ee7340bc518fef74762a8381495265dd3eb4b
2017-10-08 09:50:09 -07:00
Kaldari 4381dbbe8a Fix gap between notification pop-up header and notifications
Change-Id: I12261ad8033af7286d426933df19611b8163d9c9
2017-09-26 18:44:56 -07:00
jenkins-bot 31709919e4 Merge "Consistently use the message when updating count" 2017-09-18 15:08:17 +00:00
Moriel Schottlender 57f14931b6 Consistently use the message when updating count
The current initial message in the button label is "Alerts (x)" or
"Notices (x)" but when the badge loaded, we changed that to only show
the rendered number. This is inconsistent; the badge should always
update the label properly, even if it's not visible in most cases.

Bug: T173970
Change-Id: I6a5e13fc36ddb1bf467c712fcf49af3b18e582d0
2017-09-14 17:33:48 -07:00
Moriel Schottlender c086169138 Use "formatversion: 2" in notification fetching
This means booleans are actually true/false rather than value or
empty-string.

Bug: T175867
Change-Id: I3d33129d061a64012602a131741d20e2ff97d1be
2017-09-13 15:18:07 -07:00
Matthew Flaschen f80a11d53b Fix interpretation of 'prioritized'
Docs (especially in EventPresentationModel.php) say true means outside
the menu, false inside.

However, it was interpreting any non-undefined value as true.

Change-Id: Icb438538e5c588c1ac7d4bbac0b762dd07057199
2017-09-07 19:13:10 -04:00
Volker E 537708ce76 Update Red50 'destructive' color
'Destructive' color was updated in WikimediaUI color palette to
ensure WCAG 2.0 level AA conformance with both, white and black.
Due to WikimediaUI Base not in central place we still have to care about
this manually.

Change-Id: I7402ef64b1aa28c2cffeb9bca2804b1dfbecec42
2017-08-21 16:06:06 -07:00
Moriel Schottlender 9e320bac6a Fix 'unread' dot top padding regression
All frameless buttons seemed to have recieved a generous padding-top
in the latest OOUI release. This fix overrides that.

Bug: T173059
Change-Id: Ia1f1bbc48410555163afabc84a199e7a69bb95dc
2017-08-21 11:21:39 -07:00
Volker E d7ebaf8c8b Replace outdated border-radius value with WikimediaUI one
Change-Id: Iebfd55c8e7f52f207f45dc547fccaf89107e8a32
2017-08-17 17:22:57 -07:00
jenkins-bot e74713a3ba Merge "Add 'Mark all as read' button" 2017-08-13 16:19:56 +00:00
mdew192837 e88185c54e Add 'Mark all as read' button
Currently, the 'Mark all as read' button exists only for JS users.
This patch adds the button for no-JS users as well.

Bug: T96061
Change-Id: I1a62c56306597209540ffd694c8fb7b2a92885c9
2017-08-13 10:55:46 -05:00
Roan Kattouw 0bf4861d92 Fix layout regression in notification popup footer
Caused by a new margin rule in OOUI.

Bug: T171302
Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
2017-07-21 13:04:51 -07:00
Roan Kattouw 4cf17a6712 Fix alignment of the "Mark all read" button
Bug: T169019
Change-Id: Ie63e74bef594e9c21c8a9bb615454c4a526276c2
2017-06-27 14:46:19 -07:00
Roan Kattouw 23252571a4 Migrate from FloatingMenuSelectWidget (deprecated) to MenuSelectWidget
Bug: T168679
Change-Id: I987a4b12560d03cc5eec7f8a57020a3e726a040f
2017-06-23 12:58:22 -07:00
Moriel Schottlender f05131a8ef Fallback to dbname if source title doesn't exist
This shouldn't happen regularly, since the source should always
have a title through a wg* variable in LocalSettings.php but in
cases where that is not set up correctly, or is missing for whatever
reason, the system should always fall back to displaying the name
of the source, if the title doesn't exist.

Bug: T164112
Change-Id: I94074adc260a5caf55ca21578fd7071b3323a5e6
2017-06-05 16:40:15 +03:00
jenkins-bot 2de9b411c7 Merge "Follow-up 739847c20: don't adjust the popup anchor position" 2017-05-02 18:39:02 +00:00
Roan Kattouw dd2bdd64af Follow-up 739847c20: don't adjust the popup anchor position
We used to need to center the anchor, but I375a76a49337d3b on oojs-ui
makes popup anchors center themselves, so this is now harmful.

Bug: T163993
Change-Id: I345727ae4175fd9d3cea024f43df802bcd401838
2017-05-02 10:55:02 -07:00
Roan Kattouw 2691d94e0f Don't truncate notification header messages in bundles
Bug: T163518
Change-Id: I569aeba7b8f87ca46a81ffb5a56c241342dc3d21
2017-05-02 10:50:13 -07:00
Stephane Bisson c46d56b018 Special:Notifications show unread by default if there's unread notifications
Bug: T162927
Change-Id: Ibdfaca90803eb8b12b12eb1781b0692e7336b7d9
2017-04-19 15:20:12 -04:00
Moriel Schottlender ebbe2e81af Make date headings a proper semantic <h2> heading
To support accessibility, make sure the titles in Special:Notifications
are <h2> headings.

Bug: T149955
Change-Id: I4f15694efb04896e9bd7b026d297891047759644
2017-04-13 22:39:28 +00:00
Mooeypoo 84d34a3901 Revert "Do not use fancy styled badge on Modern and CologneBlue"
This reverts commit 08d224e955.

Causes bugs in Vector when displaying the badges.

Bug: T162173
Change-Id: I9e92c304b47ce9204d7a7d2fba67118e67b1bdc9
2017-04-04 18:40:09 +00:00
Bartosz Dziewoński 08d224e955 Do not use fancy styled badge on Modern and CologneBlue
Just show the textual "Alerts (1)" and "Notices (1)".

Updated NotificationBadgeWidget to use that internally as label,
same as the PHP-generated list item does after d4d325e7.

Bug: T141944
Change-Id: I468c67b0866530e21c9af32cd02816075a3693a1
2017-04-01 14:57:34 +02:00
jenkins-bot 85c9397bce Merge "Fire 'ext.echo.badge.countChange' after DOM changes" 2017-04-01 04:52:54 +00:00
Bartosz Dziewoński f0875de9f3 Stop badge hacks from messing up the entire page on IE 11 on MonoBook
Looks like we're hitting an edge case where positioning with negative
offsets inside an inline-block element results in incorrect rendering.
We're accidentally rendering an invisible overlay over nearly the
entire page. Twiddle the styles until we no longer hit that case.

Minimal example of the IE 11 bug: https://jsfiddle.net/50v6m0kb/3/

Bug: T161869
Change-Id: Id4b6ccc1ec6a11b455d6ab45c5aaa0e8544385f7
2017-03-31 20:41:00 +02:00
Moriel Schottlender 5c35535f36 Fire 'ext.echo.badge.countChange' after DOM changes
The event should fire after the count actually changes in the
DOM as well as the internal workings of Echo.

Change-Id: I03f1742b209305080af8784632f07dff63135d81
2017-03-30 15:22:02 -07:00
jenkins-bot ea942c6250 Merge "Fix JS error when closing notification popup while animating a moving notification" 2017-03-30 17:59:32 +00:00
Bartosz Dziewoński 945fccf009 Make the invisible text in badges really invisible
Bug: T161302
Change-Id: I5c7a5bcb7a096b69c28651c6fe1e4017654997ad
2017-03-28 18:26:26 +02:00
Roan Kattouw 089531c1e9 Fix JS error when closing notification popup while animating a moving notification
This failed because it tried to call .resetInitiallyUnseen()
on a ClonedNotificationItemWidget.

Change-Id: Ib675aecfb0d916bfb25f17ad738f3a493a49dd1b
2017-03-28 12:24:25 -04:00
Bartosz Dziewoński c39fffd82f Simplify definition of 'ext.echo.badgeicons' module
* The JSON file for the Apex theme was exactly identical to the
  MediaWiki theme. If the icons are the same, there's no need to
  duplicate it.
* Since we now only have one definition used for all themes,
  ResourceLoaderOOUIImageModule is overkill and we can use the
  slightly simpler ResourceLoaderImageModule.
* Remove "prefix": "oo-ui-icon" from the JSON file, since it is
  overridden in the module definition by "selectorWithoutVariant" and
  "selectorWithVariant".

Change-Id: I1d579873459e079369fd13350a9cb00939c2b76b
2017-03-21 20:33:10 +01:00
Roan Kattouw 739847c20f Fix RTL popup alignment for OOjs UI 0.19.5
Popup alignment corrections are now done with margins on the anchor,
not directly on the popup. Setting "left" also didn't have any effect,
because it was being overridden by inline styles set by the new
PopupWidget/FloatableElement code.

Bug: T159999
Change-Id: I7738edee7ae096fcc116a79e71a591a2287ea34f
2017-03-08 15:39:50 -08:00