wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-09-23 10:22:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent double-clicking on badge when initializing

Browse source 
Double-clicking would just recreate the badge midway while it is
being created, and produce 2 popups simultaneously. This patch
ignores the second click in a double-click until the widget is
being replaced anyways.

Bug: T184883
Change-Id: I2fda8df36b3828dbbe0d9b7892f159e598c630bd
This commit is contained in:
Moriel Schottlender 2018-02-23 14:35:33 -08:00
parent 38ec20ce27
commit b2f2ef9114
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ext.echo.init.js
View file

@ -36,10 +36,12 @@
var time = mw.now(),
myType = $( this ).parent().prop( 'id' ) === 'pt-notifications-alert' ? 'alert' : 'message';
if ( e.which !== 1 ) {
return;
if ( e.which !== 1 || $( this ).data( 'clicked' ) ) {
return false;
}
$( this ).data( 'clicked', true );
// Dim the button while we load
$( this ).addClass( 'mw-echo-notifications-badge-dimmed' );