Commit graph

7049 commits

Author SHA1 Message Date
jenkins-bot 91bc7dcd81 Merge "Fix UserMerge integration for use with table prefix" 2019-03-04 07:55:07 +00:00
Translation updater bot ebdc8df419 Localisation updates from https://translatewiki.net.
Change-Id: I06e4ebadb0cbaed3be1df8baba21d85ebc13ac0b
2019-03-03 22:17:37 +01:00
Umherirrender 833731c572 Remove non-functional maintenance script testDiscussionParser.php
It is calling an undeclared function, I have not found it in older
version of that class.

Change-Id: Ia9a432e1b90c76e8f1295c0afe4d12817bc232ae
2019-03-03 16:46:17 +01:00
Umherirrender 42f153caf5 Use ::class for class name resolution
Available since php5.5

Change-Id: I8ea594e59784bfe68911fb0b138f359a0e6b4d54
2019-03-03 15:14:15 +01:00
Translation updater bot e808e4d6fa Localisation updates from https://translatewiki.net.
Change-Id: I5356e49cdf3c1281d1eb0cd4dad947000477f0a4
2019-03-02 22:42:26 +01:00
Umherirrender 1b5308ba81 Use explicit columns and avoid SELECT *
Change-Id: Ibde033784aee5adc13fae6f1d395d9464f54fefd
2019-03-02 22:39:53 +01:00
Umherirrender 8ce0cc171d Fix UserMerge integration for use with table prefix
This fixes tests, because EchoHooks has "echo_event.*" which is invalid
with table prefixes, like done in unit tests
Added EchoEvent::selectFields() for future use and to replace more
SELECT *

Bug: T217487
Change-Id: I51cb46812431635d11780633dc7d807cd04f813d
2019-03-02 22:05:22 +01:00
Umherirrender 8da7e5b04a Pass string as field to IDatabase::selectField and ::selectRowCount
It is documented as string, because it can only select one field,
not a list of fields

Change-Id: Iad8ff691e642220359f45f97359aa624261af673
2019-03-02 17:29:29 +00:00
jenkins-bot 19cef58454 Merge "NotificationDeleteJob: Remove unused variable $targetMapper" 2019-03-02 03:43:50 +00:00
Roan Kattouw db6c1f076d NotificationDeleteJob: Remove unused variable $targetMapper
Change-Id: Iaf5e3ae53ae55820dca9c7b7d96506154af0f75d
2019-03-01 17:05:10 -08:00
Aaron Schulz bb0ca321df Convert caching to WANObjectCache
Change-Id: I6c0315aa6e24c573cf9a8410ff21471ed3da60d1
2019-02-28 21:56:38 -08:00
jenkins-bot c9b2770c8c Merge "Declare class properties in Formatter and WikiRequest" 2019-02-28 23:41:34 +00:00
Translation updater bot f29af7ffee Localisation updates from https://translatewiki.net.
Change-Id: Icc2012ba3b3036407f7596edf8942aeb0cd3f201
2019-02-28 22:24:45 +01:00
jenkins-bot c3a08d478a Merge "Use local vars in LabelIconWidget" 2019-02-26 12:40:45 +00:00
Translation updater bot 0d80100a59 Localisation updates from https://translatewiki.net.
Change-Id: Ia8a3af6e159fcaac60bbc76f1cc58c0432e978f5
2019-02-25 22:57:48 +01:00
Umherirrender 79b2611bbc Use local vars in LabelIconWidget
Change-Id: I037b02c7336d68f520e028a16df0edd0237458d8
2019-02-23 21:26:35 +01:00
Thiemo Kreuz afdcce5059 Add type hints and remove unused code from tests
This patch contains a series of different clean-ups in test classes.
Some documentation is added as well as soft and hard type hints. Note
all this is exclusively done in tests. So if the CI is fine with it,
it can't be wrong. Right? ;-)

Change-Id: Ibcf1f65f48ac0fb41837c47672dddfd70302e9fd
2019-02-20 19:16:33 +00:00
Thiemo Kreuz 8fd66d4281 Make use of the …::class feature in production code
This codebase already used the …::class feature a lot. This is more
about making the code consistent and easier to refactor in the future.

Change-Id: If5b2456b825aae753ed97445160ec191c18df8e3
2019-02-20 19:13:54 +00:00
Isarra 91cd3b3b98 Apply unseen notifications colours to all skins by default
Colours were previously defined only in the monobook- and vector-specific
styles, but with the same styles in each, and appear to work consistently
accross all tested skins (modern, timeless, cologneblue, anisa,
hassomecolours...). Given the UX importance of these colours, better to
apply them as the default for all skins and leave it to any others for
which this doesn't work to resolve any issues on their end.

bug: T181142
Change-Id: Idc22881d6c51aa12adc9a053ce08adfdf0fad2b0
2019-02-20 15:04:35 +00:00
jenkins-bot decb91d9dc Merge "Replace @expectedException with $this->expectException()" 2019-02-19 21:39:28 +00:00
jenkins-bot 539d2fd485 Merge "Simplify a few overly complex code snippets" 2019-02-19 21:38:00 +00:00
Translation updater bot 774ec6a93e Localisation updates from https://translatewiki.net.
Change-Id: I70bfb566da24629951d967bfbcc5bf3668d3c04e
2019-02-19 22:19:49 +01:00
Thiemo Kreuz 5941ef476c Replace @expectedException with $this->expectException()
The @expectedException annotation got deprecated in PHPUnit 7.5, and
removed in PHPUnit 8.0. This was done because the annotation does have
two disadvantages:
* The class name is encoded in string, where it is not easy to find for
  all IDEs and tools.
* it did not allow to say exactly *when* the exception is expected.

Change-Id: I96862a18874f36355e817accd64d8703c1965c86
2019-02-19 20:54:15 +00:00
Thiemo Kreuz e649551e5e Simplify a few overly complex code snippets
* preg_match_all already returns the number of matches. We can just use
  this number instead of counting it.
* Checking for a strlen() of 0 is a little tooo expressive, because we
  don't really care about the actual length of the string.

Change-Id: I0537a7740e5d369b79364f24aecf71c4e8fa7db1
2019-02-19 20:39:26 +00:00
Thiemo Kreuz c36d2bd0e8 Prefer the …::class feature over hard-coded strings in all tests
The codebase already used the …::class feature in many places. So this
is more for consistency than anything. The …::class feature makes it
much easier to do refactoring in the future.

Note this patch is exclusively touching tests. That should make it
relatively easy to review this. As long as the CI is fine with it, it
should be ok. Right? ;-)

Change-Id: I4d2adee76b4adbc83b2061161fd4e863ba833fcb
2019-02-19 14:35:14 +00:00
Translation updater bot 2e45f12018 Localisation updates from https://translatewiki.net.
Change-Id: Ie15e132d0ed4e52e0566badde9654b71eb1218b6
2019-02-18 22:22:58 +01:00
Umherirrender fdc2b42b2b Declare class properties in Formatter and WikiRequest
Change-Id: Iaf4c2f7bb75896d3daafbb445f7b5f6341543f8e
2019-02-18 19:25:56 +00:00
Translation updater bot fd82365276 Localisation updates from https://translatewiki.net.
Change-Id: I83fca921e52bed62901b8ce7bec819a67028311c
2019-02-17 22:14:11 +01:00
jenkins-bot 3fd6549ced Merge "Improve param docs and add @var to clarify types" 2019-02-17 01:29:48 +00:00
Matěj Suchánek cd4e510201 Fix undeclared var
Credit goes to Umherirrender who pointed this out.

Change-Id: I4d590b3574ea1310fa795cfd94a129e3046e6e3c
2019-02-15 21:25:27 +01:00
Umherirrender cdae062d47 Improve param docs and add @var to clarify types
Change-Id: I44f872b3a2921e75aab8e22fec57735f17ee1d8b
2019-02-15 21:23:02 +01:00
Translation updater bot 3b3f5a419f Localisation updates from https://translatewiki.net.
Change-Id: I5cf6ccb9e7cd6128f35a67bd06463b6bd0c97572
2019-02-14 22:29:04 +01:00
Translation updater bot 8a4fba0e3e Localisation updates from https://translatewiki.net.
Change-Id: Ide6d49a9f5ceb37fa120a53c69b9e6d284e4341d
2019-02-12 22:25:34 +01:00
Translation updater bot 0e3745b131 Localisation updates from https://translatewiki.net.
Change-Id: Id9865d23678e87a45825ba665864474563ef7968
2019-02-10 22:18:32 +01:00
Ed Sanders aee27014e9 SpecialHelpMenuWidget: Remove button handle hack
This leads to broken styling in OOUI 0.30, and is only
a marginal improvement in the Apex theme.

Bug: T215509
Change-Id: Id7d000be7c9dcd50e050f067c6f1fbdc06f332af
2019-02-07 14:41:55 +00:00
libraryupgrader 5bd2eaf70e build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Change-Id: Ifd3dde125bae36b1076576ddc0c8b09eadd18a72
2019-02-06 13:01:32 +00:00
Ed Sanders 7ed027ddcf build: Update eslint-config-wikimedia to 0.10.1
Change-Id: I776585adab962c2b1d353d18d3a02b6662941b13
2019-02-06 01:42:53 +00:00
Translation updater bot d9fb41dbf6 Localisation updates from https://translatewiki.net.
Change-Id: If3495e3f283f899bfc0372388c7a7a39a41e2801
2019-02-05 22:37:39 +01:00
Translation updater bot 13c95f444b Localisation updates from https://translatewiki.net.
Change-Id: I9386291c36d625963680b0d6a06c3629a2a8d6b0
2019-02-03 22:38:19 +01:00
Translation updater bot e679fdc8af Localisation updates from https://translatewiki.net.
Change-Id: I9029910b668eeeed7c63a41697385e5e1caa9a6f
2019-01-31 22:25:58 +01:00
Translation updater bot ec98683850 Localisation updates from https://translatewiki.net.
Change-Id: Ia05fdba596ca9f006c7988cc3a0d1a02f48861d8
2019-01-30 22:13:57 +01:00
Translation updater bot 33cae175f5 Localisation updates from https://translatewiki.net.
Change-Id: I7bc8c7c42c7ef587a76bc27cf3867e7d61becdc9
2019-01-28 22:26:49 +01:00
Translation updater bot 3b0a2887bc Localisation updates from https://translatewiki.net.
Change-Id: Ica01eef8836499a76f8886de2b889253fe3ceeec
2019-01-25 22:28:54 +01:00
Translation updater bot 71a815e445 Localisation updates from https://translatewiki.net.
Change-Id: I79698a52b276c09765063cbe5223957de17f9ed8
2019-01-22 22:17:15 +01:00
Translation updater bot c9e9024cd1 Localisation updates from https://translatewiki.net.
Change-Id: I55578d3c3145be734db8010a4e49c02dfa2081e8
2019-01-20 22:35:50 +01:00
Translation updater bot 5ad88e20e3 Localisation updates from https://translatewiki.net.
Change-Id: Ic62104ff7996fd1e9a9d15bf92d63a92a8015e0b
2019-01-18 22:18:54 +01:00
Translation updater bot 2acd3aa6a7 Localisation updates from https://translatewiki.net.
Change-Id: I83130ec85a0ef25973fcd6563d6f99e9a6f5764e
2019-01-17 09:12:29 +01:00
Matěj Suchánek 8994407a7d Remove duplicate notifications after merging users
Bug: T103747
Change-Id: Ic2612e5d7861ef7c6a22ab66fd3b9d6ea71f959f
2019-01-16 18:38:34 +01:00
Translation updater bot cfffc7aa0c Localisation updates from https://translatewiki.net.
Change-Id: I77bc85cc44eceaa766a02fb2d1b58c74a5a830ea
2019-01-13 22:12:57 +01:00
Translation updater bot dc85a66bac Localisation updates from https://translatewiki.net.
Change-Id: I20744e31a83db90caa0ebb011ad9280fdab55495
2019-01-12 22:39:40 +01:00